github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-22 22:45:27 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Different review status symbol for stale approvals (in Reviewers area of PR) #11395

New Issue
Closed
opened 2025-11-02 09:36:30 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 09:36:30 -06:00
Owner
Copy Link

Originally created by @sebastian-sauer on GitHub (Aug 3, 2023).

Feature Description

Given the following config:
Branch Protection activated, at least 1 approval and Dismiss stale reviews activated.

When I create a PR and Bob reviews the PR his name will get a green checkmark in Reviewers area. (as expected)
I'll now push a change to this PR and Bobs review is dismissed.
The reviewers section now shows me the "hourglass" icon (changes after review) AND it shows me the green checkmark.

At least for me it feels like the green checkmark signals that everything is "good to go". But actually Bob needs to reapprove the changes.

Suggestion: use an orange checkmark (signalling there was an approved review but it's not based on latest PR sha)

Screenshots

No response

Originally created by @sebastian-sauer on GitHub (Aug 3, 2023). ### Feature Description Given the following config: Branch Protection activated, at least 1 approval and Dismiss stale reviews activated. When I create a PR and Bob reviews the PR his name will get a green checkmark in Reviewers area. (as expected) I'll now push a change to this PR and Bobs review is dismissed. The reviewers section now shows me the "hourglass" icon (changes after review) AND it shows me the green checkmark. At least for me it feels like the green checkmark signals that everything is "good to go". But actually Bob needs to reapprove the changes. Suggestion: use an orange checkmark (signalling there was an approved review but it's not based on latest PR sha) ### Screenshots _No response_
GiteaMirror added the type/proposal label 2025-11-02 09:36:30 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/proposal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#11395
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?