github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-15 20:09:18 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Use join for the deleting issue actions query #11386

New Issue
Closed
opened 2025-11-02 09:36:16 -06:00 by GiteaMirror · 4 comments
GiteaMirror commented 2025-11-02 09:36:16 -06:00
Owner
Copy Link

Originally created by @otbutz on GitHub (Aug 1, 2023).

Description

Our current DELETE query for actions is rather inefficient on MariaDB:

DELETE FROM action WHERE comment_id IN (SELECT id FROM comment WHERE issue_id=?)

ab388deb0e/models/activities/action.go (L688-L702)

Caused by https://jira.mariadb.org/browse/MDEV-16289

see https://codeberg.org/forgejo/forgejo/issues/1161 and https://codeberg.org/forgejo/forgejo/pulls/1165

Gitea Version

1.20.2

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Binary started via systemd behind a caddy reverse proxy.

Database

None

Originally created by @otbutz on GitHub (Aug 1, 2023). ### Description Our current DELETE query for actions is rather inefficient on MariaDB: ```sql DELETE FROM action WHERE comment_id IN (SELECT id FROM comment WHERE issue_id=?) ``` https://github.com/go-gitea/gitea/blob/ab388deb0e52c058a19dbd844bdd890f7cf84d51/models/activities/action.go#L688-L702 Caused by https://jira.mariadb.org/browse/MDEV-16289 see https://codeberg.org/forgejo/forgejo/issues/1161 and https://codeberg.org/forgejo/forgejo/pulls/1165 ### Gitea Version 1.20.2 ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? Binary started via systemd behind a caddy reverse proxy. ### Database None
GiteaMirror added the type/bugtype/upstream labels 2025-11-02 09:36:16 -06:00
GiteaMirror commented 2025-11-02 09:36:16 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Aug 1, 2023):

Thank you for the report.

The referred fix on codeberg seems not good enough (eg: the test doesn't cover other databases).

I proposed a new fix: Bypass MariaDB performance bug of the "IN" sub-query #26279

I didn't use "JOIN" because I think it's better to avoid using too many dialects for difference database, while pre-querying the IDs is fast enough.

@wxiaoguang commented on GitHub (Aug 1, 2023): Thank you for the report. The referred fix on codeberg seems not good enough (eg: the test doesn't cover other databases). I proposed a new fix: Bypass MariaDB performance bug of the "IN" sub-query #26279 ---- I didn't use "JOIN" because I think it's better to avoid using too many dialects for difference database, while pre-querying the IDs is fast enough.
GiteaMirror commented 2025-11-02 09:36:17 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Aug 2, 2023):

The main problem is comment_id in action table is not an index column.

@lunny commented on GitHub (Aug 2, 2023): ~The main problem is `comment_id` in `action` table is not an index column.~
GiteaMirror commented 2025-11-02 09:36:17 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Aug 2, 2023):

image

@wxiaoguang commented on GitHub (Aug 2, 2023): ![image](https://github.com/go-gitea/gitea/assets/2114189/125cd3ce-33f0-47ad-9332-bf3ca2f1d869)
GiteaMirror commented 2025-11-02 09:36:17 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Aug 2, 2023):

OK. I see, it's MariaDB's problem.

@lunny commented on GitHub (Aug 2, 2023): OK. I see, it's MariaDB's problem.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug type/upstream
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#11386
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?