github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-21 22:16:14 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Delete user account functionality broken. #11359

New Issue
Closed
opened 2025-11-02 09:35:22 -06:00 by GiteaMirror · 6 comments
GiteaMirror commented 2025-11-02 09:35:22 -06:00
Owner
Copy Link

Originally created by @puni9869 on GitHub (Jul 28, 2023).

Description

Steps to repro.

  1. Login to gitea
  2. Go to settings.
  3. Go to Accounts.
  4. Go to Delete Your Account.
  5. Now click on
    image without entring password.
  6. We get 500 error.

Gitea Version

1.21.0+dev-412-gce27de4d4

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

image image image

Git Version

1.21.0+dev-412-gce27de4d4

Operating System

No response

How are you running Gitea?

locally and try.gitea.io

Database

None

Originally created by @puni9869 on GitHub (Jul 28, 2023). ### Description Steps to repro. 1. Login to gitea 2. Go to settings. 3. Go to Accounts. 4. Go to `Delete Your Account`. 5. Now click on <img width="171" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/63f2db79-2b59-4e15-a41f-2936059b5295"> without entring password. 6. We get 500 error. ### Gitea Version 1.21.0+dev-412-gce27de4d4 ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist _No response_ ### Screenshots <img width="534" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/f555faa8-4644-4fc3-89eb-bada414234a4"> <img width="624" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/7678d714-5df4-4e58-bf4e-41255be9b0bd"> <img width="1392" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/3ffec7bf-08d9-400c-8dbf-acbc35dab02f"> ### Git Version 1.21.0+dev-412-gce27de4d4 ### Operating System _No response_ ### How are you running Gitea? locally and try.gitea.io ### Database None
GiteaMirror added the type/bug label 2025-11-02 09:35:22 -06:00
GiteaMirror commented 2025-11-02 09:35:23 -06:00
Author
Owner
Copy Link

@techknowlogick commented on GitHub (Jul 28, 2023):

Could you share the logs you have?

@techknowlogick commented on GitHub (Jul 28, 2023): Could you share the logs you have?
GiteaMirror commented 2025-11-02 09:35:23 -06:00
Author
Owner
Copy Link

@puni9869 commented on GitHub (Jul 28, 2023):

2023/07/28 23:08:41 ...eb/routing/logger.go:102:func1() [I] router: completed GET /user/events for [::1]:50785, 200 OK in 12017.3ms @ events/events.go:18(events.Events)
2023/07/28 23:08:41 ...s/process/manager.go:231:remove() [T] Done 64c3fd15-8: GET: /user/events
2023/07/28 23:08:41 ...s/process/manager.go:188:Add() [T] Start 64c3fd21: POST: /user/settings/account/delete (request)
2023/07/28 23:08:41 ...eb/routing/logger.go:47:func1() [T] router: started   POST /user/settings/account/delete for [::1]:50788
2023/07/28 23:08:41 ...ices/auth/session.go:51:SessionUser() [T] Session Authorization: Found user[1]
2023/07/28 23:08:41 models/user/user.go:910:GetUserByID() [I] [SQL] SELECT "id", "lower_name", "name", "full_name", "email", "keep_email_private", "email_notifications_preference", "passwd", "passwd_hash_algo", "must_change_password", "login_type", "login_source", "login_name", "type", "location", "website", "rands", "salt", "language", "description", "created_unix", "updated_unix", "last_login_unix", "last_repo_visibility", "max_repo_creation", "is_active", "is_admin", "is_restricted", "allow_git_hook", "allow_import_local", "allow_create_organization", "prohibit_login", "avatar", "avatar_email", "use_custom_avatar", "num_followers", "num_following", "num_stars", "num_repos", "num_teams", "num_members", "visibility", "repo_admin_change_team_access", "diff_view_style", "theme", "keep_activity_private" FROM "user" WHERE "id"=$1 LIMIT 1 [1] - 978.726µs
2023/07/28 23:08:41 ...ices/auth/session.go:67:SessionUser() [T] Session Authorization: Logged in user <User 1:git_tea>
2023/07/28 23:08:41 .../issues/stopwatch.go:149:HasUserStopwatch() [I] [SQL] SELECT * FROM "stopwatch" INNER JOIN "issue" ON issue.id = stopwatch.issue_id INNER JOIN "repository" ON repository.id = issue.repo_id WHERE (user_id = $1) LIMIT 1 [1] - 1.222911ms
2023/07/28 23:08:41 ...b727260d35/engine.go:1246:Get() [I] [SQL] SELECT "id", "lower_name", "name", "full_name", "email", "keep_email_private", "email_notifications_preference", "passwd", "passwd_hash_algo", "must_change_password", "login_type", "login_source", "login_name", "type", "location", "website", "rands", "salt", "language", "description", "created_unix", "updated_unix", "last_login_unix", "last_repo_visibility", "max_repo_creation", "is_active", "is_admin", "is_restricted", "allow_git_hook", "allow_import_local", "allow_create_organization", "prohibit_login", "avatar", "avatar_email", "use_custom_avatar", "num_followers", "num_following", "num_stars", "num_repos", "num_teams", "num_members", "visibility", "repo_admin_change_team_access", "diff_view_style", "theme", "keep_activity_private" FROM "user" WHERE "lower_name"=$1 LIMIT 1 [git_tea] - 951.543µs
2023/07/28 23:08:41 ...r/setting/account.go:244:DeleteAccount() [E] UserSignIn: user's password is invalid [uid: 1, name: git_tea]
2023/07/28 23:08:41 .../context_response.go:68:HTML() [D] Template: status/500
2023/07/28 23:08:41 ...eb/routing/logger.go:102:func1() [I] router: completed POST /user/settings/account/delete for [::1]:50788, 500 Internal Server Error in 31.0ms @ setting/account.go:234(setting.DeleteAccount)
2023/07/28 23:08:41 ...s/process/manager.go:231:remove() [T] Done 64c3fd21: POST: /user/settings/account/delete
2023/07/28 23:08:41 ...s/process/manager.go:188:Add() [T] Start 64c3fd21-2: GET: /assets/css/index.css?v=1d8d90fd3 (request)
2023/07/28 23:08:41 ...eb/routing/logger.go:47:func1() [T] router: started   GET /assets/css/index.css?v=1d8d90fd3 for [::1]:50788
2023/07/28 23:08:41 ...eb/routing/logger.go:102:func1() [T] router: completed GET /assets/css/index.css?v=1d8d90fd3 for [::1]:50788, 304 Not Modified in 0.2ms @ public/public.go:34(public.FileHandlerFunc)
2023/07/28 23:08:41 ...s/process/manager.go:231:remove() [T] Done 64c3fd21-2: GET: /assets/css/index.css?v=1d8d90fd3
2023/07/28 23:08:41 ...s/process/manager.go:188:Add() [T] Start 64c3fd21-3: GET: /assets/css/theme-arc-green.css?v=1d8d90fd3 (request)
2023/07/28 23:08:41 ...eb/routing/logger.go:47:func1() [T] router: started   GET /assets/css/theme-arc-green.css?v=1d8d90fd3 for [::1]:50784
2023/07/28 23:08:41 ...eb/routing/logger.go:102:func1() [T] router: completed GET /assets/css/theme-arc-green.css?v=1d8d90fd3 for [::1]:50784, 304 Not Modified in 0.3ms @ public/public.go:34(public.FileHandlerFunc)
2023/07/28 23:08:41 ...s/process/manager.go:231:remove() [T] Done 64c3fd21-3: GET: /assets/css/theme-arc-green.css?v=1d8d90fd3
2023/07/28 23:08:41 ...s/process/manager.go:188:Add() [T] Start 64c3fd21-4: GET: /assets/img/logo.svg (request)
2023/07/28 23:08:41 ...eb/routing/logger.go:47:func1() [T] router: started   GET /assets/img/logo.svg for [::1]:50784
2023/07/28 23:08:41 ...eb/routing/logger.go:102:func1() [T] router: completed GET /assets/img/logo.svg for [::1]:50784, 304 Not Modified in 0.5ms @ public/public.go:34(public.FileHandlerFunc)
2023/07/28 23:08:41 ...s/process/manager.go:231:remove() [T] Done 64c3fd21-4: GET: /assets/img/logo.svg
2023/07/28 23:08:41 ...s/process/manager.go:188:Add() [T] Start 64c3fd21-5: GET: /assets/img/500.png (request)
2023/07/28 23:08:41 ...eb/routing/logger.go:47:func1() [T] router: started   GET /assets/img/500.png for [::1]:50788
2023/07/28 23:08:41 ...eb/routing/logger.go:102:func1() [T] router: completed GET /assets/img/500.png for [::1]:50788, 304 Not Modified in 1.4ms @ public/public.go:34(public.FileHandlerFunc)
2023/07/28 23:08:41 ...s/process/manager.go:231:remove() [T] Done 64c3fd21-5: GET: /assets/img/500.png
2023/07/28 23:08:41 ...s/process/manager.go:188:Add() [T] Start 64c3fd21-6: GET: /assets/img/favicon.png (request)
2023/07/28 23:08:41 ...eb/routing/logger.go:47:func1() [T] router: started   GET /assets/img/favicon.png for [::1]:50788
2023/07/28 23:08:41 ...eb/routing/logger.go:102:func1() [T] router: completed GET /assets/img/favicon.png for [::1]:50788, 304 Not Modified in 0.7ms @ public/public.go:34(public.FileHandlerFunc)
2023/07/28 23:08:41 ...s/process/manager.go:231:remove() [T] Done 64c3fd21-6: GET: /assets/img/favicon.png
2023/07/28 23:08:49 ...ource/manager_run.go:46:Run() [T] Event source has no listeners
2023/07/28 23:08:49 ...ource/manager_run.go:56:Run() [T] Pausing the eventsource

2023/07/28 23:08:41 ...r/setting/account.go:244:DeleteAccount() [E] UserSignIn: user's password is invalid [uid: 1, name: git_tea]

@puni9869 commented on GitHub (Jul 28, 2023): ```shell 2023/07/28 23:08:41 ...eb/routing/logger.go:102:func1() [I] router: completed GET /user/events for [::1]:50785, 200 OK in 12017.3ms @ events/events.go:18(events.Events) 2023/07/28 23:08:41 ...s/process/manager.go:231:remove() [T] Done 64c3fd15-8: GET: /user/events 2023/07/28 23:08:41 ...s/process/manager.go:188:Add() [T] Start 64c3fd21: POST: /user/settings/account/delete (request) 2023/07/28 23:08:41 ...eb/routing/logger.go:47:func1() [T] router: started POST /user/settings/account/delete for [::1]:50788 2023/07/28 23:08:41 ...ices/auth/session.go:51:SessionUser() [T] Session Authorization: Found user[1] 2023/07/28 23:08:41 models/user/user.go:910:GetUserByID() [I] [SQL] SELECT "id", "lower_name", "name", "full_name", "email", "keep_email_private", "email_notifications_preference", "passwd", "passwd_hash_algo", "must_change_password", "login_type", "login_source", "login_name", "type", "location", "website", "rands", "salt", "language", "description", "created_unix", "updated_unix", "last_login_unix", "last_repo_visibility", "max_repo_creation", "is_active", "is_admin", "is_restricted", "allow_git_hook", "allow_import_local", "allow_create_organization", "prohibit_login", "avatar", "avatar_email", "use_custom_avatar", "num_followers", "num_following", "num_stars", "num_repos", "num_teams", "num_members", "visibility", "repo_admin_change_team_access", "diff_view_style", "theme", "keep_activity_private" FROM "user" WHERE "id"=$1 LIMIT 1 [1] - 978.726µs 2023/07/28 23:08:41 ...ices/auth/session.go:67:SessionUser() [T] Session Authorization: Logged in user <User 1:git_tea> 2023/07/28 23:08:41 .../issues/stopwatch.go:149:HasUserStopwatch() [I] [SQL] SELECT * FROM "stopwatch" INNER JOIN "issue" ON issue.id = stopwatch.issue_id INNER JOIN "repository" ON repository.id = issue.repo_id WHERE (user_id = $1) LIMIT 1 [1] - 1.222911ms 2023/07/28 23:08:41 ...b727260d35/engine.go:1246:Get() [I] [SQL] SELECT "id", "lower_name", "name", "full_name", "email", "keep_email_private", "email_notifications_preference", "passwd", "passwd_hash_algo", "must_change_password", "login_type", "login_source", "login_name", "type", "location", "website", "rands", "salt", "language", "description", "created_unix", "updated_unix", "last_login_unix", "last_repo_visibility", "max_repo_creation", "is_active", "is_admin", "is_restricted", "allow_git_hook", "allow_import_local", "allow_create_organization", "prohibit_login", "avatar", "avatar_email", "use_custom_avatar", "num_followers", "num_following", "num_stars", "num_repos", "num_teams", "num_members", "visibility", "repo_admin_change_team_access", "diff_view_style", "theme", "keep_activity_private" FROM "user" WHERE "lower_name"=$1 LIMIT 1 [git_tea] - 951.543µs 2023/07/28 23:08:41 ...r/setting/account.go:244:DeleteAccount() [E] UserSignIn: user's password is invalid [uid: 1, name: git_tea] 2023/07/28 23:08:41 .../context_response.go:68:HTML() [D] Template: status/500 2023/07/28 23:08:41 ...eb/routing/logger.go:102:func1() [I] router: completed POST /user/settings/account/delete for [::1]:50788, 500 Internal Server Error in 31.0ms @ setting/account.go:234(setting.DeleteAccount) 2023/07/28 23:08:41 ...s/process/manager.go:231:remove() [T] Done 64c3fd21: POST: /user/settings/account/delete 2023/07/28 23:08:41 ...s/process/manager.go:188:Add() [T] Start 64c3fd21-2: GET: /assets/css/index.css?v=1d8d90fd3 (request) 2023/07/28 23:08:41 ...eb/routing/logger.go:47:func1() [T] router: started GET /assets/css/index.css?v=1d8d90fd3 for [::1]:50788 2023/07/28 23:08:41 ...eb/routing/logger.go:102:func1() [T] router: completed GET /assets/css/index.css?v=1d8d90fd3 for [::1]:50788, 304 Not Modified in 0.2ms @ public/public.go:34(public.FileHandlerFunc) 2023/07/28 23:08:41 ...s/process/manager.go:231:remove() [T] Done 64c3fd21-2: GET: /assets/css/index.css?v=1d8d90fd3 2023/07/28 23:08:41 ...s/process/manager.go:188:Add() [T] Start 64c3fd21-3: GET: /assets/css/theme-arc-green.css?v=1d8d90fd3 (request) 2023/07/28 23:08:41 ...eb/routing/logger.go:47:func1() [T] router: started GET /assets/css/theme-arc-green.css?v=1d8d90fd3 for [::1]:50784 2023/07/28 23:08:41 ...eb/routing/logger.go:102:func1() [T] router: completed GET /assets/css/theme-arc-green.css?v=1d8d90fd3 for [::1]:50784, 304 Not Modified in 0.3ms @ public/public.go:34(public.FileHandlerFunc) 2023/07/28 23:08:41 ...s/process/manager.go:231:remove() [T] Done 64c3fd21-3: GET: /assets/css/theme-arc-green.css?v=1d8d90fd3 2023/07/28 23:08:41 ...s/process/manager.go:188:Add() [T] Start 64c3fd21-4: GET: /assets/img/logo.svg (request) 2023/07/28 23:08:41 ...eb/routing/logger.go:47:func1() [T] router: started GET /assets/img/logo.svg for [::1]:50784 2023/07/28 23:08:41 ...eb/routing/logger.go:102:func1() [T] router: completed GET /assets/img/logo.svg for [::1]:50784, 304 Not Modified in 0.5ms @ public/public.go:34(public.FileHandlerFunc) 2023/07/28 23:08:41 ...s/process/manager.go:231:remove() [T] Done 64c3fd21-4: GET: /assets/img/logo.svg 2023/07/28 23:08:41 ...s/process/manager.go:188:Add() [T] Start 64c3fd21-5: GET: /assets/img/500.png (request) 2023/07/28 23:08:41 ...eb/routing/logger.go:47:func1() [T] router: started GET /assets/img/500.png for [::1]:50788 2023/07/28 23:08:41 ...eb/routing/logger.go:102:func1() [T] router: completed GET /assets/img/500.png for [::1]:50788, 304 Not Modified in 1.4ms @ public/public.go:34(public.FileHandlerFunc) 2023/07/28 23:08:41 ...s/process/manager.go:231:remove() [T] Done 64c3fd21-5: GET: /assets/img/500.png 2023/07/28 23:08:41 ...s/process/manager.go:188:Add() [T] Start 64c3fd21-6: GET: /assets/img/favicon.png (request) 2023/07/28 23:08:41 ...eb/routing/logger.go:47:func1() [T] router: started GET /assets/img/favicon.png for [::1]:50788 2023/07/28 23:08:41 ...eb/routing/logger.go:102:func1() [T] router: completed GET /assets/img/favicon.png for [::1]:50788, 304 Not Modified in 0.7ms @ public/public.go:34(public.FileHandlerFunc) 2023/07/28 23:08:41 ...s/process/manager.go:231:remove() [T] Done 64c3fd21-6: GET: /assets/img/favicon.png 2023/07/28 23:08:49 ...ource/manager_run.go:46:Run() [T] Event source has no listeners 2023/07/28 23:08:49 ...ource/manager_run.go:56:Run() [T] Pausing the eventsource ``` `2023/07/28 23:08:41 ...r/setting/account.go:244:DeleteAccount() [E] UserSignIn: user's password is invalid [uid: 1, name: git_tea]`
GiteaMirror commented 2025-11-02 09:35:23 -06:00
Author
Owner
Copy Link

@puni9869 commented on GitHub (Jul 28, 2023):

Its a simple check error UserSignIn: user's password is invalid

@puni9869 commented on GitHub (Jul 28, 2023): Its a simple check error `UserSignIn: user's password is invalid`
GiteaMirror commented 2025-11-02 09:35:23 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Jul 29, 2023):

Its a simple check error UserSignIn: user's password is invalid

Yes, this password error should be displayed in the UI but not return 500

@lunny commented on GitHub (Jul 29, 2023): > Its a simple check error `UserSignIn: user's password is invalid` Yes, this password error should be displayed in the UI but not return 500
GiteaMirror commented 2025-11-02 09:35:23 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Jul 30, 2023):

Caused by #25414 and we now need to check all possible errors come from https://github.com/go-gitea/gitea/blob/main/services/auth/source/db/authenticate.go#L46

@lunny commented on GitHub (Jul 30, 2023): Caused by #25414 and we now need to check all possible errors come from https://github.com/go-gitea/gitea/blob/main/services/auth/source/db/authenticate.go#L46
GiteaMirror commented 2025-11-02 09:35:24 -06:00
Author
Owner
Copy Link

@zyphlar commented on GitHub (Jan 11, 2024):

Also consider the case that the user doesn't have a password, as in oauth2 users via github etc

@zyphlar commented on GitHub (Jan 11, 2024): Also consider the case that the user doesn't have a password, as in oauth2 users via github etc
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#11359
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?