Pull request check list is limited to 30 entries #11279

New Issue

2025-11-02T09:33:10-06:00

GiteaMirror commented

2025-11-02 09:33:10 -06:00

Originally created by @diorcety on GitHub (Jul 19, 2023).

Description

This is linked to the DEFAULT_PAGING_NUM value.
The computation of the check summary status is also wrong due to this limit: A status can be in progress and the summary value having the value "All checks were successful"

Gitea Version

1.19

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Docker

Database

PostgreSQL

Originally created by @diorcety on GitHub (Jul 19, 2023). ### Description This is linked to the DEFAULT_PAGING_NUM value. The computation of the check summary status is also wrong due to this limit: A status can be in progress and the summary value having the value "All checks were successful" ### Gitea Version 1.19 ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? Docker ### Database PostgreSQL

GiteaMirror added the type/bug label 2025-11-02 09:33:11 -06:00

GiteaMirror closed this issue

2025-11-02 09:33:11 -06:00

GiteaMirror commented

2025-11-02 09:33:11 -06:00

@diorcety commented on GitHub (Jul 19, 2023):

Increasing DEFAULT_PAGING_NUM fix the issue: all checks are displayed and the summary status is correct

@diorcety commented on GitHub (Jul 19, 2023): Increasing DEFAULT_PAGING_NUM fix the issue: all checks are displayed and the summary status is correct

GiteaMirror commented

2025-11-02 09:33:12 -06:00

@CaiCandong commented on GitHub (Jul 27, 2023):

I've understood the error, I made a PR to fix this.

@CaiCandong commented on GitHub (Jul 27, 2023): I've understood the error, I made a PR to fix this.

GiteaMirror commented

2025-11-02 09:33:12 -06:00

@yp05327 commented on GitHub (Jul 27, 2023):

Is it possible to fix this by:

Using Int type to save CommitStatus in DB
Using min in sql to get the CommitStatus instead of CalcCommitStatus
Adding a pager bar in web ui

The logic now is loading all CommitStatus (limited 30) into memory from db, and get the minimum value of the status defined in CommitStatusPriorities in CalcCommitStatus.
If we use ListAll, all CommitStatus objects will be loaded into memory.
I think this can be done by db side, then we can avoid loading them into memory and calculating them.

@yp05327 commented on GitHub (Jul 27, 2023): Is it possible to fix this by: 1. Using Int type to save `CommitStatus` in DB 2. Using `min` in sql to get the `CommitStatus` instead of `CalcCommitStatus` 3. Adding a pager bar in web ui The logic now is loading all `CommitStatus` (limited 30) into memory from db, and get the minimum value of the status defined in CommitStatusPriorities in `CalcCommitStatus`. If we use `ListAll`, all `CommitStatus` objects will be loaded into memory. I think this can be done by db side, then we can avoid loading them into memory and calculating them.

GiteaMirror commented

2025-11-02 09:33:12 -06:00

@CaiCandong commented on GitHub (Jul 27, 2023):

Is it possible to fix this by:

Using Int type to save CommitStatus in DB

Using min in sql to get the CommitStatus instead of CalcCommitStatus

Adding a pager bar in web ui

The logic now is loading all CommitStatus (limited 30) into memory from db, and get the minimum value of the status defined in CommitStatusPriorities in CalcCommitStatus. If we use ListAll, all CommitStatus objects will be loaded into memory. I think this can be done by db side, then we can avoid loading them into memory and calculating them.

I agree with you. But this requires more changes to be made and also involves changes to the database structure.

@CaiCandong commented on GitHub (Jul 27, 2023): > Is it possible to fix this by: > > 1. Using Int type to save `CommitStatus` in DB > 2. Using `min` in sql to get the `CommitStatus` instead of `CalcCommitStatus` > 3. Adding a pager bar in web ui > > The logic now is loading all `CommitStatus` (limited 30) into memory from db, and get the minimum value of the status defined in CommitStatusPriorities in `CalcCommitStatus`. If we use `ListAll`, all `CommitStatus` objects will be loaded into memory. I think this can be done by db side, then we can avoid loading them into memory and calculating them. I agree with you. But this requires more changes to be made and also involves changes to the database structure.

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#11279