When trying to update both the profile information and avatar at the same time, confirmation does not always appear #11262

New Issue

GiteaMirror · 2025-11-02T09:32:43-06:00

GiteaMirror commented

2025-11-02 09:32:43 -06:00

Originally created by @audibleptr on GitHub (Jul 18, 2023).

Description

Go to https://try.gitea.io/user/settings.
Make some changes to both user details (e.g. name) and the avatar.
Press "Update Profile/Avatar".
A confirmation that some information will be lost appears as expected. Press Cancel.
Press the other "Update ..." button (e.g. if you pressed "Update Profile" in step 3, press "Update Avatar").

Actual result: no confirmation appears. The last button's associated information is saved (e.g. the avatar), but the other information (e.g. the profile name) is not saved and the pending changes are lost.

Expected result: confirmation appears; pending changes are not lost without confirmation.

Screenshots

N/A

Gitea Version

1.21.0+dev-305-g8bb0a03ea (current at try.gitea.io)

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

ALT Linux

Browser Version

Chromium 114.0.5735.90

Originally created by @audibleptr on GitHub (Jul 18, 2023). ### Description 1. Go to https://try.gitea.io/user/settings. 2. Make some changes to both user details (e.g. name) and the avatar. 3. Press "Update Profile/Avatar". 4. A confirmation that some information will be lost appears as expected. Press Cancel. 5. Press the other "Update ..." button (e.g. if you pressed "Update Profile" in step 3, press "Update Avatar"). Actual result: no confirmation appears. The last button's associated information is saved (e.g. the avatar), but the other information (e.g. the profile name) is not saved and the pending changes are lost. Expected result: confirmation appears; pending changes are not lost without confirmation. ### Screenshots N/A ### Gitea Version 1.21.0+dev-305-g8bb0a03ea (current at try.gitea.io) ### Can you reproduce the bug on the Gitea demo site? Yes ### Operating System ALT Linux ### Browser Version Chromium 114.0.5735.90

GiteaMirror added the issue/confirmed topic/ui type/bug labels 2025-11-02 09:32:43 -06:00

GiteaMirror commented

2025-11-02 09:32:44 -06:00

@lng2020 commented on GitHub (Sep 21, 2023):

That's because we use multiple HTML forms to post data. form-fetch-action class won't work here either. Currently, Github's behavior is just updating the last edited form without saving others. We can easily add ignore-dirty class to follow Github's behavior. But is it a good idea to do so?

@lng2020 commented on GitHub (Sep 21, 2023): That's because we use multiple HTML forms to post data. `form-fetch-action` class won't work here either. Currently, Github's behavior is just updating the last edited form without saving others. We can easily add `ignore-dirty` class to follow Github's behavior. But is it a good idea to do so?

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#11262