github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Allow runner to access organization repositories or implement a way for remote authentication for steps #11248

New Issue
Open
opened 2025-11-02 09:32:09 -06:00 by GiteaMirror · 8 comments
GiteaMirror commented 2025-11-02 09:32:09 -06:00
Owner
Copy Link

Originally created by @LJ1102 on GitHub (Jul 17, 2023).

Feature Description

I have a private gitea instance, I configured it to require sign-in, I want to use actions hosted on my instance, but when I do:

steps:
  - uses: https://my-gitea-instance/myOrg/myAction@latest

The runner is unable to clone the repository:

Unable to clone https://my-gitea-instance/myOrg/myAction refs/heads/latest: authentication required

I think the runner (that is registered to "myOrg") should be able to access repositories of the same organization or we need to be able to provide auth keys for the fetching of actions.

Screenshots

No response

Originally created by @LJ1102 on GitHub (Jul 17, 2023). ### Feature Description I have a private gitea instance, I configured it to require sign-in, I want to use actions hosted on my instance, but when I do: ```yaml steps: - uses: https://my-gitea-instance/myOrg/myAction@latest ``` The runner is unable to clone the repository: ``` Unable to clone https://my-gitea-instance/myOrg/myAction refs/heads/latest: authentication required ``` I think the runner (that is registered to "myOrg") should be able to access repositories of the same organization or we need to be able to provide auth keys for the fetching of actions. ### Screenshots _No response_
GiteaMirror added the type/proposal label 2025-11-02 09:32:09 -06:00
GiteaMirror commented 2025-11-02 09:32:09 -06:00
Author
Owner
Copy Link

@wolfogre commented on GitHub (Jul 20, 2023):

I think the runner (that is registered to "myOrg") should be able to access repositories of the same organization ...

No, the runner has no more permission than fetching and reporting tasks. It can access the repo because the it gets a temporary token with some limited permissions.

It's in the planning to config the permissions of the temporary token, see #24635.

... we need to be able to provide auth keys for the fetching of actions.

@sillyguodong I think you could help.

@wolfogre commented on GitHub (Jul 20, 2023): > I think the runner (that is registered to "myOrg") should be able to access repositories of the same organization ... No, the runner has no more permission than fetching and reporting tasks. It can access the repo because the it gets a temporary token with some limited permissions. It's in the planning to config the permissions of the temporary token, see #24635. > ... we need to be able to provide auth keys for the fetching of actions. @sillyguodong I think you could help.
GiteaMirror commented 2025-11-02 09:32:09 -06:00
Author
Owner
Copy Link

@sillyguodong commented on GitHub (Jul 20, 2023):

We have supported expression in uses in this PR.
So please upgrade your runner, and try to interpolate the token in uses by expression, like below:

uses: https://${{ secrets.GITHUB_TOKEN }}:@my-gitea-instance/myOrg/myAction
@sillyguodong commented on GitHub (Jul 20, 2023): We have supported expression in `uses` in this [PR](https://gitea.com/gitea/act/pulls/75). So please upgrade your runner, and try to interpolate the token in `uses` by expression, like below: ```yaml uses: https://${{ secrets.GITHUB_TOKEN }}:@my-gitea-instance/myOrg/myAction ```
GiteaMirror commented 2025-11-02 09:32:10 -06:00
Author
Owner
Copy Link

@jonas-switala commented on GitHub (Mar 31, 2024):

Is there a known approach for using the solution provided by @sillyguodong to call shared workflows?

When attempting to embed the token in the URL I get the following error message:

calling workflow snippet:

jobs:
  validate-manifests:
    uses: https://${{ secrets.GITHUB_TOKEN }}:{instance}/{owner}/{repo}/.gitea/workflows/validate.yaml@v1.0.0

output:

expected format {owner}/{repo}/.{git_platform}/workflows/{filename}@{ref}. Actual 'https://${{ secrets.GITHUB_TOKEN }}:{instance}/{owner}/{repo}/.gitea/workflows/validate.yaml@v1.0.0' Input string was not in a correct format

@jonas-switala commented on GitHub (Mar 31, 2024): Is there a known approach for using the solution provided by @sillyguodong to call shared workflows? When attempting to embed the token in the URL I get the following error message: ### calling workflow snippet: ``` jobs: validate-manifests: uses: https://${{ secrets.GITHUB_TOKEN }}:{instance}/{owner}/{repo}/.gitea/workflows/validate.yaml@v1.0.0 ``` ### output: ` expected format {owner}/{repo}/.{git_platform}/workflows/{filename}@{ref}. Actual 'https://${{ secrets.GITHUB_TOKEN }}:{instance}/{owner}/{repo}/.gitea/workflows/validate.yaml@v1.0.0' Input string was not in a correct format `
GiteaMirror commented 2025-11-02 09:32:10 -06:00
Author
Owner
Copy Link

@brandonkal commented on GitHub (Jul 30, 2024):

@jonas-switala YAML parsers can often have issues when an unquoted string has a colon which is quite ironic considering your workflow name. I would recommend quoting the string. Also that is not a valid URL, you must use an @ to separate credentials from the host. See the definition

@brandonkal commented on GitHub (Jul 30, 2024): @jonas-switala YAML parsers can often have issues when an unquoted string has a colon which is quite ironic considering your workflow name. I would recommend quoting the string. Also that is not a valid URL, you must use an @ to separate credentials from the host. See [the definition](https://datatracker.ietf.org/doc/html/rfc1738#section-3.1)
GiteaMirror commented 2025-11-02 09:32:10 -06:00
Author
Owner
Copy Link

@jonas-switala commented on GitHub (Nov 11, 2024):

I finally found some time to test this again using gitea v1.22.3 and act-runner v0.2.10.
Unfortunately, it still doesn't work but at least the error is different this time (invalid userinfo). Am I still missing some parameters or is this an actual bug/error?

Workflow:

name: "Validate using shared workflow"

on:
  workflow_dispatch:
  push:
  pull_request:

jobs:
  validate:
    uses: "https://${{ secrets.TEST_TOKEN }}:@<instance>/<org>/<shared-workflow>/.gitea/workflows/validate.yaml@v1.0.0"

Runner-Output:

gitea-runner-03(version:v0.2.10) received task 7689 of job 7707, be triggered by event: push
workflow prepared
evaluating expression 'success()'
expression 'success()' evaluated to 'true'
  ☁  git clone 'https://${{ secrets.TEST_TOKEN }}:@<instance>/<org>/<shared-workflow>' # ref=v1.0.0
  cloning https://${{ secrets.TEST_TOKEN }}:@<instance>/<org>/<shared-workflow> to /root/.cache/act/<org>-<shared-workflow>@v1.0.0
Unable to clone https://${{ secrets.TEST_TOKEN }}:@<instance>/<org>/<shared-workflow> refs/heads/v1.0.0: parse "https://${{ secrets.TEST_TOKEN }}:@<instance>/<org>/<shared-workflow>": net/url: invalid userinfo
parse "https://${{ secrets.TEST_TOKEN }}:@<instance>/<org>/<shared-workflow>": net/url: invalid userinfo

Note: TEST_TOKEN is a read-only token with access to all private repos, so i can ensure this isn't an issue of insufficient permissions

@jonas-switala commented on GitHub (Nov 11, 2024): I finally found some time to test this again using gitea v1.22.3 and act-runner v0.2.10. Unfortunately, it still doesn't work but at least the error is different this time (**invalid userinfo**). Am I still missing some parameters or is this an actual bug/error? Workflow: ``` name: "Validate using shared workflow" on: workflow_dispatch: push: pull_request: jobs: validate: uses: "https://${{ secrets.TEST_TOKEN }}:@<instance>/<org>/<shared-workflow>/.gitea/workflows/validate.yaml@v1.0.0" ``` Runner-Output: ``` gitea-runner-03(version:v0.2.10) received task 7689 of job 7707, be triggered by event: push workflow prepared evaluating expression 'success()' expression 'success()' evaluated to 'true' ☁ git clone 'https://${{ secrets.TEST_TOKEN }}:@<instance>/<org>/<shared-workflow>' # ref=v1.0.0 cloning https://${{ secrets.TEST_TOKEN }}:@<instance>/<org>/<shared-workflow> to /root/.cache/act/<org>-<shared-workflow>@v1.0.0 Unable to clone https://${{ secrets.TEST_TOKEN }}:@<instance>/<org>/<shared-workflow> refs/heads/v1.0.0: parse "https://${{ secrets.TEST_TOKEN }}:@<instance>/<org>/<shared-workflow>": net/url: invalid userinfo parse "https://${{ secrets.TEST_TOKEN }}:@<instance>/<org>/<shared-workflow>": net/url: invalid userinfo ``` Note: TEST_TOKEN is a read-only token with access to all private repos, so i can ensure this isn't an issue of insufficient permissions
GiteaMirror commented 2025-11-02 09:32:11 -06:00
Author
Owner
Copy Link

@ChemiCalChems commented on GitHub (Feb 5, 2025):

I finally found some time to test this again using gitea v1.22.3 and act-runner v0.2.10. Unfortunately, it still doesn't work but at least the error is different this time (invalid userinfo). Am I still missing some parameters or is this an actual bug/error?

Workflow:

name: "Validate using shared workflow"

on:
  workflow_dispatch:
  push:
  pull_request:

jobs:
  validate:
    uses: "https://${{ secrets.TEST_TOKEN }}:@<instance>/<org>/<shared-workflow>/.gitea/workflows/validate.yaml@v1.0.0"

Runner-Output:

gitea-runner-03(version:v0.2.10) received task 7689 of job 7707, be triggered by event: push
workflow prepared
evaluating expression 'success()'
expression 'success()' evaluated to 'true'
  ☁  git clone 'https://${{ secrets.TEST_TOKEN }}:@<instance>/<org>/<shared-workflow>' # ref=v1.0.0
  cloning https://${{ secrets.TEST_TOKEN }}:@<instance>/<org>/<shared-workflow> to /root/.cache/act/<org>-<shared-workflow>@v1.0.0
Unable to clone https://${{ secrets.TEST_TOKEN }}:@<instance>/<org>/<shared-workflow> refs/heads/v1.0.0: parse "https://${{ secrets.TEST_TOKEN }}:@<instance>/<org>/<shared-workflow>": net/url: invalid userinfo
parse "https://${{ secrets.TEST_TOKEN }}:@<instance>/<org>/<shared-workflow>": net/url: invalid userinfo

Note: TEST_TOKEN is a read-only token with access to all private repos, so i can ensure this isn't an issue of insufficient permissions

@jonas-switala I experience the same.

@ChemiCalChems commented on GitHub (Feb 5, 2025): > I finally found some time to test this again using gitea v1.22.3 and act-runner v0.2.10. Unfortunately, it still doesn't work but at least the error is different this time (**invalid userinfo**). Am I still missing some parameters or is this an actual bug/error? > > Workflow: > > ``` > name: "Validate using shared workflow" > > on: > workflow_dispatch: > push: > pull_request: > > jobs: > validate: > uses: "https://${{ secrets.TEST_TOKEN }}:@<instance>/<org>/<shared-workflow>/.gitea/workflows/validate.yaml@v1.0.0" > ``` > > Runner-Output: > > ``` > gitea-runner-03(version:v0.2.10) received task 7689 of job 7707, be triggered by event: push > workflow prepared > evaluating expression 'success()' > expression 'success()' evaluated to 'true' > ☁ git clone 'https://${{ secrets.TEST_TOKEN }}:@<instance>/<org>/<shared-workflow>' # ref=v1.0.0 > cloning https://${{ secrets.TEST_TOKEN }}:@<instance>/<org>/<shared-workflow> to /root/.cache/act/<org>-<shared-workflow>@v1.0.0 > Unable to clone https://${{ secrets.TEST_TOKEN }}:@<instance>/<org>/<shared-workflow> refs/heads/v1.0.0: parse "https://${{ secrets.TEST_TOKEN }}:@<instance>/<org>/<shared-workflow>": net/url: invalid userinfo > parse "https://${{ secrets.TEST_TOKEN }}:@<instance>/<org>/<shared-workflow>": net/url: invalid userinfo > ``` > > Note: TEST_TOKEN is a read-only token with access to all private repos, so i can ensure this isn't an issue of insufficient permissions @jonas-switala I experience the same.
GiteaMirror commented 2025-11-02 09:32:11 -06:00
Author
Owner
Copy Link

@maxsargentdev commented on GitHub (Feb 6, 2025):

I have hit the same thing, and after some testing I can get it to work by hardcoding the token and providing a username. Using a username and token interpolation, or just the token interpolation itself doesn't work.

Thinking about it more, I feel like the log output would show the obfuscated **** characters if this was interpolating the secret correctly.

@maxsargentdev commented on GitHub (Feb 6, 2025): I have hit the same thing, and after some testing I can get it to work by hardcoding the token and providing a username. Using a username and token interpolation, or just the token interpolation itself doesn't work. Thinking about it more, I feel like the log output would show the obfuscated **** characters if this was interpolating the secret correctly.
GiteaMirror commented 2025-11-02 09:32:11 -06:00
Author
Owner
Copy Link

@maxsargentdev commented on GitHub (Feb 7, 2025):

Did some more research, the change above was only added in step_action_remote.go so it doesnt work when calling a resusable workflow, which uses resusable_workflow.go.

I have hacked a (probably awful code) change in to the act library:

diff --git a/pkg/runner/reusable_workflow.go b/pkg/runner/reusable_workflow.go
index f43ba24..2eb1c1f 100644
--- a/pkg/runner/reusable_workflow.go
+++ b/pkg/runner/reusable_workflow.go
@@ -52,7 +52,14 @@ func newLocalReusableWorkflowExecutor(rc *RunContext) common.Executor {
 }

 func newRemoteReusableWorkflowExecutor(rc *RunContext) common.Executor {
-       uses := rc.Run.Job().Uses
+
+       // Create a base context using context.TODO()
+       secretCtx := context.TODO()
+       // Add the map values to the context
+       for key, value := range rc.Config.Secrets {
+               secretCtx = context.WithValue(secretCtx, key, value)
+       }
+       uses := rc.NewExpressionEvaluator(secretCtx).Interpolate(secretCtx, rc.Run.Job().Uses)

        var remoteReusableWorkflow *remoteReusableWorkflow
        if strings.HasPrefix(uses, "http://") || strings.HasPrefix(uses, "https://") {
@@ -208,6 +215,7 @@ type remoteReusableWorkflow struct {
 }

 func (r *remoteReusableWorkflow) CloneURL() string {
+
        // In Gitea, r.URL always has the protocol prefix, we don't need to add extra prefix in this case.
        if strings.HasPrefix(r.URL, "http://") || strings.HasPrefix(r.URL, "https://") {
                return fmt.Sprintf("%s/%s/%s", r.URL, r.Org, r.Repo)

I rebuilt act_runner with that and it does seem to be working, so I will raise a PR over there.

Edit: PR here.

@maxsargentdev commented on GitHub (Feb 7, 2025): Did some more research, the change above was only added in `step_action_remote.go` so it doesnt work when calling a resusable workflow, which uses `resusable_workflow.go`. I have hacked a (probably awful code) change in to the act library: ~~~diff diff --git a/pkg/runner/reusable_workflow.go b/pkg/runner/reusable_workflow.go index f43ba24..2eb1c1f 100644 --- a/pkg/runner/reusable_workflow.go +++ b/pkg/runner/reusable_workflow.go @@ -52,7 +52,14 @@ func newLocalReusableWorkflowExecutor(rc *RunContext) common.Executor { } func newRemoteReusableWorkflowExecutor(rc *RunContext) common.Executor { - uses := rc.Run.Job().Uses + + // Create a base context using context.TODO() + secretCtx := context.TODO() + // Add the map values to the context + for key, value := range rc.Config.Secrets { + secretCtx = context.WithValue(secretCtx, key, value) + } + uses := rc.NewExpressionEvaluator(secretCtx).Interpolate(secretCtx, rc.Run.Job().Uses) var remoteReusableWorkflow *remoteReusableWorkflow if strings.HasPrefix(uses, "http://") || strings.HasPrefix(uses, "https://") { @@ -208,6 +215,7 @@ type remoteReusableWorkflow struct { } func (r *remoteReusableWorkflow) CloneURL() string { + // In Gitea, r.URL always has the protocol prefix, we don't need to add extra prefix in this case. if strings.HasPrefix(r.URL, "http://") || strings.HasPrefix(r.URL, "https://") { return fmt.Sprintf("%s/%s/%s", r.URL, r.Org, r.Repo) ~~~ I rebuilt act_runner with that and it does seem to be working, so I will raise a PR over there. Edit: [PR here](https://gitea.com/gitea/act/pulls/127).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/proposal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#11248
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?