github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-18 00:14:44 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Invalidate refresh tokens by default for OAuth public clients #11208

New Issue
Open
opened 2025-11-02 09:30:51 -06:00 by GiteaMirror · 1 comment
GiteaMirror commented 2025-11-02 09:30:51 -06:00
Owner
Copy Link

Originally created by @hickford on GitHub (Jul 12, 2023).

Feature Description

Configuration option oauth2.INVALIDATE_REFRESH_TOKENS defaults to false. For public clients, refresh token invalidation should be the default following OAuth security best practice https://datatracker.ietf.org/doc/html/draft-ietf-oauth-security-topics-22#name-refresh-tokens

Refresh tokens for public clients MUST be sender-constrained or use refresh token rotation

The configuration option would then apply only to confidential clients.

Screenshots

No response

Originally created by @hickford on GitHub (Jul 12, 2023). ### Feature Description Configuration option [oauth2.INVALIDATE_REFRESH_TOKENS](https://docs.gitea.com/next/administration/config-cheat-sheet#oauth2-oauth2) defaults to false. For public clients, refresh token invalidation should be the default following OAuth security best practice https://datatracker.ietf.org/doc/html/draft-ietf-oauth-security-topics-22#name-refresh-tokens > Refresh tokens for public clients MUST be sender-constrained or use refresh token rotation The configuration option would then apply only to confidential clients. ### Screenshots _No response_
GiteaMirror added the type/proposal label 2025-11-02 09:30:51 -06:00
GiteaMirror commented 2025-11-02 09:30:52 -06:00
Author
Owner
Copy Link

@hickford commented on GitHub (Jul 12, 2023):

Relevant code d1e066f5d6/routers/web/auth/oauth.go (L149-L156)

d1e066f5d6/routers/web/auth/oauth.go (L732-L739)

@hickford commented on GitHub (Jul 12, 2023): Relevant code https://github.com/go-gitea/gitea/blob/d1e066f5d6e1ba91f45118de835c3777eee0811f/routers/web/auth/oauth.go#L149-L156 https://github.com/go-gitea/gitea/blob/d1e066f5d6e1ba91f45118de835c3777eee0811f/routers/web/auth/oauth.go#L732-L739
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/proposal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#11208
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?