[Proposal] Improve notification read/pin related logic #11062

New Issue

GiteaMirror · 2025-11-02T09:26:27-06:00

GiteaMirror commented

2025-11-02 09:26:27 -06:00

Originally created by @HesterG on GitHub (Jun 20, 2023).

Feature Description

Right now, when clicking on pin inside read notification list, the notification will occur in both read and unread, with a read option in both read and unread list. And similar thing happens if pin is clicked in unread list. Maybe it is better to improve the logic by adding an unpin state.

Initial state: notification inside unread with pin and read options.

For example,
If the notification is pinned inside unread, only unpin option is available.
If the notification is then unpinned, back to initial state.
Similar logic for pin/unpin inside unread.
If a notification is pinned inside unread, click on read all will not move it to read (must unpin it first).

To implement this, we might need to add a NotificationStatusUnPinned to backend and adjust frontend logic.
And might need to separate status pin/unpin and read/unread into two variables to pass to frontend (instead of just status)

Screenshots

No response

Originally created by @HesterG on GitHub (Jun 20, 2023). ### Feature Description Right now, when clicking on pin inside read notification list, the notification will occur in both read and unread, with a read option in both read and unread list. And similar thing happens if pin is clicked in unread list. Maybe it is better to improve the logic by adding an unpin state. - Initial state: notification inside unread with pin and read options. For example, <img width="1345" alt="Screen Shot 2023-06-20 at 12 36 20" src="https://github.com/go-gitea/gitea/assets/17645053/64b10164-c2b8-4724-8b85-41ce3f30c56b"> - If the notification is pinned inside unread, only unpin option is available. <img width="1266" alt="Screen Shot 2023-06-20 at 13 28 54" src="https://github.com/go-gitea/gitea/assets/17645053/560bb3f4-930e-4ea6-b8b1-becee25fb8e5"> - If the notification is then unpinned, back to initial state. - Similar logic for pin/unpin inside unread. - If a notification is pinned inside unread, click on read all will not move it to read (must unpin it first). To implement this, we might need to add a `NotificationStatusUnPinned` to backend and adjust frontend logic. And might need to separate status pin/unpin and read/unread into two variables to pass to frontend (instead of just status) ### Screenshots _No response_

GiteaMirror added the type/enhancement topic/ui-interaction labels 2025-11-02 09:26:27 -06:00

GiteaMirror commented

2025-11-02 09:26:28 -06:00

@dfelinto commented on GitHub (Jul 28, 2023):

I was about to report a bug because I couldn't unpin my notifications. Then I found I could mark them as read to do it. Then I realized it was by design, not a bug.

All that just to say that I think this proposal (or something in that direction) would be a good improvement to the pinning logic.

@dfelinto commented on GitHub (Jul 28, 2023): I was about to report a bug because I couldn't unpin my notifications. Then I found I could mark them as read to do it. Then I realized it was by design, not a bug. All that just to say that I think this proposal (or something in that direction) would be a good improvement to the pinning logic.

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#11062