Rebase and Fast-forward for Pull-Request is not working properly #10999

Closed
opened 2025-11-02 09:24:26 -06:00 by GiteaMirror · 3 comments
Owner

Originally created by @jim-kirisame on GitHub (Jun 9, 2023).

Description

Hi, I'm notice the "Rebase and Fast forward" mode for Pull Requst is not work properly in 1.20.0-rc0. It will modify the last commit of the PR and rewrite the message of commit to "Merge pull request 'xxx' (#1) from BRANCH into main"

I have reproduce the bug in try.gitea.io. This is the link:

The HEAD of PR branch is 30a8edb4 but in main branch is 29420402, which is not correct in Rebase and Fast-forward mode.

Gitea Version

1.20.0-rc0, or 1.20.0+rc0-17-g81211db07

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

https://try.gitea.io/

Database

None

Originally created by @jim-kirisame on GitHub (Jun 9, 2023). ### Description Hi, I'm notice the "Rebase and Fast forward" mode for Pull Requst is not work properly in 1.20.0-rc0. It will modify the last commit of the PR and rewrite the message of commit to "Merge pull request 'xxx' ([#1](xxx)) from BRANCH into main" I have reproduce the bug in try.gitea.io. This is the link: - [branch after merge with rebase mode](https://try.gitea.io/jim1399/test-pr-repo/commits/branch/main) - [branch to be merge](https://try.gitea.io/jim1399/test-pr-repo/commits/branch/jim1399-patch-1) The HEAD of PR branch is [30a8edb4](https://try.gitea.io/jim1399/test-pr-repo/commit/30a8edb4539e9d9b0f3d6436f62d37656a1330d9) but in main branch is [29420402](https://try.gitea.io/jim1399/test-pr-repo/commit/29420402d2a0bd8b83161c26426b22ebde3f878e), which is not correct in Rebase and Fast-forward mode. ### Gitea Version 1.20.0-rc0, or 1.20.0+rc0-17-g81211db07 ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? https://try.gitea.io/ ### Database None
GiteaMirror added the issue/confirmedtype/bug labels 2025-11-02 09:24:26 -06:00
Author
Owner

@eremenko789 commented on GitHub (Jun 30, 2023):

Still relevant for 1.20.0-rc2

@eremenko789 commented on GitHub (Jun 30, 2023): Still relevant for 1.20.0-rc2
Author
Owner

@mmithril commented on GitHub (Jul 3, 2023):

Possible workaround: use Squash commit & edit the message manually.

Please fix as soon as possible anyway.

@mmithril commented on GitHub (Jul 3, 2023): Possible workaround: use _Squash commit_ & edit the message manually. Please fix as soon as possible anyway.
Author
Owner

@wxiaoguang commented on GitHub (Jul 9, 2023):

-> Avoid amending the Rebase and Fast-forward merge if there is no message template #25779

@wxiaoguang commented on GitHub (Jul 9, 2023): -> Avoid amending the Rebase and Fast-forward merge if there is no message template #25779
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#10999