Dissmiss a review on a pull request and input the reason but the reason missed on the conversation. #10988

Closed
opened 2025-11-02 09:24:12 -06:00 by GiteaMirror · 4 comments
Owner

Originally created by @lunny on GitHub (Jun 8, 2023).

图片
Originally created by @lunny on GitHub (Jun 8, 2023). <img width="1003" alt="图片" src="https://github.com/go-gitea/gitea/assets/81045/59b416a4-8220-41d0-896e-d148538fd02d">
GiteaMirror added the type/bug label 2025-11-02 09:24:12 -06:00
Author
Owner

@silverwind commented on GitHub (Jun 14, 2023):

May be related to https://github.com/go-gitea/gitea/pull/24738, I'm not sure.

@silverwind commented on GitHub (Jun 14, 2023): May be related to https://github.com/go-gitea/gitea/pull/24738, I'm not sure.
Author
Owner

@silverwind commented on GitHub (Jun 14, 2023):

At least the rendering has not changed, so it might be a problem when the dismissal request is sent.

https://github.com/go-gitea/gitea/blame/main/templates/repo/issue/view_content/comments.tmpl#L76

@silverwind commented on GitHub (Jun 14, 2023): At least the rendering has not changed, so it might be a problem when the dismissal request is sent. https://github.com/go-gitea/gitea/blame/main/templates/repo/issue/view_content/comments.tmpl#L76
Author
Owner

@silverwind commented on GitHub (Jun 14, 2023):

The input form is pretty much pure copy-paste, so I think it's unlikely that that PR regressed it and this may be a older bug.

@silverwind commented on GitHub (Jun 14, 2023): The input form is pretty much pure copy-paste, so I think it's unlikely that that PR regressed it and this may be a older bug.
Author
Owner

@wxiaoguang commented on GitHub (Jun 23, 2023):

It seems the bug exists from the beginning of the "dismiss" feature.

-> Make "dismiss" content shown correctly #25461

@wxiaoguang commented on GitHub (Jun 23, 2023): It seems the bug exists from the beginning of the "dismiss" feature. -> Make "dismiss" content shown correctly #25461
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#10988