github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Editorconfig not respected in PR Conversation view #10931

New Issue
Open
opened 2025-11-02 09:22:29 -06:00 by GiteaMirror · 1 comment
GiteaMirror commented 2025-11-02 09:22:29 -06:00
Owner
Copy Link

Originally created by @silverwind on GitHub (May 29, 2023).

Description

Tab size preference from .editorconfig is not working in the conversation tab:

https://try.gitea.io/silverwind/symlink-test/pulls/11

image

It is working in the Files tab:

https://try.gitea.io/silverwind/symlink-test/pulls/11/files

image

I traced it to templates/repo/issue/view_content/comments.tmpl line 521:

{{TabSizeClass $.Editorconfig $file.Name}}

$.Editorconfig is nil here, so TabSizeClass incorrectly returns the default tab size of 8. Maybe someone familiar around these parts sees the fix, for me it at least is not obvious.

Gitea Version

main

Can you reproduce the bug on the Gitea demo site?

Yes

Originally created by @silverwind on GitHub (May 29, 2023). ### Description Tab size preference from `.editorconfig` is not working in the conversation tab: https://try.gitea.io/silverwind/symlink-test/pulls/11 <img width="780" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/d6e29a8f-56c0-4154-b909-60a07aad2415"> It is working in the Files tab: https://try.gitea.io/silverwind/symlink-test/pulls/11/files <img width="304" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/d98b2249-2902-46ba-82ef-a8f9eee6b28a"> I traced it to `templates/repo/issue/view_content/comments.tmpl` line 521: ```handlebars {{TabSizeClass $.Editorconfig $file.Name}} ``` `$.Editorconfig` is nil here, so `TabSizeClass` incorrectly returns the default tab size of 8. Maybe someone familiar around these parts sees the fix, for me it at least is not obvious. ### Gitea Version main ### Can you reproduce the bug on the Gitea demo site? Yes
GiteaMirror added the topic/uitype/bug labels 2025-11-02 09:22:29 -06:00
GiteaMirror commented 2025-11-02 09:22:30 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Aug 8, 2023):

The Editorconfig is injected by a middleware SetEditorconfigIfExists. I guess the middleware is not correctly called.

@wxiaoguang commented on GitHub (Aug 8, 2023): The `Editorconfig` is injected by a middleware `SetEditorconfigIfExists`. I guess the middleware is not correctly called.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label topic/ui type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#10931
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?