Add option to show outdated review comments #10911

New Issue

GiteaMirror · 2025-11-02T09:21:56-06:00

GiteaMirror commented

2025-11-02 09:21:56 -06:00

Originally created by @sebastian-sauer on GitHub (May 24, 2023).

Feature Description

Review comments get invalidated when for example the commit sha of the line they were created on changes.
This may happen due to the code author adding some lines at the beginning of the file.

Now all invalidated / outdated code comments are not shown in "Files changed" tab.
In order to check those comments i'll have to switch between "Files changed" tab and the conversation tab.

A new option to show outdated comments in "Files changed" tab would allow me to at least view all comments for a file in "Files changed" tab.

Even better would be to try to find the new line number for a comment - but the option to show outdated comments would already improve reviewing code with gitea (at least in my opinion) a lot.

Screenshots

No response

Originally created by @sebastian-sauer on GitHub (May 24, 2023). ### Feature Description Review comments get invalidated when for example the commit sha of the line they were created on changes. This may happen due to the code author adding some lines at the beginning of the file. Now all invalidated / outdated code comments are not shown in "Files changed" tab. In order to check those comments i'll have to switch between "Files changed" tab and the conversation tab. A new option to show outdated comments in "Files changed" tab would allow me to at least view all comments for a file in "Files changed" tab. Even better would be to try to find the new line number for a comment - but the option to show outdated comments would already improve reviewing code with gitea (at least in my opinion) a lot. ### Screenshots _No response_

GiteaMirror added the type/proposal type/feature labels 2025-11-02 09:21:56 -06:00

GiteaMirror closed this issue

2025-11-02 09:21:57 -06:00

GiteaMirror commented

2025-11-02 09:21:57 -06:00

@lunny commented on GitHub (May 25, 2023):

But some comments needs the context and the context may be changed.
Finding the new line number of course is a better solution if the comment line hasn't been changed.

@lunny commented on GitHub (May 25, 2023): But some comments needs the context and the context may be changed. Finding the new line number of course is a better solution if the comment line hasn't been changed.

GiteaMirror commented

2025-11-02 09:21:57 -06:00

@sebastian-sauer commented on GitHub (May 25, 2023):

Upsource for example shows a warning on top of a comment like "Discussion is pointing to a modified code fragment" and a link to the original snippet. We could allow/add this (the old snippet is available).

@sebastian-sauer commented on GitHub (May 25, 2023): Upsource for example shows a warning on top of a comment like "Discussion is pointing to a modified code fragment" and a link to the original snippet. We could allow/add this (the old snippet is available).

GiteaMirror commented

2025-11-02 09:21:58 -06:00

@sebastian-sauer commented on GitHub (May 25, 2023):

I've proposed a PR with screenshots of a possible solution - https://github.com/go-gitea/gitea/pull/24936

Happy to make changes based on your feedback.

@sebastian-sauer commented on GitHub (May 25, 2023): I've proposed a PR with screenshots of a possible solution - https://github.com/go-gitea/gitea/pull/24936 Happy to make changes based on your feedback.

GiteaMirror commented

2025-11-02 09:21:58 -06:00

@lunny commented on GitHub (May 30, 2023):

At least, we need an option to disable it for those who don't want to see the outdated comment which will only make confusing.

@lunny commented on GitHub (May 30, 2023): At least, we need an option to disable it for those who don't want to see the outdated comment which will only make confusing.

GiteaMirror commented

2025-11-02 09:21:58 -06:00

@sebastian-sauer commented on GitHub (May 31, 2023):

At least, we need an option to disable it for those who don't want to see the outdated comment which will only make confusing.

The latest changes added an option to show outdated comments (will be stored in user settings if logged in) - so if you don't "enable" the feature by turning the option on, nothing should change and confuse.

@sebastian-sauer commented on GitHub (May 31, 2023): > At least, we need an option to disable it for those who don't want to see the outdated comment which will only make confusing. The latest changes added an option to show outdated comments (will be stored in user settings if logged in) - so if you don't "enable" the feature by turning the option on, nothing should change and confuse.

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#10911