github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-26 08:41:08 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

make watch (air) concurrent process problem #10889

New Issue
Closed
opened 2025-11-02 09:21:15 -06:00 by GiteaMirror · 11 comments
GiteaMirror commented 2025-11-02 09:21:15 -06:00
Owner
Copy Link

Originally created by @wxiaoguang on GitHub (May 22, 2023).

(I do not use air, this issue is just for helping debugging developers reported problem)

It seems that the make watch may not work well in some cases:

air logs:

main.go has changed    !!! The first change and build
building...
Running go generate...
...  go build ... -o gitea
main.go has changed    !!! The second change and build
building...
running...
Running go generate...
2023/05/22 11:45:44 cmd/web.go:123:runWeb() [I] Starting Gitea on PID: 90706
...
...  go build ... -o gitea
...
running...
2023/05/22 11:45:46 cmd/web.go:123:runWeb() [I] Starting Gitea on PID: 90768

If a file is changed when a build is in progress, air doesn't stop the old build, then two Gitea processes will be started.

Two running Gitea processes will conflict with each other: port listen, leveldb lock, etc.

Originally created by @wxiaoguang on GitHub (May 22, 2023). (I do not use `air`, this issue is just for helping debugging developers reported problem) It seems that the `make watch` may not work well in some cases: air logs: ``` main.go has changed !!! The first change and build building... Running go generate... ... go build ... -o gitea main.go has changed !!! The second change and build building... running... Running go generate... 2023/05/22 11:45:44 cmd/web.go:123:runWeb() [I] Starting Gitea on PID: 90706 ... ... go build ... -o gitea ... running... 2023/05/22 11:45:46 cmd/web.go:123:runWeb() [I] Starting Gitea on PID: 90768 ``` If a file is changed when a build is in progress, air doesn't stop the old build, then two Gitea processes will be started. Two running Gitea processes will conflict with each other: port listen, leveldb lock, etc.
GiteaMirror added the type/bugtopic/build labels 2025-11-02 09:21:15 -06:00
GiteaMirror commented 2025-11-02 09:21:15 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (May 22, 2023):

Have not seen above but have seen two other related issues:

  • When template compilation fails, I need to restart the air server because the current template reloading mechanism does not rebuild on save after one template build failure. Could be solved by making airwatch the template files, removing the backend mechanism, or fix the backend mechanism.
  • Sometimes, CTRL-C does not kill all child processes on watch.sh, and they remain running in the background. Can probably be fixed in the bash script somehow.
@silverwind commented on GitHub (May 22, 2023): Have not seen above but have seen two other related issues: - When template compilation fails, I need to restart the air server because the current template reloading mechanism does not rebuild on save after one template build failure. Could be solved by making airwatch the template files, removing the backend mechanism, or fix the backend mechanism. - Sometimes, CTRL-C does not kill all child processes on `watch.sh`, and they remain running in the background. Can probably be fixed in the bash script somehow.
GiteaMirror commented 2025-11-02 09:21:16 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (May 22, 2023):

When template compilation fails, I need to restart the air server because the current template reloading mechanism does not rebuild on save after one template build failure.

I do not see there is any problem. Although I do not use air, I made some quick tests:

  • Start Gitea by make watch
  • Visit some pages
  • Introduce some template errors
  • Gitea reports template compilation error
  • Visit the pages, they still use old templates
  • Fix the template errors
  • Visit the pages, they use thew new/corrected templates

Could be solved by making airwatch the template files, removing the backend mechanism, or fix the backend mechanism.

I do not think so. The backend code already supports hot-reloading the templates which is more convince and faster than completely restarting the Gitea process.

@wxiaoguang commented on GitHub (May 22, 2023): > When template compilation fails, I need to restart the air server because the current template reloading mechanism does not rebuild on save after one template build failure. I do not see there is any problem. Although I do not use `air`, I made some quick tests: * Start Gitea by `make watch` * Visit some pages * Introduce some template errors * Gitea reports template compilation error * Visit the pages, they still use old templates * Fix the template errors * Visit the pages, they use thew new/corrected templates > Could be solved by making airwatch the template files, removing the backend mechanism, or fix the backend mechanism. I do not think so. The backend code already supports hot-reloading the templates which is more convince and faster than completely restarting the Gitea process.
GiteaMirror commented 2025-11-02 09:21:16 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (May 22, 2023):

Sometimes, CTRL-C does not kill all child processes on watch.sh, and they remain running in the background. Can probably be fixed in the bash script somehow.

On this topic, I think we can try kill -9. I think in some cases, like when the go compiler runs, it may ignore a SIGTERM, but if we send SIGKILL, it can not ignore it. Thought there might be a small risk that it's interrupted in a bad moment.

@silverwind commented on GitHub (May 22, 2023): > Sometimes, CTRL-C does not kill all child processes on watch.sh, and they remain running in the background. Can probably be fixed in the bash script somehow. On this topic, I think we can try `kill -9`. I think in some cases, like when the go compiler runs, it may ignore a SIGTERM, but if we send SIGKILL, it can not ignore it. Thought there might be a small risk that it's interrupted in a bad moment.
GiteaMirror commented 2025-11-02 09:21:16 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (May 22, 2023):

When template compilation fails, I need to restart the air server because the current template reloading mechanism does not rebuild on save after one template build failure.

I do not see there is any problem. Although I do not use air, I made some quick tests:

* Start Gitea by `make watch`

* Visit some pages

* Introduce some template errors

* Gitea reports template compilation error

* Visit the pages, they still use old templates

* Fix the template errors

* Visit the pages, they use thew new/corrected templates

Could be solved by making airwatch the template files, removing the backend mechanism, or fix the backend mechanism.

I do not think so. The backend code already supports hot-reloading the templates which is more convince and faster than completely restarting the Gitea process.

It definitely happens to me a lot that I have to restart the go server because templates do not rebuild after an error was fixed. I'm not sure what exact sequence of actions triggers it yet. It is unrelated to air and should be reproducible just with the go server in dev mode.

@silverwind commented on GitHub (May 22, 2023): > > When template compilation fails, I need to restart the air server because the current template reloading mechanism does not rebuild on save after one template build failure. > > I do not see there is any problem. Although I do not use `air`, I made some quick tests: > > * Start Gitea by `make watch` > > * Visit some pages > > * Introduce some template errors > > * Gitea reports template compilation error > > * Visit the pages, they still use old templates > > * Fix the template errors > > * Visit the pages, they use thew new/corrected templates > > > > Could be solved by making airwatch the template files, removing the backend mechanism, or fix the backend mechanism. > > I do not think so. The backend code already supports hot-reloading the templates which is more convince and faster than completely restarting the Gitea process. It definitely happens to me a lot that I have to restart the go server because templates do not rebuild after an error was fixed. I'm not sure what exact sequence of actions triggers it yet. It is unrelated to air and should be reproducible just with the go server in dev mode.
GiteaMirror commented 2025-11-02 09:21:16 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (May 23, 2023):

It definitely happens to me a lot that I have to restart the go server because templates do not rebuild after an error was fixed.

I can imagine a case for your problem: if the go code and tmpl code are changed at the same time, tmpl has errors, then air will restart the Gitea process, but Gitea will report fatal errors when it encounters template error during it's startup. So, the Gitea process just exits due to your template errors. Then if you only fix the template errors, air doesn't see go file change, air won't start a new Gitea process.

It could be fixed by make Gitea keep running in dev mode even if there is template error during startup.

@wxiaoguang commented on GitHub (May 23, 2023): > It definitely happens to me a lot that I have to restart the go server because templates do not rebuild after an error was fixed. I can imagine a case for your problem: if the go code and tmpl code are changed at the same time, tmpl has errors, then air will restart the Gitea process, but Gitea will report fatal errors when it encounters template error during it's startup. So, the Gitea process just exits due to your template errors. Then if you only fix the template errors, air doesn't see go file change, air won't start a new Gitea process. It could be fixed by make Gitea keep running in dev mode even if there is template error during startup.
GiteaMirror commented 2025-11-02 09:21:16 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (May 23, 2023):

-> Improve RunMode / dev mode #24886

@wxiaoguang commented on GitHub (May 23, 2023): -> Improve RunMode / dev mode #24886
GiteaMirror commented 2025-11-02 09:21:17 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (May 23, 2023):

Yes, it sounds likely that I've hit that scenario, not 100% sure because most of the time, I actually don't edit go code, just templates and css/js.

@silverwind commented on GitHub (May 23, 2023): Yes, it sounds likely that I've hit that scenario, not 100% sure because most of the time, I actually don't edit go code, just templates and css/js.
GiteaMirror commented 2025-11-02 09:21:17 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (May 27, 2023):

Regarding original issue: I think it's an air bug. Maybe we can kill off any old processes when starting new ones. Air also has this option, not sure it would help.

@silverwind commented on GitHub (May 27, 2023): Regarding original issue: I think it's an air bug. Maybe we can kill off any old processes when starting new ones. Air also has [this option](https://github.com/cosmtrek/air/blob/76e45cc76c073349c96e322ed136c5af1f0c384d/air_example.toml#L42), not sure it would help.
GiteaMirror commented 2025-11-02 09:21:17 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (May 27, 2023):

I reproduced this double build and double run just now after switching branches while air was running:

code.gitea.io/gitea/routers/web
code.gitea.io/gitea/routers/web
code.gitea.io/gitea/routers
code.gitea.io/gitea/cmd
code.gitea.io/gitea/cmd
code.gitea.io/gitea
code.gitea.io/gitea
make[2]: Leaving directory '/Users/silverwind/git/gitea'
running...
make[2]: Leaving directory '/Users/silverwind/git/gitea'
running...
2023/05/27 19:11:57 cmd/web.go:123:runWeb() [I] Starting Gitea on PID: 79445
2023/05/27 19:11:57 cmd/web.go:174:runWeb() [I] Global init
2023/05/27 19:11:57 cmd/web.go:123:runWeb() [I] Starting Gitea on PID: 79446
2023/05/27 19:11:57 cmd/web.go:174:runWeb() [I] Global init
@silverwind commented on GitHub (May 27, 2023): I reproduced this double build and double run just now after switching branches while air was running: ``` code.gitea.io/gitea/routers/web code.gitea.io/gitea/routers/web code.gitea.io/gitea/routers code.gitea.io/gitea/cmd code.gitea.io/gitea/cmd code.gitea.io/gitea code.gitea.io/gitea make[2]: Leaving directory '/Users/silverwind/git/gitea' running... make[2]: Leaving directory '/Users/silverwind/git/gitea' running... 2023/05/27 19:11:57 cmd/web.go:123:runWeb() [I] Starting Gitea on PID: 79445 2023/05/27 19:11:57 cmd/web.go:174:runWeb() [I] Global init 2023/05/27 19:11:57 cmd/web.go:123:runWeb() [I] Starting Gitea on PID: 79446 2023/05/27 19:11:57 cmd/web.go:174:runWeb() [I] Global init ```
GiteaMirror commented 2025-11-02 09:21:17 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (May 27, 2023):

I think we shoud look for air alternatives. I think turbowatch is worth taking a look at.

@silverwind commented on GitHub (May 27, 2023): I think we shoud look for air alternatives. I think [turbowatch](https://github.com/gajus/turbowatch) is worth taking a look at.
GiteaMirror commented 2025-11-02 09:21:17 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Jul 22, 2023):

Not working on it because I am not the user and don't understand air, so close it. Feel free to propose new solutions.

@wxiaoguang commented on GitHub (Jul 22, 2023): Not working on it because I am not the user and don't understand air, so close it. Feel free to propose new solutions.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label topic/build type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#10889
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?