github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-11 17:46:29 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Action cannot be triggered after the mirror repository is synchronized #10883

New Issue
Closed
opened 2025-11-02 09:21:06 -06:00 by GiteaMirror · 2 comments
GiteaMirror commented 2025-11-02 09:21:06 -06:00
Owner
Copy Link

Originally created by @mayswind on GitHub (May 20, 2023).

Description

The action workflow cannot be triggered after the mirror repository is synchronized when the workflow has branch filter parameters (see the below code)

on:
  push:
    branches:
      - main

But when the workflow does not have any filter parameters (see the below code), the workflow can be triggered.

on:
  push

The reproduce steps:

  1. Setup a new mirror repository (the upstream repository should have a workflow file like the first code at the above)
  2. Enable actions for this repository
  3. Push a new commit to the upstream repository
  4. Sync the mirror repository
  5. The workflow would not be triggered

I check the log file (log level is set to trace), and find these logs

2023/05/20 21:26:05 ...actions/workflows.go:86:DetectWorkflows() [T] detect workflow "docker-release.yml" for event &jobparser.Event{Name:"push", acts:map[string][]string{"tags":[]string{"v*"}}, schedules:[]map[string]string(nil)} matching "push"
2023/05/20 21:26:05 ...actions/workflows.go:86:DetectWorkflows() [T] detect workflow "docker-snapshot.yml" for event &jobparser.Event{Name:"push", acts:map[string][]string{"branches":[]string{"main"}}, schedules:[]map[string]string(nil)} matching "push"
2023/05/20 21:26:05 ...s/notifier_helper.go:146:notify() [T] repo /data/git/repositories/****/****.git with commit 2d290990bfed049db1056432379fc54755bcb85e couldn't find workflows

So I check the code in modules/actions/workflows.go:200. The variable refName does not contain git.BranchPrefix (refs/heads/), so the workflow would not be triggered after the repository is synchronized if the workflow file has branch filter.

Then I check the results variable in services/mirror/mirror_pull.go:413, the field refName also does not contain git.BranchPrefix.

Gitea Version

Test in v1.19.3 and latest commit #1698c15cba8f9eedfcb6af8226f3e97950480aca

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

2.40.1

Operating System

Debian 11

How are you running Gitea?

I use the gitea/gitea:1.19.3 docker image to run gitea. To verify whether the latest version has fixed this issue, I download the latest code, and execute TAGS="bindata sqlite sqlite_unlock_notify" make build (the golang version is 1.20.4, the nodejs version is 18.16.0) to build the latest binary file and put it into gitea/gitea:1.19.3 image, then use the modified image to test.

Database

MySQL

Originally created by @mayswind on GitHub (May 20, 2023). ### Description The action workflow cannot be triggered after the mirror repository is synchronized when the workflow has branch filter parameters (see the below code) ``` on: push: branches: - main ``` But when the workflow does not have any filter parameters (see the below code), the workflow can be triggered. ``` on: push ``` The reproduce steps: 1. Setup a new mirror repository (the upstream repository should have a workflow file like the first code at the above) 2. Enable actions for this repository 3. Push a new commit to the upstream repository 4. Sync the mirror repository 5. The workflow would not be triggered I check the log file (log level is set to `trace`), and find these logs ``` 2023/05/20 21:26:05 ...actions/workflows.go:86:DetectWorkflows() [T] detect workflow "docker-release.yml" for event &jobparser.Event{Name:"push", acts:map[string][]string{"tags":[]string{"v*"}}, schedules:[]map[string]string(nil)} matching "push" 2023/05/20 21:26:05 ...actions/workflows.go:86:DetectWorkflows() [T] detect workflow "docker-snapshot.yml" for event &jobparser.Event{Name:"push", acts:map[string][]string{"branches":[]string{"main"}}, schedules:[]map[string]string(nil)} matching "push" 2023/05/20 21:26:05 ...s/notifier_helper.go:146:notify() [T] repo /data/git/repositories/****/****.git with commit 2d290990bfed049db1056432379fc54755bcb85e couldn't find workflows ``` So I check the code in [`modules/actions/workflows.go:200`](https://github.com/go-gitea/gitea/blob/1698c15cba8f9eedfcb6af8226f3e97950480aca/modules/actions/workflows.go#L200). The variable `refName` does not contain `git.BranchPrefix` (`refs/heads/`), so the workflow would not be triggered after the repository is synchronized if the workflow file has branch filter. Then I check the `results` variable in [`services/mirror/mirror_pull.go:413`](https://github.com/go-gitea/gitea/blob/1698c15cba8f9eedfcb6af8226f3e97950480aca/services/mirror/mirror_pull.go#L413), the field `refName` also does not contain `git.BranchPrefix`. ### Gitea Version Test in v1.19.3 and latest commit #1698c15cba8f9eedfcb6af8226f3e97950480aca ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version 2.40.1 ### Operating System Debian 11 ### How are you running Gitea? I use the `gitea/gitea:1.19.3` docker image to run gitea. To verify whether the latest version has fixed this issue, I download the latest code, and execute `TAGS="bindata sqlite sqlite_unlock_notify" make build` (the golang version is 1.20.4, the nodejs version is 18.16.0) to build the latest binary file and put it into `gitea/gitea:1.19.3` image, then use the modified image to test. ### Database MySQL
GiteaMirror added the topic/gitea-actionstype/bug labels 2025-11-02 09:21:06 -06:00
GiteaMirror commented 2025-11-02 09:21:07 -06:00
Author
Owner
Copy Link

@dboreham commented on GitHub (May 26, 2023):

Confirmed with manual testing that this is now fixed after merge of https://github.com/go-gitea/gitea/pull/24634 to main.

@dboreham commented on GitHub (May 26, 2023): Confirmed with manual testing that this is now fixed after merge of https://github.com/go-gitea/gitea/pull/24634 to main.
GiteaMirror commented 2025-11-02 09:21:07 -06:00
Author
Owner
Copy Link

@mayswind commented on GitHub (May 29, 2023):

test the latest version has fixed. close the issue.

@mayswind commented on GitHub (May 29, 2023): test the latest version has fixed. close the issue.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label topic/gitea-actions type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#10883
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?