PR comment webhook does not belongs to PR Reviewd but it is mentioned in the description #10831

New Issue

GiteaMirror · 2025-11-02T09:19:26-06:00

GiteaMirror commented

2025-11-02 09:19:26 -06:00

Originally created by @yp05327 on GitHub (May 12, 2023).

Description

Discussed in https://github.com/go-gitea/gitea/pull/24599#issuecomment-1543506635

Reproduce Process:

Create a webhook and set it only trigger on Pull Request Reviewed.
Create a review comment
You will find that this webhook will not be triggered.

So what is the correct design?

Gitea Version

latest

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

build

Database

None

Originally created by @yp05327 on GitHub (May 12, 2023). ### Description Discussed in https://github.com/go-gitea/gitea/pull/24599#issuecomment-1543506635 Reproduce Process: - Create a webhook and set it only trigger on Pull Request Reviewed. - Create a review comment - You will find that this webhook will not be triggered. So what is the correct design? ### Gitea Version latest ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? build ### Database None

GiteaMirror added the type/bug label 2025-11-02 09:19:26 -06:00

GiteaMirror commented

2025-11-02 09:19:27 -06:00

@lunny commented on GitHub (May 12, 2023):

Did you approve or reject this review?

@lunny commented on GitHub (May 12, 2023): Did you approve or reject this review?

GiteaMirror commented

2025-11-02 09:19:27 -06:00

@yp05327 commented on GitHub (May 12, 2023):

No approve or reject, just left an comment.

Tested in:
https://try.gitea.io/yp05327/testrepo/pulls/1

Both of them will not trigger the webhook.

@yp05327 commented on GitHub (May 12, 2023): No approve or reject, just left an comment. Tested in: https://try.gitea.io/yp05327/testrepo/pulls/1 ![image](https://github.com/go-gitea/gitea/assets/18380374/eee51389-fe89-4d7f-9093-a298e901f479) Both of them will not trigger the webhook. ![image](https://github.com/go-gitea/gitea/assets/18380374/8bcbe597-e6bb-4fa2-ada2-48afe7386692)

GiteaMirror commented

2025-11-02 09:19:27 -06:00

@lunny commented on GitHub (May 12, 2023):

I think that's because you haven't check Pull Request Comment on your webhook setting but have a review comment.

@lunny commented on GitHub (May 12, 2023): I think that's because you haven't check Pull Request Comment on your webhook setting but have a review comment.

GiteaMirror commented

2025-11-02 09:19:27 -06:00

@wxiaoguang commented on GitHub (May 12, 2023):

I guess it means "Pull Request Review Comment", but not "normal discussion comment"

@wxiaoguang commented on GitHub (May 12, 2023): I guess it means "Pull Request Review Comment", but not "normal discussion comment" ![image](https://github.com/go-gitea/gitea/assets/2114189/dddd93fc-3fcd-4654-8a6e-b3539db29457)

GiteaMirror commented

2025-11-02 09:19:27 -06:00

@yp05327 commented on GitHub (May 12, 2023):

There are two types of PR review comment in https://github.com/go-gitea/gitea/issues/24671#issuecomment-1545234651

comment to some lines
comment to the whole pr, mentioned in https://github.com/go-gitea/gitea/issues/24671#issuecomment-1545439649

Both of them will not be triggered.

@yp05327 commented on GitHub (May 12, 2023): There are two types of PR review comment in https://github.com/go-gitea/gitea/issues/24671#issuecomment-1545234651 - comment to some lines - comment to the whole pr, mentioned in https://github.com/go-gitea/gitea/issues/24671#issuecomment-1545439649 Both of them will not be triggered.

GiteaMirror commented

2025-11-02 09:19:28 -06:00

@yp05327 commented on GitHub (May 12, 2023):

I think that's because you haven't check Pull Request Comment on your webhook setting but have a review comment.

Of cause, if you checked it, the webhook would work.
The problem is that the description of pr reviewed option says review comment can trigger the webhook, but it won’t actually.

@yp05327 commented on GitHub (May 12, 2023): > I think that's because you haven't check Pull Request Comment on your webhook setting but have a review comment. Of cause, if you checked it, the webhook would work. The problem is that the description of pr reviewed option says review comment can trigger the webhook, but it won’t actually.

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#10831