"Comment and close" replaces first issue comment with last comment #1082

Closed
opened 2025-11-02 03:47:39 -06:00 by GiteaMirror · 4 comments
Owner

Originally created by @mxmehl on GitHub (Sep 19, 2017).

Description

This is a very severe bug because is modifies issues and potentially important information!

In an open issue, when clicking "comment and close", the text of the closing comment replaces the text of the first comment in this issue (fortunately not those in between).

Examples: https://try.gitea.io/mxmehl/test1/issues/1 or https://git.fsfe.org/pmpc/website/issues/89

Originally created by @mxmehl on GitHub (Sep 19, 2017). - Gitea version (or commit ref): d155d0e - Git version: 2.1.4 - Operating system: Debian 8 - Database (use `[x]`): - [ ] PostgreSQL - [x] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [x] Yes (provide example URL): https://try.gitea.io/mxmehl/test1/issues/1 - [ ] No - [ ] Not relevant - Log gist: ## Description This is a very severe bug because is modifies issues and potentially important information! In an open issue, when clicking "comment and close", the text of the closing comment replaces the text of the first comment in this issue (*fortunately* not those in between). Examples: https://try.gitea.io/mxmehl/test1/issues/1 or https://git.fsfe.org/pmpc/website/issues/89
GiteaMirror added the type/bug label 2025-11-02 03:47:39 -06:00
Author
Owner

@mxmehl commented on GitHub (Sep 19, 2017):

This has already been the case with commit b0f7457, the version we had running before, but not with 5f4210a

@mxmehl commented on GitHub (Sep 19, 2017): This has already been the case with commit b0f7457, the version we had running before, but not with 5f4210a
Author
Owner

@lafriks commented on GitHub (Sep 20, 2017):

Not present in 1.2.0-rc2 only on master branch

@lafriks commented on GitHub (Sep 20, 2017): Not present in 1.2.0-rc2 only on master branch
Author
Owner

@mxmehl commented on GitHub (Sep 20, 2017):

The bug also happens when reopening an issue with a comment.

Does anyone have an idea how this could have been caused in the latest commits?

@mxmehl commented on GitHub (Sep 20, 2017): The bug also happens when reopening an issue with a comment. Does anyone have an idea how this could have been caused in the latest commits?
Author
Owner

@mxmehl commented on GitHub (Sep 21, 2017):

Workaround: Comment on an issue, and close it in a second step. Then the first message isn't overwritten. But who does it this way if there's a shortcut?

@mxmehl commented on GitHub (Sep 21, 2017): Workaround: Comment on an issue, and close it in a second step. Then the first message isn't overwritten. But who does it this way if there's a shortcut?
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#1082