EasyMDE toolbar is broken #10767

New Issue

GiteaMirror · 2025-11-02T09:17:39-06:00

GiteaMirror commented

2025-11-02 09:17:39 -06:00

Originally created by @wxiaoguang on GitHub (May 2, 2023).

Originally assigned to: @silverwind on GitHub.

Related to https://github.com/go-gitea/gitea/pull/24471

I think we should keep EasyMDE, or at least find an alternative. Because when writing Wiki page, it is useful.

Originally created by @wxiaoguang on GitHub (May 2, 2023). Originally assigned to: @silverwind on GitHub. Related to https://github.com/go-gitea/gitea/pull/24471 I think we should keep EasyMDE, or at least find an alternative. Because when writing Wiki page, it is useful. ![image](https://user-images.githubusercontent.com/2114189/235689373-470dc502-548b-41c4-9321-5baf01c89b31.png)

GiteaMirror added the issue/regression type/bug labels 2025-11-02 09:17:39 -06:00

GiteaMirror closed this issue

2025-11-02 09:17:39 -06:00

GiteaMirror commented

2025-11-02 09:17:40 -06:00

@silverwind commented on GitHub (May 2, 2023):

I thought https://github.com/go-gitea/gitea/pull/24448 had replaced all these toolbar icons, but apparently only some. I guess we should restore with octicons.

@silverwind commented on GitHub (May 2, 2023): I thought https://github.com/go-gitea/gitea/pull/24448 had replaced all these toolbar icons, but apparently only some. I guess we should restore with octicons.

GiteaMirror commented

2025-11-02 09:17:40 -06:00

@yardenshoham commented on GitHub (May 2, 2023):

#24448 removed direct references, not indirect ones. This probably broke after https://github.com/go-gitea/gitea/pull/24471

@yardenshoham commented on GitHub (May 2, 2023): #24448 removed direct references, not indirect ones. This probably broke after https://github.com/go-gitea/gitea/pull/24471

GiteaMirror commented

2025-11-02 09:17:40 -06:00

@yardenshoham commented on GitHub (May 2, 2023):

Shouldn't easymde ship its own font-awesome? Do we override its internal classes?

@yardenshoham commented on GitHub (May 2, 2023): Shouldn't easymde ship its own font-awesome? Do we override its internal classes?

GiteaMirror commented

2025-11-02 09:17:40 -06:00

@wxiaoguang commented on GitHub (May 2, 2023):

We can manually construct every toolbar button, to use other icon sets.

@wxiaoguang commented on GitHub (May 2, 2023): We can manually construct every toolbar button, to use other icon sets.

GiteaMirror commented

2025-11-02 09:17:40 -06:00

@silverwind commented on GitHub (May 2, 2023):

Yes, my oversight there. If the restoration is too much work, we could drop EasyMDE as well.

Shouldn't easymde ship its own font-awesome? Do we override its internal classes?

No, it apparently has an option autoDownloadFontAwesome which downloads it from CDN, but of course we needed to disable that as we don't want such downloads to happen.

@silverwind commented on GitHub (May 2, 2023): Yes, my oversight there. If the restoration is too much work, we could drop EasyMDE as well. > Shouldn't easymde ship its own font-awesome? Do we override its internal classes? No, it apparently has an option [`autoDownloadFontAwesome`](https://github.com/Ionaru/easy-markdown-editor#options-list) which downloads it from CDN, but of course we needed to disable that as we don't want such downloads to happen.

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#10767