github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-09 04:25:18 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Push comments of pull request sometimes are missed. #10699

New Issue
Closed
opened 2025-11-02 09:15:53 -06:00 by GiteaMirror · 7 comments
GiteaMirror commented 2025-11-02 09:15:53 -06:00
Owner
Copy Link

Originally created by @lunny on GitHub (Apr 20, 2023).

Take a look at the PR https://gitea.com/gitea/blog/pulls/262 . There are 4 commits but no any commits comment on pull request conversation.

Originally created by @lunny on GitHub (Apr 20, 2023). Take a look at the PR https://gitea.com/gitea/blog/pulls/262 . There are 4 commits but no any commits comment on pull request conversation.
GiteaMirror added the type/bug label 2025-11-02 09:15:53 -06:00
GiteaMirror commented 2025-11-02 09:15:54 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Apr 20, 2023):

Have you checked the database? I guess the problem is that when a PR is open, the comments are displayed. But for merged PRs, the commits are not displayed?

@wxiaoguang commented on GitHub (Apr 20, 2023): Have you checked the database? I guess the problem is that when a PR is open, the comments are displayed. But for merged PRs, the commits are not displayed?
GiteaMirror commented 2025-11-02 09:15:54 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Apr 20, 2023):

A old PR https://gitea.com/gitea/blog/pulls/180 (2 years ago) doesn't show the commits either

@wxiaoguang commented on GitHub (Apr 20, 2023): A old PR https://gitea.com/gitea/blog/pulls/180 (2 years ago) doesn't show the commits either
GiteaMirror commented 2025-11-02 09:15:54 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Apr 20, 2023):

Ah, really. But it's not GH style. I just noticed that.

@lunny commented on GitHub (Apr 20, 2023): Ah, really. But it's not GH style. I just noticed that.
GiteaMirror commented 2025-11-02 09:15:54 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Apr 20, 2023):

The code was written as this ....

	CommentTypePullRequestPush // 29 push to PR head branch

image

@wxiaoguang commented on GitHub (Apr 20, 2023): The code was written as this .... ``` CommentTypePullRequestPush // 29 push to PR head branch ``` ![image](https://user-images.githubusercontent.com/2114189/233422600-6238b680-0895-4e9d-b6c7-8de7f3370634.png)
GiteaMirror commented 2025-11-02 09:15:54 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Apr 20, 2023):

I think there is a bug.

latestCloseCommentID is always 0

@wxiaoguang commented on GitHub (Apr 20, 2023): I think there is a bug. `latestCloseCommentID` is always 0
GiteaMirror commented 2025-11-02 09:15:54 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Apr 20, 2023):

Caused by #23189 @sillyguodong

@lunny commented on GitHub (Apr 20, 2023): Caused by #23189 @sillyguodong
GiteaMirror commented 2025-11-02 09:15:55 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Apr 20, 2023):

Oh, I have proposed a fix

Show commit history for closed/merged PRs #24238

@wxiaoguang commented on GitHub (Apr 20, 2023): Oh, I have proposed a fix Show commit history for closed/merged PRs #24238
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#10699
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?