Attachment Deleted Not Included In Edit Log #10684

New Issue

GiteaMirror · 2025-11-02T09:15:26-06:00

GiteaMirror commented

2025-11-02 09:15:26 -06:00

Originally created by @kdumontnu on GitHub (Apr 18, 2023).

Feature Description

This is somewhere between a bug and a feature, but currently attachment added, deleted is not included in the edit log in comments.

In fact, the history log just gets an entry with no diff.

Screenshots

Related to: https://github.com/go-gitea/gitea/issues/23290 and https://github.com/go-gitea/gitea/issues/24195

Originally created by @kdumontnu on GitHub (Apr 18, 2023). ### Feature Description This is somewhere between a bug and a feature, but currently attachment added, deleted is not included in the edit log in comments. In fact, the history log just gets an entry with no diff. ### Screenshots <img width="856" alt="image" src="https://user-images.githubusercontent.com/12700993/232878253-17d6fb40-5a53-495c-94ec-ff22890b8b80.png"> Related to: https://github.com/go-gitea/gitea/issues/23290 and https://github.com/go-gitea/gitea/issues/24195

GiteaMirror added the type/proposal type/feature labels 2025-11-02 09:15:26 -06:00

GiteaMirror commented

2025-11-02 09:15:27 -06:00

@wxiaoguang commented on GitHub (Apr 19, 2023):

The "Edit Log" (history), only includes "submitted contents"

If you do:

Open a comment editor
Upload attachments 1 2 3
Remove attachment 2
Submit

There won't be log for "adding 1 2 3 / removing 2"

But if you do:

Open a comment editor
Upload attachments 1 2 3
Submit
Remove attachment 2
Submit

Then you can see a diff log.

That's by design IMO

@wxiaoguang commented on GitHub (Apr 19, 2023): The "Edit Log" (history), only includes "submitted contents" ---- If you do: * Open a comment editor * Upload attachments 1 2 3 * Remove attachment 2 * Submit There won't be log for "adding 1 2 3 / removing 2" ---- But if you do: * Open a comment editor * Upload attachments 1 2 3 * Submit * Remove attachment 2 * Submit Then you can see a diff log. ---- That's by design IMO

GiteaMirror commented

2025-11-02 09:15:27 -06:00

@kdumontnu commented on GitHub (Apr 19, 2023):

That makes sense. From my initial testing I didn't think it logged attachment deletions at all (even your second scenario). I’ll check on try.gitea. If that’s the case, we can close this.

@kdumontnu commented on GitHub (Apr 19, 2023): That makes sense. From my initial testing I didn't think it logged attachment deletions at all (even your second scenario). I’ll check on try.gitea. If that’s the case, we can close this.

GiteaMirror commented

2025-11-02 09:15:27 -06:00

@wxiaoguang commented on GitHub (Apr 19, 2023):

Actually, there is no "attachment deletion" log. The only "log" is the content diff.

If you delete the attachment link from content and save, then there will be a diff log, the attachment itself could be still there if you don't remove it from the "dropzone" component.

If you delete the attachment from the "dropzone" component, but do not delete it from content, then there is no content history diff.

@wxiaoguang commented on GitHub (Apr 19, 2023): Actually, there is no "attachment deletion" log. The only "log" is the content diff. If you delete the attachment link from content and save, then there will be a diff log, the attachment itself could be still there if you don't remove it from the "dropzone" component. If you delete the attachment from the "dropzone" component, but do not delete it from content, then there is no content history diff.

GiteaMirror commented

2025-11-02 09:15:27 -06:00

@kdumontnu commented on GitHub (Apr 19, 2023):

Okay, that aligns with what I’ve seen. We’ve had users trying to figure out why their links are breaking, and as long as deleting an attachment is still an option in the UI, I think it is expected to go in the log as well.

(that being said, if we remove the option to delete attachments in the UI, as has been suggested elsewhere, this is no longer an issue)

@kdumontnu commented on GitHub (Apr 19, 2023): Okay, that aligns with what I’ve seen. We’ve had users trying to figure out why their links are breaking, and as long as deleting an attachment is still an option in the UI, I think it is expected to go in the log as well. (that being said, if we remove the option to delete attachments in the UI, as has been suggested elsewhere, this is no longer an issue)

GiteaMirror commented

2025-11-02 09:15:28 -06:00

@wxiaoguang commented on GitHub (Apr 19, 2023):

If we can implement this, then it could be much better than before:

If a user clicks the "remove" in dropzone, then also delete the link from content.

@wxiaoguang commented on GitHub (Apr 19, 2023): If we can implement this, then it could be much better than before: * If a user clicks the "remove" in dropzone, then also delete the link from content.

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#10684