github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Gitea doesn't send branch name to Drone via Webhook after merging Pull Request #1066

New Issue
Closed
opened 2025-11-02 03:47:04 -06:00 by GiteaMirror · 5 comments
GiteaMirror commented 2025-11-02 03:47:04 -06:00
Owner
Copy Link

Originally created by @mxmehl on GitHub (Sep 14, 2017).

  • Gitea version (or commit ref): 5f4210a
  • Git version: 2.1.4
  • Operating system: Debian 8
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant

Description

I have Drone connected to Gitea for CIs. It works all fine except when I merge Pull Requests: Drone does build PRs but doesn't deploy them.

Example: This is a PR I worked with. With this commit I merged the PR with master. And this is the drone build which is just testing the PR before it has been accepted – it actually never deployed. The Drone file should be correct: .drone.yml

A comment on my SO question suggests that the Webhook Gitea sends lacks a branch name – it should be master to trigger the drone build. This is also visible in the API output.

Can it be that Gitea has a bug here?

Screenshot

My Gitea webhook setiing: https://i.imgur.com/sh8bwEv.jpg

Originally created by @mxmehl on GitHub (Sep 14, 2017). - Gitea version (or commit ref): 5f4210a - Git version: 2.1.4 - Operating system: Debian 8 - Database (use `[x]`): - [ ] PostgreSQL - [x] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [x] Not relevant ## Description I have Drone connected to Gitea for CIs. It works all fine except when I merge Pull Requests: Drone does build PRs but doesn't deploy them. Example: [This](https://git.fsfe.org/pmpc/website/pulls/107) is a PR I worked with. With [this](https://git.fsfe.org/pmpc/website/commit/e0ae45ae1c341723f5764ecc25479a1b63913e00) commit I merged the PR with master. And [this](https://drone.fsfe.org/pmpc/website/1274) is the drone build which is just testing the PR before it has been accepted – it actually never deployed. The Drone file should be correct: [.drone.yml](https://git.fsfe.org/pmpc/website/src/master/.drone.yml) A comment on [my SO question](https://stackoverflow.com/questions/46165230/build-doesnt-trigger-on-merged-pull-request) suggests that the Webhook Gitea sends lacks a branch name – it should be master to trigger the drone build. This is also visible in the [API output](https://drone.fsfe.org/api/repos/pmpc/website/builds/1274). Can it be that Gitea has a bug here? ## Screenshot My Gitea webhook setiing: https://i.imgur.com/sh8bwEv.jpg
GiteaMirror added the type/bug label 2025-11-02 03:47:04 -06:00
GiteaMirror commented 2025-11-02 03:47:05 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Dec 12, 2017):

What's your Drone version and is this still a problem?

@lunny commented on GitHub (Dec 12, 2017): What's your Drone version and is this still a problem?
GiteaMirror commented 2025-11-02 03:47:06 -06:00
Author
Owner
Copy Link

@mxmehl commented on GitHub (Dec 12, 2017):

Yes, it's still an issue.

Drone version is 0.8.2. I just tested it with this PR. The following Drone build made syntax check etc (before the merge) but didn't deploy the updated master after the merge.

.drone.yml hasn't been changed and should catch updates to master.

@mxmehl commented on GitHub (Dec 12, 2017): Yes, it's still an issue. Drone version is 0.8.2. I just tested it with [this PR](https://git.fsfe.org/pmpc/website/pulls/207). The following [Drone build](https://drone.fsfe.org/pmpc/website/3681) made syntax check etc (before the merge) but didn't deploy the updated master after the merge. [.drone.yml](https://git.fsfe.org/pmpc/website/src/branch/master/.drone.yml) hasn't been changed and should catch updates to master.
GiteaMirror commented 2025-11-02 03:47:06 -06:00
Author
Owner
Copy Link

@mjwwit commented on GitHub (Jan 29, 2018):

I think I may have fixed this in drone/drone#2320

@mjwwit commented on GitHub (Jan 29, 2018): I think I may have fixed this in drone/drone#2320
GiteaMirror commented 2025-11-02 03:47:06 -06:00
Author
Owner
Copy Link

@mxmehl commented on GitHub (Mar 2, 2018):

Short update: The PR in drone has been merged but I cannot test it yet because Drone hasn't had a release yet and we only use stable versions in our organisation

@mxmehl commented on GitHub (Mar 2, 2018): Short update: The PR in drone has been merged but I cannot test it yet because Drone hasn't had a release yet and we only use stable versions in our organisation
GiteaMirror commented 2025-11-02 03:47:06 -06:00
Author
Owner
Copy Link

@lafriks commented on GitHub (Mar 2, 2018):

Closing this issue as fixed in drone. If issue persists even after drone upgrade to latest (with that fix) version please reopen

@lafriks commented on GitHub (Mar 2, 2018): Closing this issue as fixed in drone. If issue persists even after drone upgrade to latest (with that fix) version please reopen
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#1066
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?