error deprecat argment check #10633

Closed
opened 2025-11-02 09:13:36 -06:00 by GiteaMirror · 2 comments
Owner

Originally created by @blue-bird1 on GitHub (Apr 11, 2023).

Description

in code.
because convert.ToCorrectPageSize, listOptions.PageSize never is 0

Gitea Version

aa4d1d94f7

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

make && /gitea web

Database

None

Originally created by @blue-bird1 on GitHub (Apr 11, 2023). ### Description in [code](https://github.com/go-gitea/gitea/blob/25faee3c5f5be23c99b3b7e50418fc0dbad7a41b/routers/api/v1/repo/release.go#L154). because convert.ToCorrectPageSize, listOptions.PageSize never is 0 ### Gitea Version aa4d1d94f79e8edd9fa9ff2813fea12b085b2cae ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? make && /gitea web ### Database None
GiteaMirror added the type/miscellaneous label 2025-11-02 09:13:36 -06:00
Author
Owner

@blue-bird1 commented on GitHub (Apr 11, 2023):

It's a lucky bug. It found in my codeql query。
It lost the size check, but never entered this branch

@blue-bird1 commented on GitHub (Apr 11, 2023): It's a lucky bug. It found in my codeql query。 It lost the size check, but never entered this branch
Author
Owner

@lunny commented on GitHub (Jul 27, 2023):

It's not a bug, it's a useless code.

@lunny commented on GitHub (Jul 27, 2023): It's not a bug, it's a useless code.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#10633