github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-22 06:24:14 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Confusing icon for skipped actions #10622

New Issue
Closed
opened 2025-11-02 09:12:58 -06:00 by GiteaMirror · 11 comments
GiteaMirror commented 2025-11-02 09:12:58 -06:00
Owner
Copy Link

Originally created by @bilogic on GitHub (Apr 9, 2023).

Description

If an action was skipped, it gets a green tick on the Closed page
image
But on the code page, it gets a cross
image

Maybe a red bent arrow like a missed phone call will be better, see below?
image
image

Gitea Version

1.19.0

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Using docker

Database

MySQL

Originally created by @bilogic on GitHub (Apr 9, 2023). ### Description If an action was skipped, it gets a green tick on the `Closed` page ![image](https://user-images.githubusercontent.com/946010/230773183-f42b5e37-6d86-4b2e-ab26-eb32ee12480a.png) But on the code page, it gets a cross ![image](https://user-images.githubusercontent.com/946010/230773222-5dd44330-2085-4649-8670-65406fee6505.png) Maybe a red bent arrow like a missed phone call will be better, see below? ![image](https://user-images.githubusercontent.com/946010/230773358-fb62629a-ab53-49af-ac21-c80503bb00cc.png) ![image](https://user-images.githubusercontent.com/946010/230773392-6b973d7e-cf23-4cb0-9633-5c564b060eb1.png) ### Gitea Version 1.19.0 ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? Using docker ### Database MySQL
GiteaMirror added the topic/gitea-actionstype/bug labels 2025-11-02 09:12:58 -06:00
GiteaMirror commented 2025-11-02 09:12:59 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (Apr 9, 2023):

Does octicons have something suitable?

@silverwind commented on GitHub (Apr 9, 2023): Does [octicons](https://primer.github.io/octicons/) have something suitable?
GiteaMirror commented 2025-11-02 09:12:59 -06:00
Author
Owner
Copy Link

@bilogic commented on GitHub (Apr 9, 2023):

@silverwind

They use this to represent skip https://primer.github.io/octicons/skip-24

But I think the ones I googled convey meaning better.. I'm in a dilemma myself over the bent arrow or over the empty box

Anyway, the issue is the inconsistent icon, if it is easier to just use https://primer.github.io/octicons/skip-24, then it would also solve the problem.

@bilogic commented on GitHub (Apr 9, 2023): @silverwind They use this to represent skip https://primer.github.io/octicons/skip-24 But I think the ones I googled convey meaning better.. I'm in a dilemma myself over the bent arrow or over the empty box Anyway, the issue is the inconsistent icon, if it is easier to just use https://primer.github.io/octicons/skip-24, then it would also solve the problem.
GiteaMirror commented 2025-11-02 09:12:59 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (Apr 9, 2023):

We use only 16px, so it'd be https://primer.github.io/octicons/skip-16

@silverwind commented on GitHub (Apr 9, 2023): We use only 16px, so it'd be https://primer.github.io/octicons/skip-16
GiteaMirror commented 2025-11-02 09:12:59 -06:00
Author
Owner
Copy Link

@wolfogre commented on GitHub (Apr 10, 2023):

Related to Duplicated with #23599.

The point is that there is no skipped for commit status, and it has been treated as success in #23786

@wolfogre commented on GitHub (Apr 10, 2023): ~Related to~ Duplicated with #23599. The point is that there is no `skipped` for commit status, and it has been treated as `success` in #23786
GiteaMirror commented 2025-11-02 09:12:59 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (Apr 10, 2023):

Shouldn't we not use octicon-skip?

@silverwind commented on GitHub (Apr 10, 2023): Shouldn't we not use `octicon-skip`?
GiteaMirror commented 2025-11-02 09:13:00 -06:00
Author
Owner
Copy Link

@bilogic commented on GitHub (Apr 10, 2023):

@wolfogre

Thanks, I understand gitea's approach of following github entirely, but also gave this some thought:

It's pretty confusing to:

  1. Show the commit status icon + commit message on the actions page

  2. But show action status icon + commit message on the code page

  3. Since the intention on code page is to show the last commit, it should stay the same regardless whether actions are enabled or not

  4. Instead of prefixing the action status icon to the commit message, I feel it is better to append that icon to the commit message followed by the job name, which is consistent on the actions page
    image

  5. Based on my OP, that would be

    c001449e78 updated action X linux_tests

    where X is the icon, and linux_tests is the job name, which is what is shown when hovering over the code page's action status icon today

I can elaborate with more images if the above is not clear.

@bilogic commented on GitHub (Apr 10, 2023): @wolfogre Thanks, I understand gitea's approach of following github entirely, but also gave this some thought: It's pretty confusing to: 1. Show the `commit status icon` + commit message on the actions page 2. But show `action status icon` + commit message on the code page 3. Since the intention on code page is to show the last commit, it should stay the same regardless whether actions are enabled or not 4. Instead of prefixing the `action status icon` to the commit message, I feel it is better to append that icon to the commit message followed by the job name, which is consistent on the `actions page` ![image](https://user-images.githubusercontent.com/946010/230847813-287aea2e-5979-4b85-bf87-d50bde07de73.png) 5. Based on my OP, that would be > c001449e78 updated action X linux_tests where `X` is the icon, and `linux_tests` is the job name, which is what is shown when hovering over the code page's `action status icon` today I can elaborate with more images if the above is not clear.
GiteaMirror commented 2025-11-02 09:13:00 -06:00
Author
Owner
Copy Link

@wolfogre commented on GitHub (Apr 10, 2023):

Shouldn't we not use octicon-skip?

I have no objection to using a better icon to replace
image

But I don't think it is the point.

@wolfogre commented on GitHub (Apr 10, 2023): > Shouldn't we not use `octicon-skip`? I have no objection to using a better icon to replace <img width="999" alt="image" src="https://user-images.githubusercontent.com/9418365/230882886-857a2606-9e1f-4bf5-8e2c-e60f8d2b62f1.png"> But I don't think it is the point.
GiteaMirror commented 2025-11-02 09:13:00 -06:00
Author
Owner
Copy Link

@wolfogre commented on GitHub (Apr 10, 2023):

@bilogic Sorry I'm confused.

  1. Show the commit status icon + commit message on the actions page

I think it's action status icon + commit message on the actions page now

  1. But show action status icon + commit message on the code page

I think it's commit status icon + commit message on the code page now

  1. Since the intention on code page is to show the last commit, it should stay the same regardless whether actions are enabled or not

Sorry, what do you mean by "should stay the same"? The commit status could be used even without Actions.

  1. Instead of prefixing the action status icon to the commit message, I feel it is better to append that icon to the commit message followed by the job name, which is consistent on the actions page
    image

"prefixing the action status icon to the commit message", could you show me where?

Update:

To be clear.

When those are commit status with commit status icons.

image

And those are actions status with actions status icons.

image
@wolfogre commented on GitHub (Apr 10, 2023): @bilogic Sorry I'm confused. > 1. Show the `commit status icon` + commit message on the actions page I think it's `action status icon` + commit message on the actions page now > 2. But show `action status icon` + commit message on the code page I think it's `commit status icon` + commit message on the code page now > 3. Since the intention on code page is to show the last commit, it should stay the same regardless whether actions are enabled or not Sorry, what do you mean by "should stay the same"? The commit status could be used even without Actions. > 4. Instead of prefixing the `action status icon` to the commit message, I feel it is better to append that icon to the commit message followed by the job name, which is consistent on the `actions page` > ![image](https://user-images.githubusercontent.com/946010/230847813-287aea2e-5979-4b85-bf87-d50bde07de73.png) "prefixing the `action status icon` to the commit message", could you show me where? --- Update: To be clear. When those are commit status with commit status icons. <img width="1294" alt="image" src="https://user-images.githubusercontent.com/9418365/230887253-e06e7f7e-6e37-4972-9c58-cde88c6cc37d.png"> And those are actions status with actions status icons. <img width="855" alt="image" src="https://user-images.githubusercontent.com/9418365/230887343-1a3fb33d-c867-480c-b3f7-05d035ea1d83.png">
GiteaMirror commented 2025-11-02 09:13:01 -06:00
Author
Owner
Copy Link

@bilogic commented on GitHub (Apr 11, 2023):

@wolfogre yes thanks, let me show you what i'm seeing here

This is code page when actions are disabled: hash + commit message (No icons)

image

When actions are enabled and have ran, code page inserts an icon (red): hash + iconRed + commit message

image

On actions page, we see a different icon (blue): iconBlue + commit message

image

Clicking into the commit message, we see a 3rd different icon (green): iconGreen + job_name

image
image

so what I'm trying to ask here is:

  1. Can we make all 3 icons the same, based on the Completed job?

  2. To put it in context of my OP (skipped job), it currently shows iconGreen + job_name. Why not also make iconBlue and iconRed show the same icon consistently?

  3. I also wondered, how many statuses does a git commit have? There are no icon/status when actions are disabled. And for me, it is either a committed or could not commit, and if it could not be committed, there are actually no records of it in git. So why do we have commit icon/status now? Could it actually be something else? Thus, my suggestion to place this icon elsewhere instead of prepending to the commit message

  4. Now, I must say, I'm very new to actions, I tried hard to see if I missed any scenarios, but could not come up with much.

Open to hearing if the current icons represents something I might have missed. Thank you!

@bilogic commented on GitHub (Apr 11, 2023): @wolfogre yes thanks, let me show you what i'm seeing here ## This is `code` page when actions are disabled: `hash` + `commit message` (No icons) ![image](https://user-images.githubusercontent.com/946010/231039394-50612d03-bc74-46fe-9d3d-1358e6174bb4.png) ## When `actions` are enabled and have ran, `code` page inserts an icon (red): `hash` + `iconRed` + `commit message` ![image](https://user-images.githubusercontent.com/946010/231039401-2e60fabd-aa47-4fb0-b0b4-74df13bca2d4.png) ## On `actions` page, we see a different icon (blue): `iconBlue` + `commit message` ![image](https://user-images.githubusercontent.com/946010/231039412-8b3231d5-5a86-40e4-8689-ff289b9fafcf.png) ## Clicking into the commit message, we see a 3rd different icon (green): `iconGreen` + `job_name` ![image](https://user-images.githubusercontent.com/946010/231039420-2e8fe4c0-58f6-4680-92a8-b70a7a31fd2f.png) ![image](https://user-images.githubusercontent.com/946010/231056985-7b2a9f47-bef9-480a-827b-d80bde80b820.png) so what I'm trying to ask here is: 1. Can we make all 3 icons the same, based on the `Completed job`? 2. To put it in context of my OP (skipped job), it currently shows `iconGreen` + `job_name`. Why not also make `iconBlue` and `iconRed` show the same icon consistently? 3. I also wondered, how many statuses does a `git commit` have? There are no icon/status when `actions` are disabled. And for me, it is either a committed or could not commit, and if it could not be committed, there are actually no records of it in `git`. So why do we have `commit icon/status` now? Could it actually be something else? Thus, my suggestion to place this icon elsewhere instead of prepending to the `commit message` 4. Now, I must say, I'm very new to actions, I tried hard to see if I missed any scenarios, but could not come up with much. Open to hearing if the current icons represents something I might have missed. Thank you!
GiteaMirror commented 2025-11-02 09:13:01 -06:00
Author
Owner
Copy Link

@wolfogre commented on GitHub (Apr 11, 2023):

Thank you for your explanation, I think I understand now.

  1. Can we make all 3 icons the same, based on the Completed job?
  • image It is commit status, it not for Actions only, any external CI system can create commit status via Gitea API. So we shouldn't touch its design for Actions.
  • image It should be actions status, but the icon is wrong, it should be the same as the third.
  • image It's commit status.

So I will make the second and third icons the same. But the first icons are for commit status which is a different thing.

  1. To put it in context of my OP (skipped job), it currently shows iconGreen + job_name. Why not also make iconBlue and iconRed show the same icon consistently?

As mentioned, iconBlue should show the same icon with iconGreen, but iconRed is for a different thing.

  1. I also wondered, how many statuses does a git commit have?

Commit status:

  • pending
  • success
  • error
  • failure
  • warning
  • running

Actions status:

  • unknown
  • waiting
  • running
  • success
  • failure
  • cancelled
  • skipped
  • blocked

And how Gitea map them:

actions status commit status
success, skipped → success
failure, cancelled → failure
waiting, blocked → pending
running → running

So I would say they are different things.

There are no icon/status when actions are disabled.

The commit statuses are for binding CICD results to commits, and Gitea Actions is just one of the CICD tools; other tools, like DroneCI, could also send commit statuses. In other words, if you don't enable any CICD tools, there won't be any commit statuses.

And for me, it is either a committed or could not commit, and if it could not be committed, there are actually no records of it in git. So why do we have commit icon/status now? Could it actually be something else?

You may have misunderstood, the commit status is not for whether the branch can be committed. It is mainly for "Branch Protection", like:

image

Thus, my suggestion to place this icon elsewhere instead of prepending to the commit message

I don't understand, I mean, GitHub does it this way too.

image
@wolfogre commented on GitHub (Apr 11, 2023): Thank you for your explanation, I think I understand now. > 1. Can we make all 3 icons the same, based on the `Completed job`? - <img width="46" alt="image" src="https://user-images.githubusercontent.com/9418365/231085021-b4cc1f5f-7f1a-4f57-804e-25a92abf827a.png"> It is commit status, it not for Actions only, any external CI system can create commit status via Gitea API. So we shouldn't touch its design for Actions. - <img width="41" alt="image" src="https://user-images.githubusercontent.com/9418365/231085083-8c4aca21-a406-4937-9473-02b0c5d175fb.png"> It should be actions status, but the icon is wrong, it should be the same as the third. - <img width="42" alt="image" src="https://user-images.githubusercontent.com/9418365/231086840-4250f8db-bd86-48bb-9f78-f5a482c8ef6b.png"> It's commit status. So I will make the second and third icons the same. But the first icons are for commit status which is a different thing. > 2. To put it in context of my OP (skipped job), it currently shows `iconGreen` + `job_name`. Why not also make `iconBlue` and `iconRed` show the same icon consistently? As mentioned, `iconBlue` should show the same icon with `iconGreen`, but `iconRed` is for a different thing. > 3. I also wondered, how many statuses does a `git commit` have? Commit status: - `pending` - `success` - `error` - `failure` - `warning` - `running` Actions status: - `unknown` - `waiting` - `running` - `success` - `failure` - `cancelled` - `skipped` - `blocked` And how Gitea map them: | actions status | | commit status | | - | - | - | | `success`, `skipped` | → | `success` | | `failure`, `cancelled` | → | `failure` | | `waiting`, `blocked` | → | `pending` | | `running` | → | `running` | So I would say they are different things. > There are no icon/status when `actions` are disabled. The commit statuses are for binding CICD results to commits, and Gitea Actions is just one of the CICD tools; other tools, like DroneCI, could also send commit statuses. In other words, if you don't enable any CICD tools, there won't be any commit statuses. > And for me, it is either a committed or could not commit, and if it could not be committed, there are actually no records of it in `git`. So why do we have `commit icon/status` now? Could it actually be something else? You may have misunderstood, the commit status is not for whether the branch can be committed. It is mainly for "Branch Protection", like: <img width="1099" alt="image" src="https://user-images.githubusercontent.com/9418365/231128141-6316120a-f4c8-40da-a697-101fb1d3ff3a.png"> > Thus, my suggestion to place this icon elsewhere instead of prepending to the `commit message` I don't understand, I mean, GitHub does it this way too. <img width="637" alt="image" src="https://user-images.githubusercontent.com/9418365/231128567-26451eef-8429-4035-ae18-8e6971412ca5.png">
GiteaMirror commented 2025-11-02 09:13:01 -06:00
Author
Owner
Copy Link

@bilogic commented on GitHub (Apr 11, 2023):

any external CI system can create commit status via Gitea API

@wolfogre ok thanks, I have little to no understanding of the above. But since it is a thing, I'm sure you guys know better than me.

@bilogic commented on GitHub (Apr 11, 2023): > any external CI system can create commit status via Gitea API @wolfogre ok thanks, I have little to no understanding of the above. But since it is a thing, I'm sure you guys know better than me.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label topic/gitea-actions type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#10622
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?