File picker broken #10460

New Issue

GiteaMirror · 2025-11-02T09:08:01-06:00

GiteaMirror commented

2025-11-02 09:08:01 -06:00

Originally created by @gempir on GitHub (Mar 20, 2023).

Description

The file picker in a PR has a tiny height and is effectively useless. Tested on 1.19.0 was not broken on 1.19.0-rc1

Example test PR
https://try.gitea.io/gempir/gempbot/pulls/1/files

Gitea Version

1.19.0

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Git Version

No response

Operating System

No response

How are you running Gitea?

systemd

Database

None

Originally created by @gempir on GitHub (Mar 20, 2023). ### Description The file picker in a PR has a tiny height and is effectively useless. Tested on 1.19.0 was not broken on 1.19.0-rc1 Example test PR https://try.gitea.io/gempir/gempbot/pulls/1/files ### Gitea Version 1.19.0 ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist _No response_ ### Screenshots ![image](https://user-images.githubusercontent.com/9765622/226359042-3e0de1ef-bfa6-4a81-b0e1-9315993f7bf2.png) ![image](https://user-images.githubusercontent.com/9765622/226359471-26f118ca-0417-4d91-baa5-235b5c0070fb.png) ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? systemd ### Database None

GiteaMirror added the type/bug label 2025-11-02 09:08:01 -06:00

GiteaMirror closed this issue

2025-11-02 09:08:01 -06:00

GiteaMirror commented

2025-11-02 09:08:02 -06:00

@wxiaoguang commented on GitHub (Mar 20, 2023):

It (update:expanding) works, but ....... there is a height (update:scrolling) bug 😭

~~I guess it's a regression of the LESS->CSS, but I can't tell the difference at the moment .....~~ according to https://github.com/go-gitea/gitea/issues/23593#issuecomment-1476298438 , maybe there is other problem.

Add a screenshot with details for future readers.

@wxiaoguang commented on GitHub (Mar 20, 2023): It (update:expanding) works, but ....... there is a height (update:scrolling) bug 😭 ~~I guess it's a regression of the LESS->CSS, but I can't tell the difference at the moment .....~~ according to https://github.com/go-gitea/gitea/issues/23593#issuecomment-1476298438 , maybe there is other problem. <details> Add a screenshot with details for future readers. ![image](https://user-images.githubusercontent.com/2114189/226361620-eea7c4df-9825-411d-ae0e-daaced721bd7.png) </details>

GiteaMirror commented

2025-11-02 09:08:02 -06:00

@silverwind commented on GitHub (Mar 20, 2023):

https://github.com/go-gitea/gitea/pull/23553 includes a fix for it (removing height: 100%, see https://github.com/go-gitea/gitea/pull/23553#issuecomment-1475406025). I don't think it's from the CSS conversion, just an edge case with many files that was not found earlier.

@silverwind commented on GitHub (Mar 20, 2023): https://github.com/go-gitea/gitea/pull/23553 includes a fix for it (removing `height: 100%`, see https://github.com/go-gitea/gitea/pull/23553#issuecomment-1475406025). I don't think it's from the CSS conversion, just an edge case with many files that was not found earlier.

GiteaMirror commented

2025-11-02 09:08:02 -06:00

@gempir commented on GitHub (Mar 20, 2023):

I did add screenshots, maybe they were not clear enough?

I don't really see how a PR with a scrollbar in the File Picker is an edge case to me that's a regular occurence, as we noticed this regression like 2 hours after upgrading.

@gempir commented on GitHub (Mar 20, 2023): I did add screenshots, maybe they were not clear enough? I don't really see how a PR with a scrollbar in the File Picker is an edge case to me that's a regular occurence, as we noticed this regression like 2 hours after upgrading.

GiteaMirror commented

2025-11-02 09:08:02 -06:00

@silverwind commented on GitHub (Mar 20, 2023):

"Edge case" is probably not the best term, but I mean the bug does not show in all cases.

@silverwind commented on GitHub (Mar 20, 2023): "Edge case" is probably not the best term, but I mean the bug does not show in all cases.

GiteaMirror commented

2025-11-02 09:08:02 -06:00

@wxiaoguang commented on GitHub (Mar 20, 2023):

I did add screenshots, maybe they were not clear enough?

Sorry for bothering, at first I just thought that "expanding" doesn't work well with some height, so I confirmed again that it seems only related to the height & scrolling ..... (correct me if I am wrong)

@wxiaoguang commented on GitHub (Mar 20, 2023): > I did add screenshots, maybe they were not clear enough? Sorry for bothering, at first I just thought that "expanding" doesn't work well with some height, so I confirmed again that it seems only related to the height & scrolling ..... (correct me if I am wrong)

GiteaMirror commented

2025-11-02 09:08:03 -06:00

@wxiaoguang commented on GitHub (Mar 20, 2023):

~~I guess it's still somewhat related to the LESS->CSS (the change itself is good and right, but maybe some old bugs are triggered?)~~ nope, it's #23554

~~According to my test, before: 202803fc69 , the tree-list just works (I can't reproduce the height bug), with current main , I can 100% reproduce it .... strange.~~

I just don't understand what causes the problem ..... I will spend some time on it to see if we can find the root problem, to avoid other potential bugs.

Update: the related PR is #23554 , maybe it's not a edge case, but a regression?

@wxiaoguang commented on GitHub (Mar 20, 2023): ~~I guess it's still somewhat related to the LESS->CSS (the change itself is good and right, but maybe some old bugs are triggered?)~~ nope, it's #23554 ~~According to my test, before: 202803fc69d21763a06d8d0f5a4c46509c18f6f1 , the tree-list just works (I can't reproduce the height bug), with current main , I can 100% reproduce it .... strange.~~ I just don't understand what causes the problem ..... I will spend some time on it to see if we can find the root problem, to avoid other potential bugs. ---- Update: the related PR is #23554 , maybe it's not a edge case, but a regression?

GiteaMirror commented

2025-11-02 09:08:04 -06:00

@silverwind commented on GitHub (Mar 20, 2023):

Yes, it is a regression from #23554 and #23553 will fix it.

@silverwind commented on GitHub (Mar 20, 2023): Yes, it is a regression from #23554 and #23553 will fix it.

GiteaMirror commented

2025-11-02 09:08:04 -06:00

@wxiaoguang commented on GitHub (Mar 23, 2023):

The fix for 1.19 (#23616) has been merged.

You can get 1.19 latest from https://dl.gitea.com/gitea/1.19/ , or docker gitea:1.19-dev

These contain the fix.

@wxiaoguang commented on GitHub (Mar 23, 2023): The fix for 1.19 (#23616) has been merged. You can get 1.19 latest from https://dl.gitea.com/gitea/1.19/ , or docker gitea:1.19-dev These contain the fix.

GiteaMirror commented

2025-11-02 09:08:04 -06:00

@gempir commented on GitHub (Mar 23, 2023):

Will there be no 1.19.1 release ?

@gempir commented on GitHub (Mar 23, 2023): Will there be no 1.19.1 release ?

GiteaMirror commented

2025-11-02 09:08:05 -06:00

@wxiaoguang commented on GitHub (Mar 23, 2023):

There will be. Using 1.19-dev is the most convenient way to get bug fixes quickly before 1.19.1 gets released.

All fixed in 1.19-dev will be included in 1.19.1

After 1.19.1 gets release, then 1.19-dev is for next 1.19.2

@wxiaoguang commented on GitHub (Mar 23, 2023): There will be. Using 1.19-dev is the most convenient way to get bug fixes quickly before 1.19.1 gets released. All fixed in 1.19-dev will be included in 1.19.1 After 1.19.1 gets release, then 1.19-dev is for next 1.19.2

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#10460