Buttons in review box should indicate reason for disablement #10450

New Issue

GiteaMirror · 2025-11-02T09:07:45-06:00

GiteaMirror commented

2025-11-02 09:07:45 -06:00

Originally created by @silverwind on GitHub (Mar 17, 2023).

Originally assigned to: @puni9869 on GitHub.

Description

When trying to review one's own PR, the UI buttons are disabled and there is no indication on why. I think a simple "You can not approve you own Pull Request" would go a long way in making it clear.

Screenshots

Originally created by @silverwind on GitHub (Mar 17, 2023). Originally assigned to: @puni9869 on GitHub. ### Description When trying to review one's own PR, the UI buttons are disabled and there is no indication on why. I think a simple "You can not approve you own Pull Request" would go a long way in making it clear. ### Screenshots <img width="821" alt="image" src="https://user-images.githubusercontent.com/115237/225984020-306c048f-cb9b-4dee-8929-1c74c331518b.png">

GiteaMirror added the topic/ui-interaction good first issue topic/ui labels 2025-11-02 09:07:46 -06:00

GiteaMirror closed this issue

2025-11-02 09:07:46 -06:00

GiteaMirror commented

2025-11-02 09:07:46 -06:00

@silverwind commented on GitHub (Mar 17, 2023):

Alternatively, we could just hide the disabled button and only show the comment button like GitHub does:

I'd say this is even better than disabling the buttons as the user is visually driven to the now-gray "Submit Review" button.

@silverwind commented on GitHub (Mar 17, 2023): Alternatively, we could just hide the disabled button and only show the comment button like GitHub does: <img width="756" alt="image" src="https://user-images.githubusercontent.com/115237/225984341-d85154ea-2f5d-4750-b1b4-4e8c764f27e6.png"> I'd say this is even better than disabling the buttons as the user is visually driven to the now-gray "Submit Review" button.

GiteaMirror commented

2025-11-02 09:07:47 -06:00

@jolheiser commented on GitHub (Mar 17, 2023):

Alternatively, we could just hide the disabled button and only show the comment button like GitHub does:

I'd say this is even better than disabling the buttons as the user is visually driven to the now-gray "Submit Review" button.

Interesting, I still see the options, but they have tooltips for explanation

@jolheiser commented on GitHub (Mar 17, 2023): > Alternatively, we could just hide the disabled button and only show the comment button like GitHub does: > > I'd say this is even better than disabling the buttons as the user is visually driven to the now-gray "Submit Review" button. Interesting, I still see the options, but they have tooltips for explanation ![finish](https://user-images.githubusercontent.com/42128690/225984769-3df855c5-9fc2-4f6c-b057-3e4263c38afe.png)

GiteaMirror commented

2025-11-02 09:07:47 -06:00

@silverwind commented on GitHub (Mar 17, 2023):

Ah yes, the screenshot above was from a already-merged PR. Open PR shows the same UI as you see, so yes I think we should indicate with tooltip on both the red and green button.

@silverwind commented on GitHub (Mar 17, 2023): Ah yes, the screenshot above was from a already-merged PR. Open PR shows the same UI as you see, so yes I think we should indicate with tooltip on both the red and green button.

GiteaMirror commented

2025-11-02 09:07:47 -06:00

@puni9869 commented on GitHub (Mar 20, 2023):

Could you assign this ticket to me.
This would be a good first issue for me. I have some experience with go and web development.

@puni9869 commented on GitHub (Mar 20, 2023): Could you assign this ticket to me. This would be a good first issue for me. I have some experience with go and web development.

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#10450