github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-13 11:31:28 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Email notification for pushes to head branch of closed pull request #10423

New Issue
Closed
opened 2025-11-02 09:07:02 -06:00 by GiteaMirror · 3 comments
GiteaMirror commented 2025-11-02 09:07:02 -06:00
Owner
Copy Link

Originally created by @brechtvl on GitHub (Mar 13, 2023).

Description

  • Enable Settings > Account > And Your Own Notifications (for easier testing with 1 account)
  • Fork a repository
  • Commit a change to the default branch in the base repository
  • Make a pull request on the fork to merge the latest default branch into the fork
  • Close pull request without merging
  • Commit a change to the default branch in the base repository
  • Get an email notification for the closed pull request
  • Pull request itself shows no new commit

I'm guessing this started happening after #23189, since I only saw it after updating to a recent version of Gitea.

I think there are two problems:

  • Email notifications should not be sent out for closed pull requests in this case. This can lead to potentially a lot emails depending if someone is using this workflow to update their fork.
  • Closed pull requests get commit comments but they are hidden. The amount of additional comments can grow effectively quadratically, as more closed pull requests accumulate and more commits are made to the default branch.

Gitea Version

43c1362 (main)

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Both own build and try.gitea.io.

Database

None

Originally created by @brechtvl on GitHub (Mar 13, 2023). ### Description * Enable Settings > Account > And Your Own Notifications (for easier testing with 1 account) * Fork a repository * Commit a change to the default branch in the base repository * Make a pull request on the fork to merge the latest default branch into the fork * Close pull request without merging * Commit a change to the default branch in the base repository * Get an email notification for the closed pull request * Pull request itself shows no new commit I'm guessing this started happening after #23189, since I only saw it after updating to a recent version of Gitea. I think there are two problems: * Email notifications should not be sent out for closed pull requests in this case. This can lead to potentially a lot emails depending if someone is using this workflow to update their fork. * Closed pull requests get commit comments but they are hidden. The amount of additional comments can grow effectively quadratically, as more closed pull requests accumulate and more commits are made to the default branch. ### Gitea Version 43c1362 (main) ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? Both own build and try.gitea.io. ### Database None
GiteaMirror added the type/bug label 2025-11-02 09:07:02 -06:00
GiteaMirror commented 2025-11-02 09:07:03 -06:00
Author
Owner
Copy Link

@brechtvl commented on GitHub (Mar 13, 2023):

CC @sillyguodong

@brechtvl commented on GitHub (Mar 13, 2023): CC @sillyguodong
GiteaMirror commented 2025-11-02 09:07:03 -06:00
Author
Owner
Copy Link

@sillyguodong commented on GitHub (Mar 13, 2023):

CC @sillyguodong

copy that, I will check it.

@sillyguodong commented on GitHub (Mar 13, 2023): > CC @sillyguodong copy that, I will check it.
GiteaMirror commented 2025-11-02 09:07:03 -06:00
Author
Owner
Copy Link

@sillyguodong commented on GitHub (Mar 14, 2023):

  • Email notifications should not be sent out for closed pull requests in this case. This can lead to potentially a lot emails depending if someone is using this workflow to update their fork.

oh, I made a mistake and fix in #23462

@sillyguodong commented on GitHub (Mar 14, 2023): > * Email notifications should not be sent out for closed pull requests in this case. This can lead to potentially a lot emails depending if someone is using this workflow to update their fork. oh, I made a mistake and fix in #23462
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#10423
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?