Organization-wide projects bugs #10388

Author

Owner

Copy Link

@6543 commented on GitHub (Apr 2, 2023):

org projects can only be assigned in issues where it's repo as projects enabled too

@6543 commented on GitHub (Apr 2, 2023): org projects can only be assigned in issues where it's repo as projects enabled too

GiteaMirror commented

Author

Owner

Copy Link

@delvh commented on GitHub (Apr 2, 2023):

If a repo disables projects, its issues cannot be assigned to org-wide projects either. While the current logic for that is clear (if isPackagesEnabled end), this would probably still be useful to implement.

@delvh commented on GitHub (Apr 2, 2023): > If a repo disables projects, its issues cannot be assigned to org-wide projects either. While the current logic for that is clear (if isPackagesEnabled <list available projects> end), this would probably still be useful to implement. ?

GiteaMirror commented

https://user-images.githubusercontent.com/17645053/231639604-5e3ea04d-3ce4-478d-b0e7-189ac0dc19c2.mov

Author

Owner

Copy Link

@HesterG commented on GitHub (Apr 13, 2023):

Find another issue, Buttons used on "set defualt" and "delete column" are not proper, so cancel will disappear on hover. And this occurs on both repo and org level projects:

IMO It is a good idea to use delete_modal_actions.tmpl here both to fix this issue and keep ui consistency as suggested by TODO here
I will open a PR to solve this.

@HesterG commented on GitHub (Apr 13, 2023): Find another issue, Buttons used on "set defualt" and "delete column" are not proper, so cancel will disappear on hover. And this occurs on both repo and org level projects: https://user-images.githubusercontent.com/17645053/231639604-5e3ea04d-3ce4-478d-b0e7-189ac0dc19c2.mov IMO It is a good idea to use `delete_modal_actions.tmpl` here both to fix this issue and keep ui consistency as suggested by [TODO here](https://github.com/go-gitea/gitea/blob/4299c3b7db61f8741eca0ba3d663bb65745a4acc/templates/projects/view.tmpl#L161) I will open a PR to solve this.

GiteaMirror commented

Author

Owner

Copy Link

@yp05327 commented on GitHub (Apr 13, 2023):

Maybe this problem is caused by css?
The button will not disappear in dark mode.

If I open devtools in chrome, the button works well in dark mode.
But if I close DevTools, the button will have no changes when mouse move across the button.

Open devtools:
mouse not on the button:

mouse on the button:

Close devtools (always same as mouse on the button):

Tested in gitea.com

@yp05327 commented on GitHub (Apr 13, 2023): Maybe this problem is caused by css? The button will not disappear in dark mode. If I open devtools in chrome, the button works well in dark mode. But if I close DevTools, the button will have no changes when mouse move across the button. Open devtools: mouse not on the button: ![image](https://user-images.githubusercontent.com/18380374/231646323-f910c053-fad2-4e68-a131-6daa7a96b36f.png) mouse on the button: ![image](https://user-images.githubusercontent.com/18380374/231646367-98e5bfb6-d3a0-4195-be9b-6819c46eea37.png) Close devtools (always same as `mouse on the button`): ![image](https://user-images.githubusercontent.com/18380374/231646614-a9d19c31-25d7-415f-86bb-e8f83c9f54d9.png) Tested in gitea.com

GiteaMirror commented

Author

Owner

Copy Link

@HesterG commented on GitHub (Apr 13, 2023):

Maybe this problem is caused by css? The button will not disappear in dark mode.

If I open devtools in chrome, the button works well in dark mode. But if I close DevTools, the button will have no changes when mouse move across the button.

Open devtools: mouse not on the button: mouse on the button:

Close devtools (always same as mouse on the button): Tested in gitea.com

Yes it is caused by css, the reason why arc-green theme looks good is because the color for the text on cancel button on hover is different from gitea theme. And here it might be more suitable to use delete_modal_actions.tmpl also for consistency, like some other places with the similar modal ui:

e.g. Delete Project UI:

@HesterG commented on GitHub (Apr 13, 2023): > Maybe this problem is caused by css? The button will not disappear in dark mode. > > If I open devtools in chrome, the button works well in dark mode. But if I close DevTools, the button will have no changes when mouse move across the button. > > Open devtools: mouse not on the button: ![image](https://user-images.githubusercontent.com/18380374/231646323-f910c053-fad2-4e68-a131-6daa7a96b36f.png) mouse on the button: ![image](https://user-images.githubusercontent.com/18380374/231646367-98e5bfb6-d3a0-4195-be9b-6819c46eea37.png) > > Close devtools (always same as `mouse on the button`): ![image](https://user-images.githubusercontent.com/18380374/231646614-a9d19c31-25d7-415f-86bb-e8f83c9f54d9.png) Tested in gitea.com Yes it is caused by css, the reason why `arc-green` theme looks good is because the color for the text on cancel button on hover is different from `gitea` theme. And here it might be more suitable to use `delete_modal_actions.tmpl` also for consistency, like some other places with the similar modal ui: e.g. Delete Project UI: <img width="853" alt="截屏2023-04-13 13 58 36" src="https://user-images.githubusercontent.com/17645053/231667034-b103758d-68e2-4731-8742-9e54fe9576eb.png">

GiteaMirror commented

Author

Owner

Copy Link

@silverwind commented on GitHub (Apr 17, 2023):

Looks like some bug in the button colors. I'd argue the modal buttons should be full red/green, with no inner grey border, on both themes.

@silverwind commented on GitHub (Apr 17, 2023): Looks like some bug in the button colors. I'd argue the modal buttons should be full red/green, with no inner grey border, on both themes.

GiteaMirror commented

https://user-images.githubusercontent.com/17645053/232642409-ccb6653c-47ad-4fac-82fe-d0ea8d915b95.mov

Author

Owner

Copy Link

@HesterG commented on GitHub (Apr 18, 2023):

Looks like some bug in the button colors. I'd argue the modal buttons should be full red/green, with no inner grey border, on both themes.

Do you mean like this?

@HesterG commented on GitHub (Apr 18, 2023): > Looks like some bug in the button colors. I'd argue the modal buttons should be full red/green, with no inner grey border, on both themes. Do you mean like this? https://user-images.githubusercontent.com/17645053/232642409-ccb6653c-47ad-4fac-82fe-d0ea8d915b95.mov

GiteaMirror commented

Author

Owner

Copy Link

@silverwind commented on GitHub (Apr 19, 2023):

Do you mean like this?

I envisioned with border, but your style looks even better, let's do it.

@silverwind commented on GitHub (Apr 19, 2023): > Do you mean like this? I envisioned with border, but your style looks even better, let's do it.

GiteaMirror commented

Author

Owner

Copy Link

@HesterG commented on GitHub (Apr 20, 2023):

Do you mean like this?

I envisioned with border, but your style looks even better, let's do it.

add a commit 1df04eef57 to do this style

@HesterG commented on GitHub (Apr 20, 2023): > > Do you mean like this? > > I envisioned with border, but your style looks even better, let's do it. add a commit https://github.com/go-gitea/gitea/pull/24097/commits/1df04eef57e9b9d8020cd460dea87cdd0338b2dd to do this style

GiteaMirror commented

Author

Owner

Copy Link

@delvh commented on GitHub (Apr 23, 2023):

Closed accidentally.

@delvh commented on GitHub (Apr 23, 2023): Closed accidentally.

GiteaMirror commented

Author

Owner

Copy Link

@delvh commented on GitHub (Jun 28, 2023):

Found another one: If you click on the PR that closed an issue inside an org-wide project, you get redirected to $URL/pull/$ID instead of $URL/$USER/$REPO/pull/$ID

@delvh commented on GitHub (Jun 28, 2023): Found another one: If you click on the PR that closed an issue inside an org-wide project, you get redirected to `$URL/pull/$ID` instead of `$URL/$USER/$REPO/pull/$ID`

GiteaMirror commented

Author

Owner

Copy Link

@brenthuisman commented on GitHub (Nov 21, 2023):

Found another one: If you click on the PR that closed an issue inside an org-wide project, you get redirected to $URL/pull/$ID instead of $URL/$USER/$REPO/pull/$ID

Just got bit by this one (during a demo of Gitea). Tracking issues on a org board or third repo board are broken.

@brenthuisman commented on GitHub (Nov 21, 2023): > Found another one: If you click on the PR that closed an issue inside an org-wide project, you get redirected to `$URL/pull/$ID` instead of `$URL/$USER/$REPO/pull/$ID` Just got bit by this one (during a demo of Gitea). Tracking issues on a org board or third repo board are broken.

GiteaMirror commented

Author

Owner

Copy Link

@denyskon commented on GitHub (Mar 17, 2024):

Confirmed that the last remaining issues were resolved by #28805 and #28806

@denyskon commented on GitHub (Mar 17, 2024): Confirmed that the last remaining issues were resolved by #28805 and #28806

GiteaMirror commented

Author

Owner

Copy Link

@delvh commented on GitHub (Mar 17, 2024):

I think

When creating an org project, and adding a second column only the second column can be edited, the first one can't.
See screenshot 1 and 2. Happens both for repo- and org-projects

is still present.
But apart from that, yes, agreed, we slowly seem to have gotten rid of the project bugs. Finally 😌

@delvh commented on GitHub (Mar 17, 2024): I think > When creating an org project, and adding a second column only the second column can be edited, the first one can't. See screenshot 1 and 2. Happens both for repo- and org-projects is still present. But apart from that, yes, agreed, we slowly seem to have gotten rid of the project bugs. Finally :relieved:

GiteaMirror commented

Author

Owner

Copy Link

@denyskon commented on GitHub (Mar 17, 2024):

@delvh Why should the default column be edited? If you don't like it, create a new one and set it as default. I think it is expected behaviour.

@denyskon commented on GitHub (Mar 17, 2024): @delvh Why should the default column be edited? If you don't like it, create a new one and set it as default. I think it is expected behaviour.

GiteaMirror commented

Author

Owner

Copy Link

@delvh commented on GitHub (Mar 17, 2024):

Why do we need such a workaround for these things?

@delvh commented on GitHub (Mar 17, 2024): ![grafik](https://github.com/go-gitea/gitea/assets/51889757/d151095f-8143-4cc9-a112-12e6bacc3b81) Why do we need such a workaround for these things?

GiteaMirror commented

Author

Owner

Copy Link

@denyskon commented on GitHub (Mar 17, 2024):

Well maybe it's because I always considered it to be a feature, not a bug, I don't understand where the problem is, but for me the default column always was something that is there for empty projects still to be able to contain issues, and if you need more you create a new column. We can change it of course.

@denyskon commented on GitHub (Mar 17, 2024): Well maybe it's because I always considered it to be a feature, not a bug, I don't understand where the problem is, but for me the default column always was something that is there for empty projects still to be able to contain issues, and if you need more you create a new column. We can change it of course.

GiteaMirror commented

Author

Owner

Copy Link

@delvh commented on GitHub (Mar 17, 2024):

That's not what I mean.
What I mean is:
Why can't I rename or recolor the default board but everything else?
However, if I change the default board, I suddenly can?

@delvh commented on GitHub (Mar 17, 2024): That's not what I mean. What I mean is: Why can't I rename or recolor the default board but everything else? However, if I change the default board, I suddenly can?

GiteaMirror commented