X-Gitea-Debug header being sent 3 times #10385

Closed
opened 2025-11-02 09:06:03 -06:00 by GiteaMirror · 3 comments
Owner

Originally created by @stuzer05 on GitHub (Mar 5, 2023).

Description

On view commit diff page, commit file request X-Gitea-Debug header is duplicated 3 times

Gitea Version

latest master

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

image

Git Version

No response

Operating System

No response

How are you running Gitea?

Latest master, make watch-backend, make watch-frontend

Database

None

Originally created by @stuzer05 on GitHub (Mar 5, 2023). ### Description On view commit diff page, commit file request X-Gitea-Debug header is duplicated 3 times ### Gitea Version latest master ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Screenshots ![image](https://user-images.githubusercontent.com/23124682/222958089-fea0032e-e22d-414d-bc6f-d2d1386f8ef9.png) ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? Latest master, make watch-backend, make watch-frontend ### Database None
GiteaMirror added the type/bug label 2025-11-02 09:06:03 -06:00
Author
Owner

@wxiaoguang commented on GitHub (Mar 5, 2023):

It must be caused by repeated/duplicate calls to httpcache.AddCacheControlToHeader. That's not ideal, but luckily there is not side effect at the moment ....

@wxiaoguang commented on GitHub (Mar 5, 2023): It must be caused by repeated/duplicate calls to `httpcache.AddCacheControlToHeader`. That's not ideal, but luckily there is not side effect at the moment ....
Author
Owner

@stuzer05 commented on GitHub (Mar 5, 2023):

Is there a reason to call httpcache.AddCacheControlToHeader 3 times? Looking on code, it seems it doesn't do anything different with each call

@stuzer05 commented on GitHub (Mar 5, 2023): Is there a reason to call `httpcache.AddCacheControlToHeader` 3 times? Looking on code, it seems it doesn't do anything different with each call
Author
Owner

@wxiaoguang commented on GitHub (Mar 5, 2023):

Of course no reason .... 😂 so that's not ideal.

@wxiaoguang commented on GitHub (Mar 5, 2023): Of course no reason .... 😂 so that's not ideal.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#10385