Reviewing PRs: Ctrl+Enter submits comment instead of starting a review #10368

New Issue

GiteaMirror · 2025-11-02T09:05:25-06:00

GiteaMirror commented

2025-11-02 09:05:25 -06:00

Originally created by @drsybren on GitHub (Mar 2, 2023).

Description

When writing an inline comment on a pull request, the "Start review" button is highlighted as the primary button for the text area:

However, when pressing Ctrl+Enter on the keyboard, it is interpreted as pressing the "Add single comment" button.

The biggest issue here is that the "Add single comment" button immediately submits the comment. There is no way to undo this, whereas accidentally starting a review does not immediately send something to the PR author, and thus the review can be cancelled at a later time without bothering anyone, in case it was started by accident.

Gitea Version

1.19.0+dev-649-g2093ca517

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Self-built from Git

Database

None

Originally created by @drsybren on GitHub (Mar 2, 2023). ### Description When writing an inline comment on a pull request, the "Start review" button is highlighted as the primary button for the text area: ![image](https://user-images.githubusercontent.com/122987084/222409249-e60508a3-b78c-482d-b8cf-f2cab5b4811b.png) However, when pressing Ctrl+Enter on the keyboard, it is interpreted as pressing the "Add single comment" button. The biggest issue here is that the "Add single comment" button **immediately** submits the comment. There is no way to undo this, whereas accidentally starting a review does not immediately send something to the PR author, and thus the review can be cancelled at a later time without bothering anyone, in case it was started by accident. ### Gitea Version 1.19.0+dev-649-g2093ca517 ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? Self-built from Git ### Database None

GiteaMirror added the issue/confirmed type/bug labels 2025-11-02 09:05:25 -06:00

GiteaMirror closed this issue

2025-11-02 09:05:26 -06:00

GiteaMirror commented

2025-11-02 09:05:26 -06:00

@wxiaoguang commented on GitHub (Mar 2, 2023):

This behavior comes from

#19729

Why the Ctrl+Enter doesn't trigger the default primary button: because in the review form, users might not want to approve the PR, they might just want to leave a comment.

I agree to improve the UX, while some details could be fine-tuned and considered together.

A quick fix could be: change some forms' default actions, some forms use "start review" while some forms use "comment"

@wxiaoguang commented on GitHub (Mar 2, 2023): This behavior comes from * #19729 Why the Ctrl+Enter doesn't trigger the default primary button: because in the review form, users might not want to approve the PR, they might just want to leave a comment. I agree to improve the UX, while some details could be fine-tuned and considered together. A quick fix could be: change some forms' default actions, some forms use "start review" while some forms use "comment" <details> ![image](https://user-images.githubusercontent.com/2114189/222415822-4d2ed3ce-cc09-4512-9817-95d282ed89d0.png) </details>

GiteaMirror commented

2025-11-02 09:05:27 -06:00

@wxiaoguang commented on GitHub (Mar 2, 2023):

Quickly go through the code again, making the "Start Review" button as the default action seems not an easy task (not just minutes, but maybe hours?), maybe that's the reason why I didn't touch them last time when I added the Ctrl+Enter support .... I can still see my comment for name="is_review" value="true" in code 😂

Update: I tried to proposed a fix (more complicated than I thought ...), did some quick tests, it seems working as expected.

@wxiaoguang commented on GitHub (Mar 2, 2023): Quickly go through the code again, making the "Start Review" button as the default action seems not an easy task (not just minutes, but maybe hours?), maybe that's the reason why I didn't touch them last time when I added the Ctrl+Enter support .... I can still see my comment for `name="is_review" value="true"` in code 😂 ---- Update: I tried to proposed a fix (more complicated than I thought ...), did some quick tests, it seems working as expected.

GiteaMirror commented

2025-11-02 09:05:27 -06:00

@wxiaoguang commented on GitHub (Mar 2, 2023):

Please test this fix: Make Ctrl+Enter submit a pending comment (starting review) instead of submitting a single comment #23245

@wxiaoguang commented on GitHub (Mar 2, 2023): Please test this fix: Make Ctrl+Enter submit a pending comment (starting review) instead of submitting a single comment #23245

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#10368