github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Code diff UI goes misalignment with code review comments #10273

New Issue
Closed
opened 2025-11-02 09:02:52 -06:00 by GiteaMirror · 9 comments
GiteaMirror commented 2025-11-02 09:02:52 -06:00
Owner
Copy Link

Originally created by @wxiaoguang on GitHub (Feb 15, 2023).

Description

https://jsfiddle.net/ob0y2x83/

The padding inside td makes the widths of td become larger.

<table style="width: 100%">
  <tr>
    <td style="width: 10px;">a</td>
    <td style="width: 0"></td>
    <td style="width: 10px;">b</td>
    <td style="width: 49%">long content</td>
    
    <td style="width: 10px;">a</td>
    <td style="width: 0"></td>
    <td style="width: 10px;">b</td>
    <td style="width: 49%">long content</td>
  </tr>
  <tr>
    <td colspan="4">
      <div style="width: 30%"> 
        <div style="padding-left: 100px;">
          with padding
        </div>
      </div>
    </td>
    <td colspan="4">
      <div style="width: 30%"> 
        <div style="padding-left: 100px;">
          with padding
        </div>
      </div>
    </td>
  </tr>
</table>

<hr>

<table style="width: 100%">
  <tr>
    <td style="width: 10px;">a</td>
    <td style="width: 0"></td>
    <td style="width: 10px;">b</td>
    <td style="width: 49%">long content</td>
    
    <td style="width: 10px;">a</td>
    <td style="width: 0"></td>
    <td style="width: 10px;">b</td>
    <td style="width: 49%">long content</td>
  </tr>
  <tr>
    <td colspan="4">
      <div style="width: 30%"> 
        <div style="padding-left: 0;">
          no padding
        </div>
      </div>
    </td>
    <td colspan="4">
      <div style="width: 30%"> 
        <div style="padding-left: 0;">
          no padding
        </div>
      </div>
    </td>
  </tr>
</table>

image

image

Originally created by @wxiaoguang on GitHub (Feb 15, 2023). ### Description https://jsfiddle.net/ob0y2x83/ The `padding` inside `td` makes the widths of `td` become larger. <details> ```html <table style="width: 100%"> <tr> <td style="width: 10px;">a</td> <td style="width: 0"></td> <td style="width: 10px;">b</td> <td style="width: 49%">long content</td> <td style="width: 10px;">a</td> <td style="width: 0"></td> <td style="width: 10px;">b</td> <td style="width: 49%">long content</td> </tr> <tr> <td colspan="4"> <div style="width: 30%"> <div style="padding-left: 100px;"> with padding </div> </div> </td> <td colspan="4"> <div style="width: 30%"> <div style="padding-left: 100px;"> with padding </div> </div> </td> </tr> </table> <hr> <table style="width: 100%"> <tr> <td style="width: 10px;">a</td> <td style="width: 0"></td> <td style="width: 10px;">b</td> <td style="width: 49%">long content</td> <td style="width: 10px;">a</td> <td style="width: 0"></td> <td style="width: 10px;">b</td> <td style="width: 49%">long content</td> </tr> <tr> <td colspan="4"> <div style="width: 30%"> <div style="padding-left: 0;"> no padding </div> </div> </td> <td colspan="4"> <div style="width: 30%"> <div style="padding-left: 0;"> no padding </div> </div> </td> </tr> </table> ``` </details> ![image](https://user-images.githubusercontent.com/2114189/218938928-30307bfc-63b3-45ca-b427-52cce5517895.png) ![image](https://user-images.githubusercontent.com/2114189/218938781-b97535c9-f54f-4d96-86dc-eda5440adc0a.png)
GiteaMirror added the topic/uitype/bug labels 2025-11-02 09:02:52 -06:00
GiteaMirror commented 2025-11-02 09:02:53 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Mar 30, 2023):

Move the milestone to 1.20 or 1.x ? I am not working on it. Welcome to pick it.

Update: I proposed a draft #23096 , welcome to test & review.

@wxiaoguang commented on GitHub (Mar 30, 2023): ~~Move the milestone to 1.20 or 1.x ? I am not working on it. Welcome to pick it.~~ Update: I proposed a draft #23096 , welcome to test & review.
GiteaMirror commented 2025-11-02 09:02:53 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Mar 30, 2023):

Move the milestone to 1.20 or 1.x ? I am not working on it. Welcome to pick it.

When we are releasing 1.19.1 if there is no PR to fix it. We can move it to 1.19.2

@lunny commented on GitHub (Mar 30, 2023): > Move the milestone to 1.20 or 1.x ? I am not working on it. Welcome to pick it. When we are releasing 1.19.1 if there is no PR to fix it. We can move it to 1.19.2
GiteaMirror commented 2025-11-02 09:02:53 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Mar 30, 2023):

I think there needs a document to explain how the milestone works.

In my mind, only necessary/blocker issues should be on the stable release milestones.

@wxiaoguang commented on GitHub (Mar 30, 2023): I think there needs a document to explain how the milestone works. In my mind, only necessary/blocker issues should be on the stable release milestones.
GiteaMirror commented 2025-11-02 09:02:53 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Mar 30, 2023):

I think there needs a document to explain how the milestone works.

In my mind, only necessary/blocker issues should be on the stable release milestones.

Yes, we need one. I think since it has been marked bug so that it could be put in a minor version if 1.19 has been affected.

@lunny commented on GitHub (Mar 30, 2023): > I think there needs a document to explain how the milestone works. > > > > In my mind, only necessary/blocker issues should be on the stable release milestones. > > Yes, we need one. I think since it has been marked bug so that it could be put in a minor version if 1.19 has been affected.
GiteaMirror commented 2025-11-02 09:02:53 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Mar 30, 2023):

This problem is very complicated. I don't think it could be backported easily even if it gets resolved in 1.20

@wxiaoguang commented on GitHub (Mar 30, 2023): This problem is very complicated. I don't think it could be backported easily even if it gets resolved in 1.20
GiteaMirror commented 2025-11-02 09:02:54 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Mar 31, 2023):

OK. So let's move it to 1.20

@lunny commented on GitHub (Mar 31, 2023): OK. So let's move it to 1.20
GiteaMirror commented 2025-11-02 09:02:54 -06:00
Author
Owner
Copy Link

@jpraet commented on GitHub (Mar 31, 2023):

I do think fixing this UX regression deserves some attention though. This incorrect alignment in the side-by-side diff for review comments is quite annoying. Especially for the + button to add a new review comment. Personally, I switched to the unified diff view on my company instance just to work around this issue.

Does this seem like something in your wheelhouse maybe @silverwind, as you've been tackling some other UI issues related to the PR diff view lately?

@jpraet commented on GitHub (Mar 31, 2023): I do think fixing this UX regression deserves some attention though. This incorrect alignment in the side-by-side diff for review comments is quite annoying. Especially for the + button to add a new review comment. Personally, I switched to the unified diff view on my company instance just to work around this issue. Does this seem like something in your wheelhouse maybe @silverwind, as you've been tackling some other UI issues related to the PR diff view lately?
GiteaMirror commented 2025-11-02 09:02:54 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (Apr 1, 2023):

Possible, but personally I do not use side-by-side ever, so it's not a priority for me.

@silverwind commented on GitHub (Apr 1, 2023): Possible, but personally I do not use side-by-side ever, so it's not a priority for me.
GiteaMirror commented 2025-11-02 09:02:54 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Apr 1, 2023):

@jpraet I made more improvements in #23096 , I guess it's good enough now (I haven't fully tested it with various browsers), and I think it's safe for you to test it in your production environment.

If it looks good to you, please help to review. Thank you.

@wxiaoguang commented on GitHub (Apr 1, 2023): @jpraet I made more improvements in #23096 , I guess it's good enough now (I haven't fully tested it with various browsers), and I think it's safe for you to test it in your production environment. If it looks good to you, please help to review. Thank you.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label topic/ui type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#10273
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?