github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-09 04:25:18 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Source code line's comments are not taken into account on Pull Requests page #10092

New Issue
Closed
opened 2025-11-02 08:57:57 -06:00 by GiteaMirror · 4 comments
GiteaMirror commented 2025-11-02 08:57:57 -06:00
Owner
Copy Link

Originally created by @kuraga on GitHub (Jan 12, 2023).

Description

On the Gitea demo site, source code line's comments are not taken into account on Pull Requests page. So, they are not added to the count of the MR's comments count.

Gitea Version

1.19.0+dev-291

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

I visit it via a browser.

Database

None

Originally created by @kuraga on GitHub (Jan 12, 2023). ### Description On the Gitea demo site, source code line's comments are not taken into account on `Pull Requests` page. So, they are not added to the count of the MR's comments count. ### Gitea Version 1.19.0+dev-291 ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? I visit it via a browser. ### Database None
GiteaMirror added the proposal/acceptedtype/bug labels 2025-11-02 08:57:57 -06:00
GiteaMirror commented 2025-11-02 08:57:58 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Jan 13, 2023):

Should they be counted?

@lunny commented on GitHub (Jan 13, 2023): Should they be counted?
GiteaMirror commented 2025-11-02 08:57:58 -06:00
Author
Owner
Copy Link

@kuraga commented on GitHub (Jan 13, 2023):

Well I think 'there are no comments' if there is not a badge (on Pull Requests page). But they are.

@kuraga commented on GitHub (Jan 13, 2023): Well I think 'there are no comments' if there is not a badge (on `Pull Requests` page). But they are.
GiteaMirror commented 2025-11-02 08:57:58 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (Jan 13, 2023):

I agree, line comments should count towards the comment count. This is how it works on GitHub as well.

@silverwind commented on GitHub (Jan 13, 2023): I agree, line comments should count towards the comment count. This is how it works on GitHub as well.
GiteaMirror commented 2025-11-02 08:57:58 -06:00
Author
Owner
Copy Link

@kuraga commented on GitHub (Aug 1, 2024):

#30556

@kuraga commented on GitHub (Aug 1, 2024): #30556
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label proposal/accepted type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#10092
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?