github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Toggling Picture and Avatar Configuration switches have no effect #10054

New Issue
Closed
opened 2025-11-02 08:57:01 -06:00 by GiteaMirror · 4 comments
GiteaMirror commented 2025-11-02 08:57:01 -06:00
Owner
Copy Link

Originally created by @strk on GitHub (Jan 3, 2023).

Description

Toggling the Avatar switches in admin/config URL does not change the configuration as requested: reloading the page moves the switches back to their original position.

I verified the request is sent to the server, the request is also logged by the server:

2023/01/04 00:04:41 [63b4b489] router: completed POST /admin/config for 192.168.1.82:44014, 200 OK in 2.6ms @ admin/config.go:193(admin.ChangeConfig)

BUT there's no change in the database (PostgreSQL) and reloading the page shows it (switches are back to their original position)

Gitea Version

1.19.0+dev-264-g32e863439 P

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

from build tree. Cannot reproduce on try.gitea.io only because I'm not admin there, but if you grant me admin (strk) I can try

Database

PostgreSQL

Originally created by @strk on GitHub (Jan 3, 2023). ### Description Toggling the Avatar switches in admin/config URL does not change the configuration as requested: reloading the page moves the switches back to their original position. I verified the request is sent to the server, the request is also logged by the server: > 2023/01/04 00:04:41 [63b4b489] router: completed POST /admin/config for 192.168.1.82:44014, 200 OK in 2.6ms @ admin/config.go:193(admin.ChangeConfig) BUT there's no change in the database (PostgreSQL) and reloading the page shows it (switches are back to their original position) ### Gitea Version 1.19.0+dev-264-g32e863439 P ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? from build tree. Cannot reproduce on try.gitea.io only because I'm not admin there, but if you grant me admin (strk) I can try ### Database PostgreSQL
GiteaMirror added the type/bug label 2025-11-02 08:57:01 -06:00
GiteaMirror commented 2025-11-02 08:57:02 -06:00
Author
Owner
Copy Link

@strk commented on GitHub (Jan 3, 2023):

Bug seems to be in func SetSetting in models/system/setting.go whereas the upsertSettingValue function is ONLY invoked when the key is not already cached in the settings cache. Sounds wrong to only conditionally upsert...

@strk commented on GitHub (Jan 3, 2023): Bug seems to be in `func SetSetting` in `models/system/setting.go` whereas the `upsertSettingValue` function is ONLY invoked when the key is not already cached in the settings cache. Sounds wrong to only conditionally upsert...
GiteaMirror commented 2025-11-02 08:57:02 -06:00
Author
Owner
Copy Link

@strk commented on GitHub (Jan 3, 2023):

@lunny git blame tells it was you the last to touch that SetSetting function

@strk commented on GitHub (Jan 3, 2023): @lunny git blame tells it was you the last to touch that `SetSetting` function
GiteaMirror commented 2025-11-02 08:57:02 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Jan 3, 2023):

I Will take a look at it today. Thank you for your report.

@lunny commented on GitHub (Jan 3, 2023): I Will take a look at it today. Thank you for your report.
GiteaMirror commented 2025-11-02 08:57:02 -06:00
Author
Owner
Copy Link

@strk commented on GitHub (Jan 3, 2023):

The bug is possibly rooted in PR #22295 there's evidently an hole in testsuite regarding caches

@strk commented on GitHub (Jan 3, 2023): The bug is possibly rooted in PR #22295 there's evidently an hole in testsuite regarding caches
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#10054
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?