mirror of
https://github.com/pd4d10/git-touch.git
synced 2026-03-09 15:22:37 -05:00
UI : Container length of TabStatefulScaffold in "Cupertino style" changes when switching tabs #60
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/git-touch#60
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @van-8 on GitHub (Jul 12, 2020).
For example, in the Github
Notificiations_Screen, the word "Participating" is long. When the tab isselected, it expands the entire Tab widget. This is mostly likely because theselectedstate has a heavierfontweight, thus expanding the entire parent Container Widget. This occurs in Cupertino style only.Possible fix: When tab is active, do not change the
fontweight.I only started learning coding and Flutter a few months ago, so if I figure it out I'll submit a merge.
@pd4d10 commented on GitHub (Jul 12, 2020):
Nice catch!
How about expanding the tabbar to full width? Then it would have enough space.
@van-8 commented on GitHub (Jul 14, 2020):
Perfect.
In the Apple Human Interface Guidelines, the Segmented Controls are always full width.
It seems this might be Flutter not updating their widget to iOS13 standards? Maybe we can submit this fix to the main Flutter branch?Seems like inlib/scaffolds/tab.dartyou can just do a quick change of line 64 fromDefaultTabController()to aCupertinoSlidingSegmentedControl().I'm so bad at coding. You have
CupertinoSlidingSegmentedControl()on line 32. I don't know how to fix. 😅Here's an example for 2 segments, which would apply to the GitTouch
trending_screen.@pd4d10 commented on GitHub (Jul 15, 2020):
Would
Row > Expanded > CupertinoSlidingSegmentedControlwork for this case?@shreyas1599 commented on GitHub (Aug 17, 2020):
This didn't work. I changed the padding to 12 and it seemed to work on iphone se2 and 11 pro. Guess it should work for all devices. Shall I open a pr? Or @van-8 would you like to?