github-starred/git-touch
2
0
Fork 0
mirror of https://github.com/pd4d10/git-touch.git synced 2026-05-06 03:38:39 -05:00
Code Issues 800 Packages Projects Releases 18 Wiki Activity

[PR #93] [MERGED] fix: commit comment event render error #2702

New Issue
Closed
opened 2026-05-03 02:28:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-03 02:28:35 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pd4d10/git-touch/pull/93
Author: @shreyas1599
Created: 5/16/2020
Status: ✅ Merged
Merged: 5/17/2020
Merged by: @pd4d10

Base: master ← Head: commit-comment-fix

📝 Commits (1)

  • e3c5e29 fix: commit comment event render error

📊 Changes

3 files changed (+50 additions, -4 deletions)

View changed files

📝 lib/models/github.dart (+2 -0)
📝 lib/models/github.g.dart (+5 -1)
📝 lib/widgets/event_item.dart (+43 -3)

📄 Description

  • Blank news screen for those with a CommitComment event in their feed.
  • CommitComment event rendered my news screen blank today. Took some time to figure that out.
  • My bad, I should've paid more attention to the json response clearly to have avoided the use of buildCommitsCard for this event.

This was the error:

image

After fixing:

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pd4d10/git-touch/pull/93 **Author:** [@shreyas1599](https://github.com/shreyas1599) **Created:** 5/16/2020 **Status:** ✅ Merged **Merged:** 5/17/2020 **Merged by:** [@pd4d10](https://github.com/pd4d10) **Base:** `master` ← **Head:** `commit-comment-fix` --- ### 📝 Commits (1) - [`e3c5e29`](https://github.com/pd4d10/git-touch/commit/e3c5e29fff3cd087db7b49c5d5f2cdf8526c15a2) fix: commit comment event render error ### 📊 Changes **3 files changed** (+50 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `lib/models/github.dart` (+2 -0) 📝 `lib/models/github.g.dart` (+5 -1) 📝 `lib/widgets/event_item.dart` (+43 -3) </details> ### 📄 Description - Blank news screen for those with a `CommitComment` event in their feed. - `CommitComment` event rendered my news screen blank today. Took some time to figure that out. - My bad, I should've paid more attention to the json response clearly to have avoided the use of `buildCommitsCard` for this event. This was the error: ![image](https://user-images.githubusercontent.com/28999492/82120090-487e7f80-97a1-11ea-9b9e-8178643cdbfd.png) After fixing: ![image](https://user-images.githubusercontent.com/28999492/82120096-5207e780-97a1-11ea-9968-a31f72833a3b.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-03 02:28:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
gitea
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/git-touch#2702
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?