Blank news screen for those with a CommitComment event in their feed.
CommitComment event rendered my news screen blank today. Took some time to figure that out.
My bad, I should've paid more attention to the json response clearly to have avoided the use of buildCommitsCard for this event.
This was the error:
After fixing:
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/pd4d10/git-touch/pull/93
**Author:** [@shreyas1599](https://github.com/shreyas1599)
**Created:** 5/16/2020
**Status:** ✅ Merged
**Merged:** 5/17/2020
**Merged by:** [@pd4d10](https://github.com/pd4d10)
**Base:** `master` ← **Head:** `commit-comment-fix`
---
### 📝 Commits (1)
- [`e3c5e29`](https://github.com/pd4d10/git-touch/commit/e3c5e29fff3cd087db7b49c5d5f2cdf8526c15a2) fix: commit comment event render error
### 📊 Changes
**3 files changed** (+50 additions, -4 deletions)
<details>
<summary>View changed files</summary>
📝 `lib/models/github.dart` (+2 -0)
📝 `lib/models/github.g.dart` (+5 -1)
📝 `lib/widgets/event_item.dart` (+43 -3)
</details>
### 📄 Description
- Blank news screen for those with a `CommitComment` event in their feed.
- `CommitComment` event rendered my news screen blank today. Took some time to figure that out.
- My bad, I should've paid more attention to the json response clearly to have avoided the use of `buildCommitsCard` for this event.
This was the error:
After fixing:
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/pd4d10/git-touch/pull/93
Author: @shreyas1599
Created: 5/16/2020
Status: ✅ Merged
Merged: 5/17/2020
Merged by: @pd4d10
Base:
master← Head:commit-comment-fix📝 Commits (1)
e3c5e29fix: commit comment event render error📊 Changes
3 files changed (+50 additions, -4 deletions)
View changed files
📝
lib/models/github.dart(+2 -0)📝
lib/models/github.g.dart(+5 -1)📝
lib/widgets/event_item.dart(+43 -3)📄 Description
CommitCommentevent in their feed.CommitCommentevent rendered my news screen blank today. Took some time to figure that out.buildCommitsCardfor this event.This was the error:
After fixing:
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.