github-starred/git-touch
2
0
Fork 0
mirror of https://github.com/pd4d10/git-touch.git synced 2026-05-07 04:10:01 -05:00
Code Issues 800 Packages Projects Releases 18 Wiki Activity

[GH-ISSUE #248] [github] request review event type error #2306

New Issue
Closed
opened 2026-04-27 18:28:50 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-27 18:28:50 -05:00
Owner
Copy Link

Originally created by @pd4d10 on GitHub (Jun 14, 2021).
Original GitHub issue: https://github.com/pd4d10/git-touch/issues/248

simulator_screenshot_46A65892-BD9B-4D5C-9BEC-33494EF7C339

Originally created by @pd4d10 on GitHub (Jun 14, 2021). Original GitHub issue: https://github.com/pd4d10/git-touch/issues/248 ![simulator_screenshot_46A65892-BD9B-4D5C-9BEC-33494EF7C339](https://user-images.githubusercontent.com/9524411/121930948-92a3ad00-cd75-11eb-86ba-e51070bc0167.png)
GiteaMirror commented 2026-04-27 18:28:55 -05:00
Author
Owner
Copy Link

@shreyas1599 commented on GitHub (Jun 17, 2021):

@pd4d10

It can be fixed by removing the typecasts in ddfa9e469e/lib/widgets/timeline_item.dart (L445) and ddfa9e469e/lib/widgets/timeline_item.dart (L456)

Is there any specific reason why you've used typecasts? If typecasting is necessary then ddfa9e469e/lib/widgets/timeline_item.dart (L456) will have to be modified to GIssueData_repository_issueOrPullRequest__asPullRequest_timelineItems_nodes__asReviewRequestedEvent_requestedReviewer__asUser as the cast. I'll add a fix based on which you suggest is better

<!-- gh-comment-id:862990401 --> @shreyas1599 commented on GitHub (Jun 17, 2021): @pd4d10 It can be fixed by removing the typecasts in https://github.com/git-touch/git-touch/blob/ddfa9e469e5be888aef32b8b13fa09dac079f69c/lib/widgets/timeline_item.dart#L445 and https://github.com/git-touch/git-touch/blob/ddfa9e469e5be888aef32b8b13fa09dac079f69c/lib/widgets/timeline_item.dart#L456 Is there any specific reason why you've used typecasts? If typecasting is necessary then https://github.com/git-touch/git-touch/blob/ddfa9e469e5be888aef32b8b13fa09dac079f69c/lib/widgets/timeline_item.dart#L456 will have to be modified to `GIssueData_repository_issueOrPullRequest__asPullRequest_timelineItems_nodes__asReviewRequestedEvent_requestedReviewer__asUser` as the cast. I'll add a fix based on which you suggest is better
GiteaMirror commented 2026-04-27 18:28:59 -05:00
Author
Owner
Copy Link

@pd4d10 commented on GitHub (Jun 17, 2021):

Yeah, I guess it's just an issue of type. It should be enough to just correct the type (and make sure it doesn't break other places, of course)

<!-- gh-comment-id:863369925 --> @pd4d10 commented on GitHub (Jun 17, 2021): Yeah, I guess it's just an issue of type. It should be enough to just correct the type (and make sure it doesn't break other places, of course)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
gitea
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/git-touch#2306
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?