[PR #52] [MERGED] Splash screen #226

New Issue

GiteaMirror · 2025-10-31T17:07:47-05:00

GiteaMirror commented

2025-10-31 17:07:47 -05:00

📋 Pull Request Information

Original PR: https://github.com/pd4d10/git-touch/pull/52
Author: @shreyas1599
Created: 4/9/2020
Status: ✅ Merged
Merged: 4/10/2020
Merged by: @pd4d10

Base: master ← Head: splash-screen

📝 Commits (2)

c8ece8b [feat] added images for splash screen
36763a5 add 1x resolution image

📊 Changes

5 files changed (+3 additions, -3 deletions)

View changed files

📝 android/app/src/main/res/drawable/launch_background.xml (+3 -3)
➕ android/app/src/main/res/drawable/launch_image.png (+0 -0)
📝 ios/Runner/Assets.xcassets/LaunchImage.imageset/LaunchImage.png (+0 -0)
📝 ios/Runner/Assets.xcassets/LaunchImage.imageset/LaunchImage@2x.png (+0 -0)
📝 ios/Runner/Assets.xcassets/LaunchImage.imageset/LaunchImage@3x.png (+0 -0)

📄 Description

For iOS:
I replaced the default splash screen images with the git-touch icon with three variations of resolution.

For Android:
There are two ways of doing this:

Adding the images in all the mipmap folders with varying densities.
Adding a drawable image.

The first one seems like a better option but for some reason, it doesn't work. The second one worked and that is what I've implemented. Let me know if this is alright.

(Sorry for the extra commit. Forgot to include the 1x resolution image for iOS)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/pd4d10/git-touch/pull/52 **Author:** [@shreyas1599](https://github.com/shreyas1599) **Created:** 4/9/2020 **Status:** ✅ Merged **Merged:** 4/10/2020 **Merged by:** [@pd4d10](https://github.com/pd4d10) **Base:** `master` ← **Head:** `splash-screen` --- ### 📝 Commits (2) - [`c8ece8b`](https://github.com/pd4d10/git-touch/commit/c8ece8bf8b90c7b2ab41d24c217288ca39e9f57d) [feat] added images for splash screen - [`36763a5`](https://github.com/pd4d10/git-touch/commit/36763a5bbb8a6c9055dff883256b06ec442d9882) add 1x resolution image ### 📊 Changes **5 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `android/app/src/main/res/drawable/launch_background.xml` (+3 -3) ➕ `android/app/src/main/res/drawable/launch_image.png` (+0 -0) 📝 `ios/Runner/Assets.xcassets/LaunchImage.imageset/LaunchImage.png` (+0 -0) 📝 `ios/Runner/Assets.xcassets/LaunchImage.imageset/LaunchImage@2x.png` (+0 -0) 📝 `ios/Runner/Assets.xcassets/LaunchImage.imageset/LaunchImage@3x.png` (+0 -0) </details> ### 📄 Description For iOS: I replaced the default splash screen images with the git-touch icon with three variations of resolution. For Android: There are two ways of doing this: 1. Adding the images in all the `mipmap` folders with varying densities. 2. Adding a `drawable` image. The first one seems like a better option but for some reason, it doesn't work. The second one worked and that is what I've implemented. Let me know if this is alright. (Sorry for the extra commit. Forgot to include the 1x resolution image for iOS) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-10-31 17:07:47 -05:00

GiteaMirror closed this issue

2025-10-31 17:07:48 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/git-touch#226