[PR #51] [MERGED] added timeline item events #225

Closed
opened 2025-10-31 17:07:46 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/pd4d10/git-touch/pull/51
Author: @shreyas1599
Created: 4/8/2020
Status: Merged
Merged: 4/8/2020
Merged by: @pd4d10

Base: masterHead: timeline-event-items


📝 Commits (1)

  • 9627994 added timeline item events

📊 Changes

2 files changed (+214 additions, -10 deletions)

View changed files

📝 lib/screens/gh_issue.dart (+106 -2)
📝 lib/widgets/timeline_item.dart (+108 -8)

📄 Description

Fixes #3

  1. CommitCommentThread
  2. PullRequestReviewThread
  3. PullRequestReviewComment

Apart from the above three, I've implemented everything else.
I also updated the LockedEvent to use assignee instead of the now deprecated user.

I'm not exactly sure how to implement these. Aren't these already built by the final widget build? I could just modify the if statement of the final widget build to include the above three events. Would I be right in doing so?


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pd4d10/git-touch/pull/51 **Author:** [@shreyas1599](https://github.com/shreyas1599) **Created:** 4/8/2020 **Status:** ✅ Merged **Merged:** 4/8/2020 **Merged by:** [@pd4d10](https://github.com/pd4d10) **Base:** `master` ← **Head:** `timeline-event-items` --- ### 📝 Commits (1) - [`9627994`](https://github.com/pd4d10/git-touch/commit/9627994c8b97a957a93900d974dce0087c22754a) added timeline item events ### 📊 Changes **2 files changed** (+214 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `lib/screens/gh_issue.dart` (+106 -2) 📝 `lib/widgets/timeline_item.dart` (+108 -8) </details> ### 📄 Description Fixes #3 1. `CommitCommentThread` 2. `PullRequestReviewThread` 3. `PullRequestReviewComment` Apart from the above three, I've implemented everything else. I also updated the `LockedEvent` to use `assignee` instead of the now deprecated `user`. I'm not exactly sure how to implement these. Aren't these already built by the final widget `build`? I could just modify the `if` statement of the final widget `build` to include the above three events. Would I be right in doing so? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-10-31 17:07:46 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/git-touch#225