mirror of
https://github.com/pd4d10/git-touch.git
synced 2026-03-16 04:00:25 -05:00
Handle all event types correctly #2
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/git-touch#2
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @pd4d10 on GitHub (Feb 12, 2019).
News screen shows all events received by current logged in user. Currently only a small part of types are correctly handled, code here:
d152750afb/lib/widgets/event_item.dart (L255-L261)All event types list here:
https://developer.github.com/v3/activity/events/types/#event-types--payloads
TODOs:
@shreyas1599 commented on GitHub (Feb 9, 2020):
@pd4d10 In the news section, only some of the events are visible. Is there any way to modify this so as to verify whether the code I'm writing for the event handlers works as intended? For example, the
FollowEventdoes not appear in my News tab.@pd4d10 commented on GitHub (Feb 9, 2020):
@shreyas1599 Thanks for your contribution!
I've checked the API documentation again:
It seems a strategy of GitHub itself. Perhaps we only need to handle the available types.
@shreyas1599 commented on GitHub (Feb 9, 2020):
@pd4d10 Thanks for pointing this out. I'll complete the available types first. We could write for the unavailable types as well. Users for whom these events appear in their news could file an issue if there's an error in what we've written as we cannot test these.
@shreyas1599 commented on GitHub (Feb 9, 2020):
@pd4d10 I was trying to fill the
LabelEvent. In order to get the name of thelabelI tried adding a JsonSerializableGithubEventLabelclass and extracting the labelnamefrom that. It throws an error. Am I approaching this correctly? Also, should I regenerate thegithub.g.dartfile after running usingflutter packages pub run? I tried that as well. I'm new to this, any help is appreciated. Thanks.@pd4d10 commented on GitHub (Feb 9, 2020):
Yeah, the
.g.dartfile is generated bybuild_runner. Try this script@shreyas1599 commented on GitHub (Apr 7, 2020):
Sorry for replying so late. I'm working on it now. There a lot of events which are either not visible in timelines or are only used to trigger hooks. Should I include only those which appear in the user's timeline?
@Meshellegregory commented on GitHub (Apr 7, 2020):
Not understanding why you sent me this. Explain yourself
Sent from Yahoo Mail for iPhone
On Tuesday, April 7, 2020, 11:13, Shreyas Thirumalai notifications@github.com wrote:
Sorry for replying so late. I'm working on it now. There a lot of events which are either not visible in timelines or are only used to trigger hooks. Should I include only those which appear in the user's timeline?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
@pd4d10 commented on GitHub (Apr 7, 2020):
@shreyas1599 Yeah, I think so. It seems hard and unnecessary to cover all these events.