[GH-ISSUE #6] Add to f-droid #1233

Closed
opened 2026-04-19 13:13:26 -05:00 by GiteaMirror · 37 comments
Owner

Originally created by @532910 on GitHub (Sep 1, 2019).
Original GitHub issue: https://github.com/pd4d10/git-touch/issues/6

Please add it to F-Droid

https://gitlab.com/fdroid/rfp

Originally created by @532910 on GitHub (Sep 1, 2019). Original GitHub issue: https://github.com/pd4d10/git-touch/issues/6 Please add it to F-Droid https://gitlab.com/fdroid/rfp
Author
Owner

@pd4d10 commented on GitHub (Oct 13, 2019):

Good point. We'll try to submit it to F-Droid at next release.

<!-- gh-comment-id:541382047 --> @pd4d10 commented on GitHub (Oct 13, 2019): Good point. We'll try to submit it to F-Droid at next release.
Author
Owner

@linsui commented on GitHub (Dec 26, 2019):

Hi, could I open an rfp so that F-Droid guys will tell if there is any blocker?

<!-- gh-comment-id:568972440 --> @linsui commented on GitHub (Dec 26, 2019): Hi, could I open an rfp so that F-Droid guys will tell if there is any blocker?
Author
Owner

@532910 commented on GitHub (Dec 26, 2019):

Sure!

<!-- gh-comment-id:568986894 --> @532910 commented on GitHub (Dec 26, 2019): Sure!
Author
Owner

@linsui commented on GitHub (Dec 26, 2019):

Here is the rfp. 😄

<!-- gh-comment-id:568990371 --> @linsui commented on GitHub (Dec 26, 2019): [Here](https://gitlab.com/fdroid/rfp/issues/1180) is the rfp. 😄
Author
Owner

@pd4d10 commented on GitHub (Dec 26, 2019):

Thanks! @linsui

Feel free to ping me if I can help.

<!-- gh-comment-id:569016521 --> @pd4d10 commented on GitHub (Dec 26, 2019): Thanks! @linsui Feel free to ping me if I can help.
Author
Owner

@IzzySoft commented on GitHub (Dec 28, 2019):

@pd4d10 here comes the ping… F-Droid maintainer here. Thanks for submitting your app to our catalog! We have a few minor issues which you hopefully can solve with ease:

  • can we have Fastlane file structure in the app's repo? That way there could be screenshots visible in the catalog (client and website) – and you could maintain summary/description to keep them up-to-date. And yes, we'd need some good description, so potential users get an idea why/that they want your app 😉
  • we cannot enable automated update check because (we'd need literal values there for versionName and versionCode as our update checker only RegEx-parses the gradle, it doesn't execute it). Would it be hard to match that?

Once that's available (and a new tag covering it), I'd set up metadata and push it to our packagers. Thanks again!

<!-- gh-comment-id:569448010 --> @IzzySoft commented on GitHub (Dec 28, 2019): @pd4d10 here comes the ping… F-Droid maintainer here. Thanks for submitting your app to our catalog! We have a few minor issues which you hopefully can solve with ease: * can we have [Fastlane file structure](https://gitlab.com/snippets/1895688) in the app's repo? That way there could be screenshots visible in the catalog (client and website) – and you could maintain summary/description to keep them up-to-date. And yes, we'd need some good description, so potential users get an idea why/that they want your app :wink: * we cannot enable automated update check [because](https://github.com/pd4d10/git-touch/blob/v1.1.0/android/app/build.gradle#L44) (we'd need literal values there for `versionName` and `versionCode` as our update checker only RegEx-parses the gradle, it doesn't execute it). Would it be hard to match that? Once that's available (and a new tag covering it), I'd set up metadata and push it to our packagers. Thanks again!
Author
Owner

@pd4d10 commented on GitHub (Dec 29, 2019):

Hi, @IzzySoft, Thanks for your quick response!

I'll check these issues you mentioned ASAP.

Would F-Droid build the release APK from source, or just take it from Google Play or GitHub release?

<!-- gh-comment-id:569479393 --> @pd4d10 commented on GitHub (Dec 29, 2019): Hi, @IzzySoft, Thanks for your quick response! I'll check these issues you mentioned ASAP. Would F-Droid build the release APK from source, or just take it from Google Play or GitHub release?
Author
Owner

@linsui commented on GitHub (Dec 29, 2019):

F-Droid build the release APK from source.

<!-- gh-comment-id:569479476 --> @linsui commented on GitHub (Dec 29, 2019): F-Droid build the release APK from source.
Author
Owner

@IzzySoft commented on GitHub (Dec 29, 2019):

As @linsui wrote: F-Droid builds from source only, no "blobs" permitted (i.e. also no .aar or .jar files – everything must be built from source, including all dependencies. A few trusted Maven repos are the exception as they have been "verified" and ship the source they built from along).

That's for the main repo. There's also my repo, which acts as kind of between "staging" and "non-free". I take the APKs provided by the developers – usually attached to releases. Apps in my repo are either "on their way" to the official one (still have some minor issues to solve in order to meet the much stronger criteria there), or cannot fully meet the criteria but are still "acceptable" in a way (i.e. not too many trackers/proprietary dependencies, so "mostly FOSS" with a FOSS license).

<!-- gh-comment-id:569499240 --> @IzzySoft commented on GitHub (Dec 29, 2019): As @linsui wrote: F-Droid builds from source only, no "blobs" permitted (i.e. also no `.aar` or `.jar` files – **everything** must be built from source, including all dependencies. A few trusted Maven repos are the exception as they have been "verified" and ship the source they built from along). That's for the main repo. There's also [my repo](https://apt.izzysoft.de/fdroid), which acts as kind of between "staging" and "non-free". I take the APKs provided by the developers – usually attached to releases. Apps in my repo are either "on their way" to the official one (still have some minor issues to solve in order to meet the much stronger criteria there), or cannot fully meet the criteria but are still "acceptable" in a way (i.e. not too many trackers/proprietary dependencies, so "mostly FOSS" with a FOSS license).
Author
Owner

@IzzySoft commented on GitHub (Mar 14, 2020):

@pd4d10 any news on this? The corresponding RFP is still stalled…

<!-- gh-comment-id:599145910 --> @IzzySoft commented on GitHub (Mar 14, 2020): @pd4d10 any news on this? The corresponding RFP is still stalled…
Author
Owner

@TheEvilSkeleton commented on GitHub (Oct 13, 2020):

I'm wondering the same. It hasn't been active for a while

<!-- gh-comment-id:707405677 --> @TheEvilSkeleton commented on GitHub (Oct 13, 2020): I'm wondering the same. It hasn't been active for a while
Author
Owner

@IzzySoft commented on GitHub (Oct 13, 2020):

@pd4d10 are you still on this? First anniversary of your initial commitment. A good time to get this done, don't you agree? 😃

<!-- gh-comment-id:707409110 --> @IzzySoft commented on GitHub (Oct 13, 2020): @pd4d10 are you still on this? First anniversary of your initial commitment. A good time to get this done, don't you agree? :smiley:
Author
Owner

@pd4d10 commented on GitHub (Oct 13, 2020):

Oh, sorry for the long wait. I got stuck last time.

Is there any app which is also built with Flutter at f-droid? Perhaps I could refer to some of them.

<!-- gh-comment-id:707444915 --> @pd4d10 commented on GitHub (Oct 13, 2020): Oh, sorry for the long wait. I got stuck last time. Is there any app which is also built with Flutter at f-droid? Perhaps I could refer to some of them.
Author
Owner
<!-- gh-comment-id:707446769 --> @linsui commented on GitHub (Oct 13, 2020): https://gitlab.com/fdroid/rfp/-/issues?scope=all&utf8=%E2%9C%93&state=all&label_name[]=flutter
Author
Owner

@IzzySoft commented on GitHub (Jan 8, 2021):

So are you still on it here? I was just about to close the RFP as there was no activity for a year, despite my ping 9 months ago.

I got stuck last time.

And now you are unstuck, @pd4d10? 🙊 I mean, is anything going on – your comment was 3 months ago? Just a friendly heads-up with the question whether we shall keep the RFP open 😉

<!-- gh-comment-id:757033357 --> @IzzySoft commented on GitHub (Jan 8, 2021): So are you still on it here? I was just about to close the RFP as there was no activity for a year, despite my ping 9 months ago. > I got stuck last time. And now you are unstuck, @pd4d10? :speak_no_evil: I mean, is anything going on – your comment was 3 months ago? Just a friendly heads-up with the question whether we shall keep the RFP open :wink:
Author
Owner

@pd4d10 commented on GitHub (Jan 9, 2021):

Oh, sorry about that. Still didn't figure it out. The RFP could be kept open if it is not in a hurry.

BTW, I'm very glad to accept a PR if someone could help...

<!-- gh-comment-id:757086039 --> @pd4d10 commented on GitHub (Jan 9, 2021): Oh, sorry about that. Still didn't figure it out. The RFP could be kept open if it is not in a hurry. BTW, I'm very glad to accept a PR if someone could help...
Author
Owner

@IzzySoft commented on GitHub (Jan 9, 2021):

I'm not an app dev, so I won't be able to help with that, sorry. But you could ask eg. at the forum, on IRC or Matrix.

The RFP will be kept open at least until my next triage run I guess. But if something sits for years and cannot be addressed, it just makes the backlog huge and the tracker hard to handle, so at some point we tend to close it with the hint to "please come back when YOU are ready"…

<!-- gh-comment-id:757089444 --> @IzzySoft commented on GitHub (Jan 9, 2021): I'm not an app dev, so I won't be able to help with that, sorry. But you could ask eg. at the forum, on IRC or Matrix. The RFP will be kept open at least until my next triage run I guess. But if something sits for years and cannot be addressed, it just makes the backlog huge and the tracker hard to handle, so at some point we tend to close it with the hint to "please come back when YOU are ready"…
Author
Owner

@pd4d10 commented on GitHub (Jan 9, 2021):

Fair enough. How about:

  1. Close the RFP for now, and reopen it again when we get ready
  2. Keep this issue open for progress updating

What do you think @linsui

<!-- gh-comment-id:757092742 --> @pd4d10 commented on GitHub (Jan 9, 2021): Fair enough. How about: 1. Close the RFP for now, and reopen it again when we get ready 2. Keep this issue open for progress updating What do you think @linsui
Author
Owner

@linsui commented on GitHub (Jan 9, 2021):

I'm also not a dev so I can't help here. But maybe I can prepare a pr for the fastlane later. And how about give it a try using this one as a template? It's also a flutter app and use HTTP for update check. Maybe I can do that this weekend and if I'm lucky it will be built by the CI.

<!-- gh-comment-id:757095552 --> @linsui commented on GitHub (Jan 9, 2021): I'm also not a dev so I can't help here. But maybe I can prepare a pr for the fastlane later. And how about give it a try using [this one](https://gitlab.com/fdroid/fdroiddata/-/merge_requests/8087/diffs) as a template? It's also a flutter app and use HTTP for update check. Maybe I can do that this weekend and if I'm lucky it will be built by the CI.
Author
Owner

@linsui commented on GitHub (Jan 9, 2021):

It builds fine, and a pr is filed here . The pr for the fastlane is here.

<!-- gh-comment-id:757119194 --> @linsui commented on GitHub (Jan 9, 2021): It builds fine, and a pr is filed [here](https://gitlab.com/fdroid/fdroiddata/-/merge_requests/8089) . The pr for the fastlane is [here](https://github.com/git-touch/git-touch/pull/154).
Author
Owner

@IzzySoft commented on GitHub (Jan 9, 2021):

That indeed looks very good – thanks a lot, @linsui! May I suggest…

  • @pd4d10 merges the Fastlane PR,
  • then tags a new version (not necessarily immediately, not not too much delayed)
  • then @linsui updates the MR to that new tag and gives me a ping from there once the build is green again
  • I pick up the MR for verification & test, then merge it
  • within a week later, git-touch becomes available at F-Droid

How does that plan sound? 😃

At some point (either before this tag or with a later update) you might wish to add screenshots to fastlane, though. You know, images speak louder than words and all that 😉

<!-- gh-comment-id:757211818 --> @IzzySoft commented on GitHub (Jan 9, 2021): That indeed looks very good – thanks a lot, @linsui! May I suggest… * @pd4d10 merges the Fastlane PR, * then tags a new version (not necessarily immediately, not not too much delayed) * then @linsui updates the MR to that new tag and gives me a ping from there once the build is green again * I pick up the MR for verification & test, then merge it * within a week later, git-touch becomes available at F-Droid How does that plan sound? :smiley: At some point (either before this tag or with a later update) you might wish to add screenshots to fastlane, though. You know, images speak louder than words and all that :wink:
Author
Owner

@pd4d10 commented on GitHub (Jan 9, 2021):

@linsui Thanks a lot!

@IzzySoft Sounds great. PR merged. Will draft a new release this week

<!-- gh-comment-id:757333814 --> @pd4d10 commented on GitHub (Jan 9, 2021): @linsui Thanks a lot! @IzzySoft Sounds great. PR merged. Will draft a new release this week
Author
Owner

@pd4d10 commented on GitHub (Jan 9, 2021):

There are already some screenshots in the assets folder, but I'm not sure if they meet the needs.

<!-- gh-comment-id:757334127 --> @pd4d10 commented on GitHub (Jan 9, 2021): There are already some screenshots in the [assets folder](https://github.com/git-touch/git-touch/tree/main/assets), but I'm not sure if they meet the needs.
Author
Owner

@IzzySoft commented on GitHub (Jan 9, 2021):

Yes, you could place them in fastlane/metadata/android/en-US/images/phoneScreenshots (not the Google Play badge, of course 😉).

Personal note: I usually recommend not to "frame" screenshots. Might look fancy on large screens, but wastes valuable space especially on devices with 5" or smaller screens. Not that bad with your screenshots here – but I've seen some where the "real screenshot" was less than 1/3 of the entire picture…

<!-- gh-comment-id:757338148 --> @IzzySoft commented on GitHub (Jan 9, 2021): Yes, you could place them in `fastlane/metadata/android/en-US/images/phoneScreenshots` (not the Google Play badge, of course :wink:). Personal note: I usually recommend not to "frame" screenshots. Might look fancy on large screens, but wastes valuable space especially on devices with 5" or smaller screens. Not that bad with your screenshots here – but I've seen some where the "real screenshot" was less than 1/3 of the entire picture…
Author
Owner

@pd4d10 commented on GitHub (Jan 10, 2021):

Hi, @IzzySoft , A new tag v1.11.0 is released to test this process.

<!-- gh-comment-id:757461248 --> @pd4d10 commented on GitHub (Jan 10, 2021): Hi, @IzzySoft , A new tag [v1.11.0](https://github.com/git-touch/git-touch/releases/tag/v1.11.0) is released to test this process.
Author
Owner

@linsui commented on GitHub (Jan 10, 2021):

Thanks! It is built.

<!-- gh-comment-id:757465082 --> @linsui commented on GitHub (Jan 10, 2021): Thanks! It is built.
Author
Owner

@IzzySoft commented on GitHub (Jan 10, 2021):

Yes, builds fine. But unfortunately cannot be merged. For your convenience, the essence repeated here:

Libraries detected:
-------------------
* Android Support v4 (/android/support/v4): Development Framework
* Androidx Core (/androidx/core): Utility
* Lifecycle (/androidx/lifecycle): Utility
* Webkit (/androidx/webkit): Utility
* Google Play Core (/com/google/android/play/core): Utility NonFreeNet,NonFreeDep
* Flutter (/io/flutter): Development Framework
* Share plugin (/io/flutter/plugins/share): Utility
* url_launcher (/io/flutter/plugins/urllauncher): Utility
* Webkit Boundary Interfaces (/org/chromium/support_lib_boundary): Utility

Offending libs:
---------------
* Google Play Core (/com/google/android/play/core): NonFreeNet,NonFreeDep

1 offenders.

Google Play Core has a proprietary license and thus is not acceptable by F-Droid. Not sure what's dragging that in, though.

<!-- gh-comment-id:757505736 --> @IzzySoft commented on GitHub (Jan 10, 2021): Yes, builds fine. But unfortunately [cannot be merged](https://gitlab.com/fdroid/fdroiddata/-/merge_requests/8089#note_482079794). For your convenience, the essence repeated here: ``` Libraries detected: ------------------- * Android Support v4 (/android/support/v4): Development Framework * Androidx Core (/androidx/core): Utility * Lifecycle (/androidx/lifecycle): Utility * Webkit (/androidx/webkit): Utility * Google Play Core (/com/google/android/play/core): Utility NonFreeNet,NonFreeDep * Flutter (/io/flutter): Development Framework * Share plugin (/io/flutter/plugins/share): Utility * url_launcher (/io/flutter/plugins/urllauncher): Utility * Webkit Boundary Interfaces (/org/chromium/support_lib_boundary): Utility Offending libs: --------------- * Google Play Core (/com/google/android/play/core): NonFreeNet,NonFreeDep 1 offenders. ``` *Google Play Core* has a proprietary license and thus is not acceptable by F-Droid. Not sure what's dragging that in, though.
Author
Owner

@pd4d10 commented on GitHub (Jan 10, 2021):

Looks wired... Do other Flutter apps have this issue?

<!-- gh-comment-id:757509246 --> @pd4d10 commented on GitHub (Jan 10, 2021): Looks wired... Do other Flutter apps have this issue?
Author
Owner

@IzzySoft commented on GitHub (Jan 11, 2021):

None of the others I've processed so far, no. And no obvious candidate that might have it as dependency. AFAIK there was some tool listing dependencies, I saw the output as ASCII tree a few times – but I don't know which one that was. I only remember it sounded like being available from within the SDK, like some flutter --doSomething, should have made a note… If I should make a guess, I'd suspect Chromium having Google glue. But not necessarily to Play Core. So share or url_launcher? Hm. Anything that wants to access Play Ratings, or refer to some app at Play?

Looking at your pubspec.yaml:

dependencies:
 ..
 in_app_review: ^1.0.4

What's that? Leave a review at Play? If so, there you have the most likely candidate.

<!-- gh-comment-id:757584271 --> @IzzySoft commented on GitHub (Jan 11, 2021): None of the others I've processed so far, no. And no obvious candidate that might have it as dependency. AFAIK there was some tool listing dependencies, I saw the output as ASCII tree a few times – but I don't know which one that was. I only remember it sounded like being available from within the SDK, like some `flutter --doSomething`, should have made a note… If I should make a guess, I'd suspect Chromium having Google glue. But not necessarily to Play Core. So share or url_launcher? Hm. Anything that wants to access Play Ratings, or refer to some app at Play? Looking at your `pubspec.yaml`: ```yaml dependencies: .. in_app_review: ^1.0.4 ``` What's that? Leave a review at Play? If so, there you have the most likely candidate.
Author
Owner

@pd4d10 commented on GitHub (Jan 11, 2021):

Oh. That's it, thanks!

v1.11.1 is released with this package dropped

<!-- gh-comment-id:757592765 --> @pd4d10 commented on GitHub (Jan 11, 2021): Oh. That's it, thanks! [v1.11.1](https://github.com/git-touch/git-touch/releases/tag/v1.11.0) is released with this package dropped
Author
Owner

@IzzySoft commented on GitHub (Jan 11, 2021):

Gladly! Let's hope that killed the c… ahem… flag (ugh!) As a side-effect the APK will be a little smaller now as well 😆 Will check that probably tomorrow. Almost 4am again already…

<!-- gh-comment-id:757598299 --> @IzzySoft commented on GitHub (Jan 11, 2021): Gladly! Let's hope that killed the c… ahem… flag (ugh!) As a side-effect the APK will be a little smaller now as well :laughing: Will check that probably tomorrow. Almost 4am again already…
Author
Owner

@IzzySoft commented on GitHub (Jan 11, 2021):

Short relieve note (I already played at the proverb of "curiousity killed the cat" – but luckily it is known to have multiple lives 😉) so we all get a good nights sleep now:

Libraries detected:
-------------------
* Android Support v4 (/android/support/v4): Development Framework
* Androidx Core (/androidx/core): Utility
* Lifecycle (/androidx/lifecycle): Utility
* Webkit (/androidx/webkit): Utility
* Flutter (/io/flutter): Development Framework
* Share plugin (/io/flutter/plugins/share): Utility
* url_launcher (/io/flutter/plugins/urllauncher): Utility
* Webkit Boundary Interfaces (/org/chromium/support_lib_boundary): Utility

No offending libs found.

That did it! Will review the MR tomorrow and expect no further stoppers, so expect it being merged and available at F-Droid within a week if all works out fine. Thanks a lot!

<!-- gh-comment-id:757599963 --> @IzzySoft commented on GitHub (Jan 11, 2021): Short relieve note (I already played at the proverb of "curiousity killed the cat" – but luckily it is known to have multiple lives :wink:) so we all get a good nights sleep now: ``` Libraries detected: ------------------- * Android Support v4 (/android/support/v4): Development Framework * Androidx Core (/androidx/core): Utility * Lifecycle (/androidx/lifecycle): Utility * Webkit (/androidx/webkit): Utility * Flutter (/io/flutter): Development Framework * Share plugin (/io/flutter/plugins/share): Utility * url_launcher (/io/flutter/plugins/urllauncher): Utility * Webkit Boundary Interfaces (/org/chromium/support_lib_boundary): Utility No offending libs found. ``` That did it! Will review the MR tomorrow and expect no further stoppers, so expect it being merged and available at F-Droid within a week if all works out fine. Thanks a lot!
Author
Owner

@IzzySoft commented on GitHub (Jan 11, 2021):

Merged, as expected. Though I was unable to test it with Github: entering the OAUTH token and pressing the button just resulted in a

Something bad happens: NoSuchMethodError: The method '[]' was called on null…

GitLab however worked, so I used that to check. Don't have accounts on all services offered, and a full function test isn't part of the review anyhow.

So: Welcome aboard! As already said in my last comment, within a week GitPoint should become availabe at F-Droid now. Congrats!

<!-- gh-comment-id:757860924 --> @IzzySoft commented on GitHub (Jan 11, 2021): Merged, as expected. Though I was unable to test it with Github: entering the OAUTH token and pressing the button just resulted in a Something bad happens: NoSuchMethodError: The method '[]' was called on null… GitLab however worked, so I used that to check. Don't have accounts on all services offered, and a full function test isn't part of the review anyhow. So: Welcome aboard! As already said in my last comment, within a week GitPoint should become availabe at F-Droid now. Congrats!
Author
Owner

@IzzySoft commented on GitHub (Jan 11, 2021):

Ah, there was that dependency command I mentioned before: gradle :app:dependencies. Duly noted now 😃

<!-- gh-comment-id:757863964 --> @IzzySoft commented on GitHub (Jan 11, 2021): Ah, there was that dependency command I mentioned before: `gradle :app:dependencies`. Duly noted now :smiley:
Author
Owner

@pd4d10 commented on GitHub (Feb 14, 2021):

Hi, @IzzySoft , I want to add an F-Droid badge to README, here along with AppStore and Google Play.

This badge's transparent padding looks a little wide. Do we have a more compact one? Thanks!

<!-- gh-comment-id:778806444 --> @pd4d10 commented on GitHub (Feb 14, 2021): Hi, @IzzySoft , I want to add an F-Droid badge to README, [here](https://github.com/git-touch/git-touch#readme) along with AppStore and Google Play. [This badge](https://f-droid.org/en/2016/05/29/get-it-on-f-droid-badges.html)'s transparent padding looks a little wide. Do we have a more compact one? Thanks!
Author
Owner

@IzzySoft commented on GitHub (Feb 14, 2021):

No idea. You could follow the link to the artwork collection, pick an SVG, and adjust it to your needs I guess?

<!-- gh-comment-id:778845689 --> @IzzySoft commented on GitHub (Feb 14, 2021): No idea. You could follow the link to the [artwork collection](https://gitlab.com/fdroid/artwork/tree/master/badge), pick an SVG, and adjust it to your needs I guess?
Author
Owner

@pd4d10 commented on GitHub (Feb 15, 2021):

OK, thanks for the quick response. This one should work. Added

<!-- gh-comment-id:778899212 --> @pd4d10 commented on GitHub (Feb 15, 2021): OK, thanks for the quick response. [This one](https://upload.wikimedia.org/wikipedia/commons/9/96/%22Get_it_on_F-droid%22_Badge.png) should work. [Added](https://github.com/git-touch/git-touch#readme)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/git-touch#1233