github-starred/git-touch
2
0
Fork 0
mirror of https://github.com/pd4d10/git-touch.git synced 2026-03-11 17:49:27 -05:00
Code Issues 88 Packages Projects Releases 18 Wiki Activity

GitHub files page error #114

New Issue
Closed
opened 2025-10-31 17:05:57 -05:00 by GiteaMirror · 4 comments
GiteaMirror commented 2025-10-31 17:05:57 -05:00
Owner
Copy Link

Originally created by @shreyas1599 on GitHub (Feb 1, 2021).

I noticed this a while back. Forgot to get to it. Opening an issue in case I forget again.

Screenshot_20210201-205829.png

Originally created by @shreyas1599 on GitHub (Feb 1, 2021). I noticed this a while back. Forgot to get to it. Opening an issue in case I forget again. ![Screenshot_20210201-205829.png](https://user-images.githubusercontent.com/28999492/106479718-a1797980-64d0-11eb-8598-2ce14a061cfa.png)
GiteaMirror commented 2025-10-31 17:05:57 -05:00
Author
Owner
Copy Link

@shreyas1599 commented on GitHub (Feb 2, 2021):

This seems to be a problem of HighlightView. This is the offending line. When patch is null as is the case with the above screenshot, the error occurs.

@shreyas1599 commented on GitHub (Feb 2, 2021): This seems to be a problem of `HighlightView`. [This](https://github.com/git-touch/highlight/blob/251505aae568e95ad941e023c110495fa5ad0a16/flutter_highlight/lib/flutter_highlight.dart#L37) is the offending line. When `patch` is null as is the case with the above screenshot, the error occurs.
GiteaMirror commented 2025-10-31 17:05:58 -05:00
Author
Owner
Copy Link

@shreyas1599 commented on GitHub (Feb 2, 2021):

I can catch it in files_item.dart itself but I think it would be better for the package to handle null.

@shreyas1599 commented on GitHub (Feb 2, 2021): I can catch it in `files_item.dart` itself but I think it would be better for the package to handle null.
GiteaMirror commented 2025-10-31 17:05:58 -05:00
Author
Owner
Copy Link

@shreyas1599 commented on GitHub (Feb 2, 2021):

I'm thinking of replacing this line with patch ?? "No text to be shown here" or should I just leave it as an empty string. I think the first option is better because github returns a null patch only if the file has binary data. What do you think @pd4d10 ?

@shreyas1599 commented on GitHub (Feb 2, 2021): I'm thinking of replacing [this line](https://github.com/git-touch/git-touch/blob/918d0f3971b80fba411143a6bf1d3705eb1e4abb/lib/widgets/files_item.dart#L44) with `patch ?? "No text to be shown here"` or should I just leave it as an empty string. I think the first option is better because github returns a null patch only if the file has binary data. What do you think @pd4d10 ?
GiteaMirror commented 2025-10-31 17:05:58 -05:00
Author
Owner
Copy Link

@pd4d10 commented on GitHub (Feb 2, 2021):

OK. I have no strong preference for this, as long as it is easy to understand for users.

@pd4d10 commented on GitHub (Feb 2, 2021): OK. I have no strong preference for this, as long as it is easy to understand for users.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
gitea
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/git-touch#114
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?