dextmorgn 441de48264 fix(mypy): finish the ratchet backlog — permissions, dockertool, alembic ...

Last batch of real fixes plus one more scoped override:

- DockerTool.get_image() read cls.image as a class attribute, but
  __init__ only ever sets it on the instance (self.image = ...) — real
  bug (would AttributeError if get_image() were ever called before an
  instance existed with a subclass not also declaring image at class
  level). Declared `image: str` on the base to document what's
  actually relied on: subclasses set it as a class attribute, __init__
  shadows it per-instance with the tagged form.
- ReconCrawlTool.version() was declared -> str but its body was a bare
  `pass` (returns None) — no callers exist, so raises NotImplementedError
  with a comment instead of guessing a fake version string.
- ReconCrawlTool.launch()'s args param defaulted to None but the body
  calls args.get(...) unconditionally — real crash risk if ever called
  without args (never observed since the one caller always passes a
  dict), guarded with `args = args or {}`.
- Extended flowsint-core's tests.* override (assignment, override) for
  the same InputType/OutputType-pattern reason as the existing entries:
  MockEnricher/ResolveEnricher fixtures reassign InputType/OutputType
  and vary scan()/postprocess() signatures per the documented pattern,
  same as production enrichers.
- permissions.py, alembic/env.py, and one alembic migration's untyped
  params/standard-boilerplate arg-type gaps.

Ratchet is now clean except the accepted import-untyped debt (86
errors — cross-package imports needing py.typed markers project-wide,
deliberately out of scope: adding them earlier in this branch
ballooned the count from 478 to 1423 by unmasking the full ~2200
pre-existing backlog instead of shrinking it).

Verified: all 4 packages' test suites pass (397 + 32 + 6 + 54).

2026-08-25 09:33:36 +02:00

..

permissions.py

fix(mypy): finish the ratchet backlog — permissions, dockertool, alembic

2026-08-25 09:33:36 +02:00