[PR #205] [MERGED] Harden navbar external links #4125

Closed
opened 2026-08-30 17:53:28 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/reconurge/flowsint/pull/205
Author: @Ghraven
Created: 8/4/2026
Status: ✅ Merged
Merged: 8/5/2026
Merged by: @dextmorgn

Base: main ← Head: fix/navbar-external-link-rel


📝 Commits (1)

  • 7f81ab4 Harden navbar external links

📊 Changes

1 file changed (+7 additions, -1 deletions)

View changed files

📝 flowsint-app/src/components/layout/top-navbar.tsx (+7 -1)

📄 Description

Problem

Two external links in the dashboard navbar open with target="_blank" but do not set a rel attribute. Other external links in the app already use rel="noopener noreferrer", so these two were inconsistent with the safer pattern.

Before / after

Before, the GitHub and Support dropdown links opened a new tab without explicitly isolating the opener context.

After, both links include rel="noopener noreferrer", matching the rest of the app's external-link handling.

Verification

  • ../node_modules/.bin/prettier.cmd --check src/components/layout/top-navbar.tsx
  • git diff --check

I also tried npm run typecheck, but it currently fails on unrelated existing TypeScript errors across the app, including missing @tiptap/react/menus, missing @tiptap/markdown, and several pre-existing implicit-any/unused import errors outside this navbar file.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/reconurge/flowsint/pull/205 **Author:** [@Ghraven](https://github.com/Ghraven) **Created:** 8/4/2026 **Status:** ✅ Merged **Merged:** 8/5/2026 **Merged by:** [@dextmorgn](https://github.com/dextmorgn) **Base:** `main` ← **Head:** `fix/navbar-external-link-rel` --- ### 📝 Commits (1) - [`7f81ab4`](https://github.com/reconurge/flowsint/commit/7f81ab499e702f4b1c21b9df89d7bedd4735f9b1) Harden navbar external links ### 📊 Changes **1 file changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `flowsint-app/src/components/layout/top-navbar.tsx` (+7 -1) </details> ### 📄 Description ## Problem Two external links in the dashboard navbar open with `target="_blank"` but do not set a `rel` attribute. Other external links in the app already use `rel="noopener noreferrer"`, so these two were inconsistent with the safer pattern. ## Before / after Before, the GitHub and Support dropdown links opened a new tab without explicitly isolating the opener context. After, both links include `rel="noopener noreferrer"`, matching the rest of the app's external-link handling. ## Verification - `../node_modules/.bin/prettier.cmd --check src/components/layout/top-navbar.tsx` - `git diff --check` I also tried `npm run typecheck`, but it currently fails on unrelated existing TypeScript errors across the app, including missing `@tiptap/react/menus`, missing `@tiptap/markdown`, and several pre-existing implicit-any/unused import errors outside this navbar file. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-08-30 17:53:28 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/flowsint#4125