github-starred/flowsint
2
0
Fork 0
mirror of https://github.com/reconurge/flowsint.git synced 2026-07-11 13:35:22 -05:00
Code Issues 880 Packages Projects Releases 13 Wiki Activity

[PR #155] [MERGED] fix: use aware timestamp for investigation updates #3420

New Issue
Closed
opened 2026-06-18 17:30:16 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-18 17:30:16 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/reconurge/flowsint/pull/155
Author: @Ghraven
Created: 6/3/2026
Status: ✅ Merged
Merged: 6/3/2026
Merged by: @dextmorgn

Base: main ← Head: fix-investigation-aware-timestamp

📝 Commits (1)

  • 60cfa16 fix: use aware timestamp for investigation updates

📊 Changes

2 files changed (+27 additions, -2 deletions)

View changed files

📝 flowsint-core/src/flowsint_core/core/services/investigation_service.py (+2 -2)
📝 flowsint-core/tests/services/test_timezone_timestamps.py (+25 -0)

📄 Description

Summary

  • use datetime.now(timezone.utc) when updating an investigation timestamp
  • extend the timezone timestamp regression tests to cover InvestigationService.update()

Before / after

Before, InvestigationService.update() assigned last_updated_at with a naive UTC datetime.utcnow() value, while nearby service timestamp paths now use timezone-aware UTC values.

After, investigation updates store an aware UTC datetime, keeping the service layer consistent.

Verification

  • python -m py_compile flowsint-core\src\flowsint_core\core\services\investigation_service.py flowsint-core\tests\services\test_timezone_timestamps.py

I also attempted python -m pytest flowsint-core\tests\services\test_timezone_timestamps.py. With PYTHONPATH=flowsint-core\src, collection reached project imports but stopped because this local workspace is missing passlib.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/reconurge/flowsint/pull/155 **Author:** [@Ghraven](https://github.com/Ghraven) **Created:** 6/3/2026 **Status:** ✅ Merged **Merged:** 6/3/2026 **Merged by:** [@dextmorgn](https://github.com/dextmorgn) **Base:** `main` ← **Head:** `fix-investigation-aware-timestamp` --- ### 📝 Commits (1) - [`60cfa16`](https://github.com/reconurge/flowsint/commit/60cfa16b8df674b72b567f43990d19d3b849df66) fix: use aware timestamp for investigation updates ### 📊 Changes **2 files changed** (+27 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `flowsint-core/src/flowsint_core/core/services/investigation_service.py` (+2 -2) 📝 `flowsint-core/tests/services/test_timezone_timestamps.py` (+25 -0) </details> ### 📄 Description ## Summary - use `datetime.now(timezone.utc)` when updating an investigation timestamp - extend the timezone timestamp regression tests to cover `InvestigationService.update()` ## Before / after Before, `InvestigationService.update()` assigned `last_updated_at` with a naive UTC `datetime.utcnow()` value, while nearby service timestamp paths now use timezone-aware UTC values. After, investigation updates store an aware UTC datetime, keeping the service layer consistent. ## Verification - `python -m py_compile flowsint-core\src\flowsint_core\core\services\investigation_service.py flowsint-core\tests\services\test_timezone_timestamps.py` I also attempted `python -m pytest flowsint-core\tests\services\test_timezone_timestamps.py`. With `PYTHONPATH=flowsint-core\src`, collection reached project imports but stopped because this local workspace is missing `passlib`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-18 17:30:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
duplicate
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/flowsint#3420
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?