[PR #150] [MERGED] fix: read social enricher outputs as utf-8 #2446

New Issue

GiteaMirror · 2026-06-04T23:25:28-05:00

GiteaMirror commented

2026-06-04 23:25:28 -05:00

📋 Pull Request Information

Original PR: https://github.com/reconurge/flowsint/pull/150
Author: @Ghraven
Created: 5/31/2026
Status: ✅ Merged
Merged: 6/2/2026
Merged by: @dextmorgn

Base: main ← Head: fix-social-enricher-output-encoding

📝 Commits (1)

4e14df6 fix: read social enricher outputs as utf-8

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 flowsint-enrichers/src/flowsint_enrichers/social/to_maigret.py (+1 -1)
📝 flowsint-enrichers/src/flowsint_enrichers/social/to_sherlock.py (+1 -1)

📄 Description

What changed

Reads Sherlock text output with explicit encoding="utf-8".
Reads Maigret JSON output with explicit encoding="utf-8".

Problem

The social enrichers parse CLI-generated text/JSON files without specifying an encoding. On machines whose default locale is not UTF-8, usernames, platform metadata, or URLs containing non-ASCII characters can be decoded inconsistently or fail during parsing.

Before/after

Before: Sherlock and Maigret output parsing used the platform default encoding.
After: both output parsers read their files as UTF-8, matching the common encoding used by these tools and making behavior consistent across environments.

Verification

python -m py_compile flowsint-enrichers/src/flowsint_enrichers/social/to_sherlock.py flowsint-enrichers/src/flowsint_enrichers/social/to_maigret.py

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/reconurge/flowsint/pull/150 **Author:** [@Ghraven](https://github.com/Ghraven) **Created:** 5/31/2026 **Status:** ✅ Merged **Merged:** 6/2/2026 **Merged by:** [@dextmorgn](https://github.com/dextmorgn) **Base:** `main` ← **Head:** `fix-social-enricher-output-encoding` --- ### 📝 Commits (1) - [`4e14df6`](https://github.com/reconurge/flowsint/commit/4e14df6c615c699fbc3483a17aba53d0150ffa75) fix: read social enricher outputs as utf-8 ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `flowsint-enrichers/src/flowsint_enrichers/social/to_maigret.py` (+1 -1) 📝 `flowsint-enrichers/src/flowsint_enrichers/social/to_sherlock.py` (+1 -1) </details> ### 📄 Description ## What changed - Reads Sherlock text output with explicit `encoding="utf-8"`. - Reads Maigret JSON output with explicit `encoding="utf-8"`. ## Problem The social enrichers parse CLI-generated text/JSON files without specifying an encoding. On machines whose default locale is not UTF-8, usernames, platform metadata, or URLs containing non-ASCII characters can be decoded inconsistently or fail during parsing. ## Before/after Before: Sherlock and Maigret output parsing used the platform default encoding. After: both output parsers read their files as UTF-8, matching the common encoding used by these tools and making behavior consistent across environments. ## Verification - `python -m py_compile flowsint-enrichers/src/flowsint_enrichers/social/to_sherlock.py flowsint-enrichers/src/flowsint_enrichers/social/to_maigret.py` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-06-04 23:25:28 -05:00

GiteaMirror closed this issue

2026-06-04 23:25:30 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/flowsint#2446