[PR #140] [CLOSED] Fix review issues in setup/deploy/start automation scripts #1127

New Issue

2026-05-03T01:59:45-05:00

GiteaMirror commented

2026-05-03 01:59:45 -05:00

📋 Pull Request Information

Original PR: https://github.com/reconurge/flowsint/pull/140
Author: @Abdullakala
Created: 4/24/2026
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (3)

fd1f24f chore: add setup/install/deploy/start automation and update app/core changes
292c7ed chore: add handoff bundle scripts and artifacts
cb6ba48 fix: address PR review comments for setup/deploy/start scripts

📊 Changes

30 files changed (+5993 additions, -27 deletions)

View changed files

➕ COMMANDS.makefile (+264 -0)
➕ FILES_INDEX.md (+427 -0)
➕ QUICK_REFERENCE.sh (+385 -0)
➕ SETUP_DEPLOYMENT_GUIDE.md (+368 -0)
➕ agent_handoff_bundle.sh (+181 -0)
➕ deploy.sh (+341 -0)
📝 flowsint-app/src/api/api.ts (+1 -1)
📝 flowsint-app/src/api/auth-service.ts (+8 -4)
📝 flowsint-app/src/api/chat-transport.ts (+1 -1)
📝 flowsint-app/src/hooks/use-auth.ts (+2 -4)
📝 flowsint-app/src/hooks/use-events.ts (+1 -1)
📝 flowsint-app/src/hooks/use-graph-refresh.ts (+1 -1)
📝 flowsint-app/src/routes/login.tsx (+4 -4)
📝 flowsint-app/src/routes/register.tsx (+0 -6)
📝 flowsint-app/tsconfig.json (+1 -0)
📝 flowsint-app/vite.config.ts (+7 -2)
📝 flowsint-core/src/flowsint_core/core/services/chat_service.py (+14 -3)
➕ handoff/agent_handoff_fd1f24f_20260424_190612.tar.gz (+0 -0)
➕ handoff/agent_handoff_fd1f24f_20260424_190612/AGENT_PROMPT.md (+26 -0)
➕ handoff/agent_handoff_fd1f24f_20260424_190612/CHANGED_FILES.txt (+18 -0)

...and 10 more files

📄 Description

This PR supersedes the closed #139 and includes follow-up fixes from review feedback.

What was fixed:

Pin Neo4j image to neo4j:5 in install.sh.
Ensure uv is available in PATH after installer run in setup.sh.
Export .env.production values with set -a; source ...; set +a in deploy flow.
Standardize on MASTER_VAULT_KEY_V1 in deploy/start/setup templates.
Align generated env names with compose usage (NEO4J_USERNAME, REDIS_URL, etc.).
Fix health checks to use /health endpoint.
Remove duplicate host service startup in start.sh dev all mode.
Add command-style parsing support in start.sh for status/stop.
Update COMMANDS.makefile targets for stop/status and DB backup/restore/shell credentials.

Validation:

bash -n setup.sh install.sh deploy.sh start.sh
make -f COMMANDS.makefile help

Notes:

Previous PR was closed; this PR is opened from the same head branch with the latest commit cb6ba48.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/reconurge/flowsint/pull/140 **Author:** [@Abdullakala](https://github.com/Abdullakala) **Created:** 4/24/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (3) - [`fd1f24f`](https://github.com/reconurge/flowsint/commit/fd1f24f091460097719cc3fd80a18c27405579b3) chore: add setup/install/deploy/start automation and update app/core changes - [`292c7ed`](https://github.com/reconurge/flowsint/commit/292c7ed3f6df494b23442ba41a5aded1a175a3e6) chore: add handoff bundle scripts and artifacts - [`cb6ba48`](https://github.com/reconurge/flowsint/commit/cb6ba48bc94c920b0ddb7a42c33524169a5fc378) fix: address PR review comments for setup/deploy/start scripts ### 📊 Changes **30 files changed** (+5993 additions, -27 deletions) <details> <summary>View changed files</summary> ➕ `COMMANDS.makefile` (+264 -0) ➕ `FILES_INDEX.md` (+427 -0) ➕ `QUICK_REFERENCE.sh` (+385 -0) ➕ `SETUP_DEPLOYMENT_GUIDE.md` (+368 -0) ➕ `agent_handoff_bundle.sh` (+181 -0) ➕ `deploy.sh` (+341 -0) 📝 `flowsint-app/src/api/api.ts` (+1 -1) 📝 `flowsint-app/src/api/auth-service.ts` (+8 -4) 📝 `flowsint-app/src/api/chat-transport.ts` (+1 -1) 📝 `flowsint-app/src/hooks/use-auth.ts` (+2 -4) 📝 `flowsint-app/src/hooks/use-events.ts` (+1 -1) 📝 `flowsint-app/src/hooks/use-graph-refresh.ts` (+1 -1) 📝 `flowsint-app/src/routes/login.tsx` (+4 -4) 📝 `flowsint-app/src/routes/register.tsx` (+0 -6) 📝 `flowsint-app/tsconfig.json` (+1 -0) 📝 `flowsint-app/vite.config.ts` (+7 -2) 📝 `flowsint-core/src/flowsint_core/core/services/chat_service.py` (+14 -3) ➕ `handoff/agent_handoff_fd1f24f_20260424_190612.tar.gz` (+0 -0) ➕ `handoff/agent_handoff_fd1f24f_20260424_190612/AGENT_PROMPT.md` (+26 -0) ➕ `handoff/agent_handoff_fd1f24f_20260424_190612/CHANGED_FILES.txt` (+18 -0) _...and 10 more files_ </details> ### 📄 Description This PR supersedes the closed #139 and includes follow-up fixes from review feedback. What was fixed: - Pin Neo4j image to `neo4j:5` in `install.sh`. - Ensure `uv` is available in PATH after installer run in `setup.sh`. - Export `.env.production` values with `set -a; source ...; set +a` in deploy flow. - Standardize on `MASTER_VAULT_KEY_V1` in deploy/start/setup templates. - Align generated env names with compose usage (`NEO4J_USERNAME`, `REDIS_URL`, etc.). - Fix health checks to use `/health` endpoint. - Remove duplicate host service startup in `start.sh` dev `all` mode. - Add command-style parsing support in `start.sh` for `status`/`stop`. - Update `COMMANDS.makefile` targets for stop/status and DB backup/restore/shell credentials. Validation: - `bash -n setup.sh install.sh deploy.sh start.sh` - `make -f COMMANDS.makefile help` Notes: - Previous PR was closed; this PR is opened from the same head branch with the latest commit `cb6ba48`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-03 01:59:45 -05:00

GiteaMirror closed this issue

2026-05-03 01:59:45 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/flowsint#1127