github-starred/flowsint
2
0
Fork 0
mirror of https://github.com/reconurge/flowsint.git synced 2026-11-08 14:35:41 -06:00
Code Issues 988 Packages Projects Releases 15 Wiki Activity

chore: wire flowsint-app into make lint/lint-fix

Browse Source 
make lint was Python-only (PY_SRC never included flowsint-app) —
frontend prettier/eslint lived solely in flowsint-app's own yarn
scripts, disconnected from the repo's single lint entry point. Both
are 0-errors clean today (eslint's ~130 findings are all warnings),
same bar the Python side is already held to, so added as blocking
rather than a separate opt-in step. CONTRIBUTING.md updated to match.
This commit is contained in:
dextmorgn
2026-08-25 09:33:37 +02:00
parent a33705271f
commit 88828c5f88
2 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CONTRIBUTING.md
+3 -5
View File
@@ -11,7 +11,7 @@ Run the checks for whatever you touched, not just the file you think is affected
From the repo root:
```bash
make lint # ruff format --check + ruff check, whole repo
make lint # ruff format --check + ruff check (whole repo) + frontend prettier/eslint check
make typecheck # mypy, ratcheted to files this branch touches vs origin/main
```
@@ -21,16 +21,14 @@ Then, for whichever package(s) you changed:
cd <package> && uv run pytest -q
```
`make lint-fix` applies ruff's safe autofixes if `make lint` complains.
`make lint-fix` applies ruff's safe autofixes, plus `yarn format`/`yarn lint` for the frontend, if `make lint` complains.
### Frontend (`flowsint-app`)
From `flowsint-app/`:
`make lint`/`make lint-fix` from the repo root already cover prettier + eslint for `flowsint-app`. The rest, from `flowsint-app/`:
```bash
npx tsc --noEmit # types
npx eslint <files you touched> # lint must be 0 errors (warnings are fine)
npx prettier --check <files> # format (--write to fix)
npx vitest run # unit tests
yarn build # full build
```
Makefile
+6 -1
View File
@@ -152,14 +152,19 @@ PY_SRC := flowsint-core/src flowsint-core/tests \
# regression here is new debt — no reason to let it in. ruff replaces
# black+isort+flake8 (one tool, one config — see [tool.ruff] in the root
# pyproject.toml, which every package's ruff invocation inherits by walking
# up the directory tree to find it).
# up the directory tree to find it). Frontend prettier/eslint are just as
# clean today (0 errors — eslint's ~130 remaining findings are all
# warnings, e.g. no-explicit-any, not failures), so they're blocking here
# too rather than living only in flowsint-app's own yarn scripts.
lint:
uv run ruff format --check $(PY_SRC)
uv run ruff check $(PY_SRC)
cd flowsint-app && yarn format:check && yarn lint:check
lint-fix:
uv run ruff format $(PY_SRC)
uv run ruff check --fix $(PY_SRC)
cd flowsint-app && yarn format && yarn lint
# mypy has ~2200 pre-existing errors across the workspace (real, not fixed
# blindly in one pass — see CI notes). Gating full-repo would be a