In the getMedia function for Medium, Nitter, RSS and Tumblr we checked the content and/or description of an RSS feed entry for a media file, but we didn't pass the string to the unescape function first, so that we might missed some media files, because our regular expression were not able to find an image.
Now we are using the unescape function before using our regular expression to find the image, similar to how we are also applying the unescape function before we save the item description.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/feeddeck/feeddeck/pull/75
**Author:** [@ricoberger](https://github.com/ricoberger)
**Created:** 11/25/2023
**Status:** ✅ Merged
**Merged:** 11/25/2023
**Merged by:** [@ricoberger](https://github.com/ricoberger)
**Base:** `main` ← **Head:** `core-fix-getMedia-function`
---
### 📝 Commits (1)
- [`914e521`](https://github.com/feeddeck/feeddeck/commit/914e521aa9ae8311049d84f7c62169017f50f299) [core] Fix `getMedia` Function
### 📊 Changes
**4 files changed** (+6 additions, -6 deletions)
<details>
<summary>View changed files</summary>
📝 `supabase/functions/_shared/feed/medium.ts` (+2 -2)
📝 `supabase/functions/_shared/feed/nitter.ts` (+1 -1)
📝 `supabase/functions/_shared/feed/rss.ts` (+2 -2)
📝 `supabase/functions/_shared/feed/tumblr.ts` (+1 -1)
</details>
### 📄 Description
In the `getMedia` function for Medium, Nitter, RSS and Tumblr we checked the content and/or description of an RSS feed entry for a media file, but we didn't pass the string to the `unescape` function first, so that we might missed some media files, because our regular expression were not able to find an image.
Now we are using the `unescape` function before using our regular expression to find the image, similar to how we are also applying the `unescape` function before we save the item description.
<!--
Keep PR title verbose enough and add prefix telling about what source it touches e.g "[rss] Add feature xyz" or if the
the PR is not realated to a source use "[core]", e.g. "[core] Fix xyz".
If you add a breaking change within your PR you should add ":warning:" to the title,
e.g. ":warning: [core] My breaking change"
-->
<!--
Description of what have been changed. Please also reference an issue, when available.
-->
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/feeddeck/feeddeck/pull/75
Author: @ricoberger
Created: 11/25/2023
Status: ✅ Merged
Merged: 11/25/2023
Merged by: @ricoberger
Base:
main← Head:core-fix-getMedia-function📝 Commits (1)
914e521[core] FixgetMediaFunction📊 Changes
4 files changed (+6 additions, -6 deletions)
View changed files
📝
supabase/functions/_shared/feed/medium.ts(+2 -2)📝
supabase/functions/_shared/feed/nitter.ts(+1 -1)📝
supabase/functions/_shared/feed/rss.ts(+2 -2)📝
supabase/functions/_shared/feed/tumblr.ts(+1 -1)📄 Description
In the
getMediafunction for Medium, Nitter, RSS and Tumblr we checked the content and/or description of an RSS feed entry for a media file, but we didn't pass the string to theunescapefunction first, so that we might missed some media files, because our regular expression were not able to find an image.Now we are using the
unescapefunction before using our regular expression to find the image, similar to how we are also applying theunescapefunction before we save the item description.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.