To test the web build on every PR to avoid such issues, the CI/CD pipeline for the web build is now also run on every PR. On PRs we skip the upload to Cloudflare for the web build.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/feeddeck/feeddeck/pull/185
**Author:** [@ricoberger](https://github.com/ricoberger)
**Created:** 8/6/2024
**Status:** ✅ Merged
**Merged:** 8/6/2024
**Merged by:** [@ricoberger](https://github.com/ricoberger)
**Base:** `main` ← **Head:** `core-fix-web-build`
---
### 📝 Commits (1)
- [`bdd054b`](https://github.com/feeddeck/feeddeck/commit/bdd054ba3b1478acc73419ddd5874b6dd1be8744) [core] Fix Web Build
### 📊 Changes
**6 files changed** (+46 additions, -5 deletions)
<details>
<summary>View changed files</summary>
📝 `.github/workflows/continuous-delivery.yaml` (+6 -3)
📝 `app/lib/main.dart` (+4 -2)
➕ `app/lib/widgets/item/details/utils/item_audio_palyer/item_audio_player_init/item_audio_player_init.dart` (+11 -0)
➕ `app/lib/widgets/item/details/utils/item_audio_palyer/item_audio_player_init/item_audio_player_init_native.dart` (+12 -0)
➕ `app/lib/widgets/item/details/utils/item_audio_palyer/item_audio_player_init/item_audio_player_init_stub.dart` (+5 -0)
➕ `app/lib/widgets/item/details/utils/item_audio_palyer/item_audio_player_init/item_audio_player_init_web.dart` (+8 -0)
</details>
### 📄 Description
Fix web build be initializing `JustAudioMediaKit` only on Linux and Windows where it is really used. The corresponding issue for the broken web build can be found here https://github.com/Pato05/just_audio_media_kit/issues/15.
To test the web build on every PR to avoid such issues, the CI/CD pipeline for the web build is now also run on every PR. On PRs we skip the upload to Cloudflare for the web build.
<!--
Keep PR title verbose enough and add prefix telling about what source it touches e.g "[rss] Add feature xyz" or if the
the PR is not realated to a source use "[core]", e.g. "[core] Fix xyz".
If you add a breaking change within your PR you should add ":warning:" to the title,
e.g. ":warning: [core] My breaking change"
-->
<!--
Description of what have been changed. Please also reference an issue, when available.
-->
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/feeddeck/feeddeck/pull/185
Author: @ricoberger
Created: 8/6/2024
Status: ✅ Merged
Merged: 8/6/2024
Merged by: @ricoberger
Base:
main← Head:core-fix-web-build📝 Commits (1)
bdd054b[core] Fix Web Build📊 Changes
6 files changed (+46 additions, -5 deletions)
View changed files
📝
.github/workflows/continuous-delivery.yaml(+6 -3)📝
app/lib/main.dart(+4 -2)➕
app/lib/widgets/item/details/utils/item_audio_palyer/item_audio_player_init/item_audio_player_init.dart(+11 -0)➕
app/lib/widgets/item/details/utils/item_audio_palyer/item_audio_player_init/item_audio_player_init_native.dart(+12 -0)➕
app/lib/widgets/item/details/utils/item_audio_palyer/item_audio_player_init/item_audio_player_init_stub.dart(+5 -0)➕
app/lib/widgets/item/details/utils/item_audio_palyer/item_audio_player_init/item_audio_player_init_web.dart(+8 -0)📄 Description
Fix web build be initializing
JustAudioMediaKitonly on Linux and Windows where it is really used. The corresponding issue for the broken web build can be found here https://github.com/Pato05/just_audio_media_kit/issues/15.To test the web build on every PR to avoid such issues, the CI/CD pipeline for the web build is now also run on every PR. On PRs we skip the upload to Cloudflare for the web build.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.