On Windows and Linux it could happen that the audio playback for a podcast wasn't stopped when the item details view for a podcast item was closed.
This commit "fixes" the problem, by pausing the audio player, before the widget is disposed.
This commit also fixes the condition when the background audio services should be initialized in the main.dart file. Instead of the macOS check, we checked for iOS twice.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/feeddeck/feeddeck/pull/84
**Author:** [@ricoberger](https://github.com/ricoberger)
**Created:** 11/29/2023
**Status:** ✅ Merged
**Merged:** 11/29/2023
**Merged by:** [@ricoberger](https://github.com/ricoberger)
**Base:** `main` ← **Head:** `podcast-stop-audio-playback-on-windows-and-linux`
---
### 📝 Commits (1)
- [`94fa577`](https://github.com/feeddeck/feeddeck/commit/94fa577a6fbabe799b11988339c1a4fa6fe74b15) [podcast] Stop Audio Playback on Windows and Linux
### 📊 Changes
**2 files changed** (+2 additions, -1 deletions)
<details>
<summary>View changed files</summary>
📝 `app/lib/main.dart` (+1 -1)
📝 `app/lib/widgets/item/details/utils/item_audio_palyer/item_audio_player.dart` (+1 -0)
</details>
### 📄 Description
On Windows and Linux it could happen that the audio playback for a podcast wasn't stopped when the item details view for a podcast item was closed.
This commit "fixes" the problem, by pausing the audio player, before the widget is disposed.
This commit also fixes the condition when the background audio services should be initialized in the `main.dart` file. Instead of the macOS check, we checked for iOS twice.
<!--
Keep PR title verbose enough and add prefix telling about what source it touches e.g "[rss] Add feature xyz" or if the
the PR is not realated to a source use "[core]", e.g. "[core] Fix xyz".
If you add a breaking change within your PR you should add ":warning:" to the title,
e.g. ":warning: [core] My breaking change"
-->
<!--
Description of what have been changed. Please also reference an issue, when available.
-->
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/feeddeck/feeddeck/pull/84
Author: @ricoberger
Created: 11/29/2023
Status: ✅ Merged
Merged: 11/29/2023
Merged by: @ricoberger
Base:
main← Head:podcast-stop-audio-playback-on-windows-and-linux📝 Commits (1)
94fa577[podcast] Stop Audio Playback on Windows and Linux📊 Changes
2 files changed (+2 additions, -1 deletions)
View changed files
📝
app/lib/main.dart(+1 -1)📝
app/lib/widgets/item/details/utils/item_audio_palyer/item_audio_player.dart(+1 -0)📄 Description
On Windows and Linux it could happen that the audio playback for a podcast wasn't stopped when the item details view for a podcast item was closed.
This commit "fixes" the problem, by pausing the audio player, before the widget is disposed.
This commit also fixes the condition when the background audio services should be initialized in the
main.dartfile. Instead of the macOS check, we checked for iOS twice.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.