This commit fixes two bugs within the Podcast player.
It could happen that the play time and remaining time was not shown correctly in the player. This mainly occured in Safari and is now fixed by not using a regular expression to show the time, but instead we have added a new "_printDuration" function which handles the formatting of the durations.
Not only, but mainly on Safari it could also happen, that once a Podcast was started and then paused, the loading spinner was displayed and a user could not continue with the Podcast. This is now fixed, by removing the spinner and only show the play, pause or replay button. As loading indication we are now only using the seek bar.
Last but not least this commit also improves the readability of the code, for parsing the icon of a Podcast feed.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/feeddeck/feeddeck/pull/37
**Author:** [@ricoberger](https://github.com/ricoberger)
**Created:** 10/18/2023
**Status:** ✅ Merged
**Merged:** 10/18/2023
**Merged by:** [@ricoberger](https://github.com/ricoberger)
**Base:** `main` ← **Head:** `podcast-fix-duration-and-play-button`
---
### 📝 Commits (1)
- [`ad31f1a`](https://github.com/feeddeck/feeddeck/commit/ad31f1aa38bb49a3048487fda41a82d74586e2b9) [podcast] Fix Duration and Play Button
### 📊 Changes
**3 files changed** (+24 additions, -24 deletions)
<details>
<summary>View changed files</summary>
📝 `app/lib/widgets/item/details/utils/item_audio_palyer/item_audio_player_controlbuttons.dart` (+2 -9)
📝 `app/lib/widgets/item/details/utils/item_audio_palyer/item_audio_player_seekbar.dart` (+12 -8)
📝 `supabase/functions/_shared/feed/podcast.ts` (+10 -7)
</details>
### 📄 Description
This commit fixes two bugs within the Podcast player.
It could happen that the play time and remaining time was not shown correctly in the player. This mainly occured in Safari and is now fixed by not using a regular expression to show the time, but instead we have added a new "_printDuration" function which handles the formatting of the durations.
Not only, but mainly on Safari it could also happen, that once a Podcast was started and then paused, the loading spinner was displayed and a user could not continue with the Podcast. This is now fixed, by removing the spinner and only show the play, pause or replay button. As loading indication we are now only using the seek bar.
Last but not least this commit also improves the readability of the code, for parsing the icon of a Podcast feed.
<!--
Keep PR title verbose enough and add prefix telling about what source it touches e.g "[rss] Add feature xyz" or if the
the PR is not realated to a source use "[core]", e.g. "[core] Fix xyz".
If you add a breaking change within your PR you should add ":warning:" to the title,
e.g. ":warning: [core] My breaking change"
-->
<!--
Description of what have been changed. Please also reference an issue, when available.
-->
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/feeddeck/feeddeck/pull/37
Author: @ricoberger
Created: 10/18/2023
Status: ✅ Merged
Merged: 10/18/2023
Merged by: @ricoberger
Base:
main← Head:podcast-fix-duration-and-play-button📝 Commits (1)
ad31f1a[podcast] Fix Duration and Play Button📊 Changes
3 files changed (+24 additions, -24 deletions)
View changed files
📝
app/lib/widgets/item/details/utils/item_audio_palyer/item_audio_player_controlbuttons.dart(+2 -9)📝
app/lib/widgets/item/details/utils/item_audio_palyer/item_audio_player_seekbar.dart(+12 -8)📝
supabase/functions/_shared/feed/podcast.ts(+10 -7)📄 Description
This commit fixes two bugs within the Podcast player.
It could happen that the play time and remaining time was not shown correctly in the player. This mainly occured in Safari and is now fixed by not using a regular expression to show the time, but instead we have added a new "_printDuration" function which handles the formatting of the durations.
Not only, but mainly on Safari it could also happen, that once a Podcast was started and then paused, the loading spinner was displayed and a user could not continue with the Podcast. This is now fixed, by removing the spinner and only show the play, pause or replay button. As loading indication we are now only using the seek bar.
Last but not least this commit also improves the readability of the code, for parsing the icon of a Podcast feed.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.